All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
	Ludvig.Parsson@axis.com, jens.wiklander@linaro.org,
	etienne.carriere@linaro.org, vincent.guittot@linaro.org,
	linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH] firmware: arm_scmi: Resolve dependency with TEE subsystem
Date: Fri, 11 Nov 2022 15:23:13 +0530	[thread overview]
Message-ID: <20221111095313.2010815-1-sumit.garg@linaro.org> (raw)

The OP-TEE SCMI transport channel is dependent on TEE subsystem to be
initialized first. But currently the Arm SCMI subsystem and TEE
subsystem are invoked on the same initcall level as subsystem_init().

It is observed that the SCMI subsystem initcall is invoked prior to TEE
subsystem initcall. This leads to unwanted error messages regarding TEE
bus is not present yet. Although, -EPROBE_DEFER tries to workaround that
problem.

Lets try to resolve inter subsystem dependency problem via shifting Arm
SCMI subsystem to subsystem_init_sync() initcall level.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
 drivers/firmware/arm_scmi/driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index f818d00bb2c6..f43e52541da4 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2667,7 +2667,7 @@ static int __init scmi_driver_init(void)
 
 	return platform_driver_register(&scmi_driver);
 }
-subsys_initcall(scmi_driver_init);
+subsys_initcall_sync(scmi_driver_init);
 
 static void __exit scmi_driver_exit(void)
 {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
	Ludvig.Parsson@axis.com, jens.wiklander@linaro.org,
	etienne.carriere@linaro.org, vincent.guittot@linaro.org,
	linux-kernel@vger.kernel.org, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH] firmware: arm_scmi: Resolve dependency with TEE subsystem
Date: Fri, 11 Nov 2022 15:23:13 +0530	[thread overview]
Message-ID: <20221111095313.2010815-1-sumit.garg@linaro.org> (raw)

The OP-TEE SCMI transport channel is dependent on TEE subsystem to be
initialized first. But currently the Arm SCMI subsystem and TEE
subsystem are invoked on the same initcall level as subsystem_init().

It is observed that the SCMI subsystem initcall is invoked prior to TEE
subsystem initcall. This leads to unwanted error messages regarding TEE
bus is not present yet. Although, -EPROBE_DEFER tries to workaround that
problem.

Lets try to resolve inter subsystem dependency problem via shifting Arm
SCMI subsystem to subsystem_init_sync() initcall level.

Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
 drivers/firmware/arm_scmi/driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index f818d00bb2c6..f43e52541da4 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2667,7 +2667,7 @@ static int __init scmi_driver_init(void)
 
 	return platform_driver_register(&scmi_driver);
 }
-subsys_initcall(scmi_driver_init);
+subsys_initcall_sync(scmi_driver_init);
 
 static void __exit scmi_driver_exit(void)
 {
-- 
2.34.1


             reply	other threads:[~2022-11-11  9:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11  9:53 Sumit Garg [this message]
2022-11-11  9:53 ` [PATCH] firmware: arm_scmi: Resolve dependency with TEE subsystem Sumit Garg
2022-11-11 14:38 ` Sudeep Holla
2022-11-11 14:38   ` Sudeep Holla
2022-11-11 15:00   ` Ludvig Pärsson
2022-11-11 15:00     ` Ludvig Pärsson
2022-11-11 15:13     ` Sudeep Holla
2022-11-11 15:13       ` Sudeep Holla
2022-11-14  6:31   ` Sumit Garg
2022-11-14  6:31     ` Sumit Garg
2022-11-14 10:26     ` Sudeep Holla
2022-11-14 10:26       ` Sudeep Holla
2022-11-14 11:29       ` Etienne Carriere
2022-11-14 11:29         ` Etienne Carriere
2022-11-14 13:47         ` Ludvig Pärsson
2022-11-14 13:47           ` Ludvig Pärsson
2022-11-22 17:48           ` Cristian Marussi
2022-11-22 17:48             ` Cristian Marussi
2022-11-29 10:49             ` Ludvig Pärsson
2022-11-29 10:49               ` Ludvig Pärsson
2022-11-29 12:15               ` Cristian Marussi
2022-11-29 12:15                 ` Cristian Marussi
2022-11-29 14:57                 ` Etienne Carriere
2022-11-29 14:57                   ` Etienne Carriere
2022-11-29 17:30                   ` Cristian Marussi
2022-11-29 17:30                     ` Cristian Marussi
2022-11-17  9:41         ` Sumit Garg
2022-11-17  9:41           ` Sumit Garg
2022-11-17 11:19           ` Sudeep Holla
2022-11-17 11:19             ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221111095313.2010815-1-sumit.garg@linaro.org \
    --to=sumit.garg@linaro.org \
    --cc=Ludvig.Parsson@axis.com \
    --cc=cristian.marussi@arm.com \
    --cc=etienne.carriere@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.