From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Miroslav Rezanina <mrezanin@redhat.com>
Subject: [PULL 2/8] tulip: Remove unused variable
Date: Fri, 11 Nov 2022 11:30:42 +0100 [thread overview]
Message-ID: <20221111103048.202519-3-thuth@redhat.com> (raw)
In-Reply-To: <20221111103048.202519-1-thuth@redhat.com>
From: Miroslav Rezanina <mrezanin@redhat.com>
Variable n used in tulip_idblock_crc function is only incremented but never read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <02e1560d115c208df32236df8916fed98429fda1.1668009030.git.mrezanin@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/net/tulip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index b9e42c322a..c2b3b1bdfa 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -870,11 +870,10 @@ static const MemoryRegionOps tulip_ops = {
static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
{
- int word, n;
+ int word;
int bit;
unsigned char bitval, crc;
const int len = 9;
- n = 0;
crc = -1;
for (word = 0; word < len; word++) {
@@ -887,7 +886,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
srom[len - 1] = (srom[len - 1] & 0xff00) | (unsigned short)crc;
break;
}
- n++;
bitval = ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1);
crc = crc << 1;
if (bitval == 1) {
--
2.31.1
next prev parent reply other threads:[~2022-11-11 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 10:30 [PULL 0/8] Misc fixes Thomas Huth
2022-11-11 10:30 ` [PULL 1/8] rtl8139: Remove unused variable Thomas Huth
2022-11-11 10:30 ` Thomas Huth [this message]
2022-11-11 10:30 ` [PULL 3/8] qemu-img: remove " Thomas Huth
2022-11-11 10:30 ` [PULL 4/8] host-libusb: Remove " Thomas Huth
2022-11-11 10:30 ` [PULL 5/8] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15 Thomas Huth
2022-11-11 10:30 ` [PULL 6/8] qga: Allow building of the guest agent without system emulators or tools Thomas Huth
2022-11-11 10:30 ` [PULL 7/8] net: Replace TAB indentations with spaces Thomas Huth
2022-11-11 10:30 ` [PULL 8/8] Fix several typos in documentation (found by codespell) Thomas Huth
2022-11-12 2:32 ` [PULL 0/8] Misc fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111103048.202519-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.