All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>
Subject: [PULL 5/8] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15
Date: Fri, 11 Nov 2022 11:30:45 +0100	[thread overview]
Message-ID: <20221111103048.202519-6-thuth@redhat.com> (raw)
In-Reply-To: <20221111103048.202519-1-thuth@redhat.com>

Clang 15 from Fedora 37 complains:

 ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but
 not used [-Werror,-Wunused-but-set-variable]
   Int  n;                     /* output bunch counter */
        ^
 1 error generated.

Remove the unused variable to silence the compiler warning.

Message-Id: <20221110131112.104283-1-thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 libdecnumber/dpd/decimal64.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libdecnumber/dpd/decimal64.c b/libdecnumber/dpd/decimal64.c
index 4816176410..290dbe8177 100644
--- a/libdecnumber/dpd/decimal64.c
+++ b/libdecnumber/dpd/decimal64.c
@@ -617,7 +617,6 @@ static const uInt multies[]={131073, 26215, 5243, 1049, 210};
 #endif
 void decDigitsToDPD(const decNumber *dn, uInt *targ, Int shift) {
   Int  cut;		      /* work */
-  Int  n;		      /* output bunch counter */
   Int  digits=dn->digits;     /* digit countdown */
   uInt dpd;		      /* densely packed decimal value */
   uInt bin;		      /* binary value 0-999 */
@@ -676,7 +675,7 @@ void decDigitsToDPD(const decNumber *dn, uInt *targ, Int shift) {
     bin=0;			   /* [keep compiler quiet] */
   #endif
 
-  for(n=0; digits>0; n++) {	   /* each output bunch */
+  while (digits > 0) {             /* each output bunch */
     #if DECDPUN==3		   /* fast path, 3-at-a-time */
       bin=*inu;			   /* 3 digits ready for convert */
       digits-=3;		   /* [may go negative] */
-- 
2.31.1



  parent reply	other threads:[~2022-11-11 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 10:30 [PULL 0/8] Misc fixes Thomas Huth
2022-11-11 10:30 ` [PULL 1/8] rtl8139: Remove unused variable Thomas Huth
2022-11-11 10:30 ` [PULL 2/8] tulip: " Thomas Huth
2022-11-11 10:30 ` [PULL 3/8] qemu-img: remove " Thomas Huth
2022-11-11 10:30 ` [PULL 4/8] host-libusb: Remove " Thomas Huth
2022-11-11 10:30 ` Thomas Huth [this message]
2022-11-11 10:30 ` [PULL 6/8] qga: Allow building of the guest agent without system emulators or tools Thomas Huth
2022-11-11 10:30 ` [PULL 7/8] net: Replace TAB indentations with spaces Thomas Huth
2022-11-11 10:30 ` [PULL 8/8] Fix several typos in documentation (found by codespell) Thomas Huth
2022-11-12  2:32 ` [PULL 0/8] Misc fixes Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221111103048.202519-6-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.