* [PATCH] platform: generic/allwinner: Optimize header file location
@ 2022-11-17 7:17 zhangleizheng
2022-11-17 7:28 ` Bin Meng
2022-11-17 15:04 ` Samuel Holland
0 siblings, 2 replies; 3+ messages in thread
From: zhangleizheng @ 2022-11-17 7:17 UTC (permalink / raw)
To: opensbi
From: Leizheng Zhang <zhangleizheng@eswincomputing.com>
Optimize sbi/sbi_console.h file location
Signed-off-by: Leizheng Zhang <zhangleizheng@eswincomputing.com>
---
platform/generic/allwinner/sun20i-d1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/platform/generic/allwinner/sun20i-d1.c b/platform/generic/allwinner/sun20i-d1.c
index 6a502e5..d2a0f53 100644
--- a/platform/generic/allwinner/sun20i-d1.c
+++ b/platform/generic/allwinner/sun20i-d1.c
@@ -7,6 +7,7 @@
#include <platform_override.h>
#include <thead_c9xx.h>
#include <sbi/riscv_io.h>
+#include <sbi/sbi_console.h>
#include <sbi/sbi_bitops.h>
#include <sbi/sbi_ecall_interface.h>
#include <sbi/sbi_error.h>
@@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
return 0;
}
-#include <sbi/sbi_console.h>
-
static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
{
unsigned long mip_val;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] platform: generic/allwinner: Optimize header file location
2022-11-17 7:17 [PATCH] platform: generic/allwinner: Optimize header file location zhangleizheng
@ 2022-11-17 7:28 ` Bin Meng
2022-11-17 15:04 ` Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2022-11-17 7:28 UTC (permalink / raw)
To: opensbi
On Thu, Nov 17, 2022 at 3:18 PM <zhangleizheng@eswincomputing.com> wrote:
>
> From: Leizheng Zhang <zhangleizheng@eswincomputing.com>
>
> Optimize sbi/sbi_console.h file location
>
> Signed-off-by: Leizheng Zhang <zhangleizheng@eswincomputing.com>
> ---
> platform/generic/allwinner/sun20i-d1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/platform/generic/allwinner/sun20i-d1.c b/platform/generic/allwinner/sun20i-d1.c
> index 6a502e5..d2a0f53 100644
> --- a/platform/generic/allwinner/sun20i-d1.c
> +++ b/platform/generic/allwinner/sun20i-d1.c
> @@ -7,6 +7,7 @@
> #include <platform_override.h>
> #include <thead_c9xx.h>
> #include <sbi/riscv_io.h>
> +#include <sbi/sbi_console.h>
nits: alphabetically this should be inserted after sbi_bitops.h
> #include <sbi/sbi_bitops.h>
> #include <sbi/sbi_ecall_interface.h>
> #include <sbi/sbi_error.h>
> @@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
> return 0;
> }
>
> -#include <sbi/sbi_console.h>
> -
> static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
> {
> unsigned long mip_val;
> --
Otherwise,
Reviewed-by: Bin Meng <bmeng@tinylab.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] platform: generic/allwinner: Optimize header file location
2022-11-17 7:17 [PATCH] platform: generic/allwinner: Optimize header file location zhangleizheng
2022-11-17 7:28 ` Bin Meng
@ 2022-11-17 15:04 ` Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Holland @ 2022-11-17 15:04 UTC (permalink / raw)
To: opensbi
On 11/17/22 01:17, zhangleizheng at eswincomputing.com wrote:
> From: Leizheng Zhang <zhangleizheng@eswincomputing.com>
>
> Optimize sbi/sbi_console.h file location
>
> Signed-off-by: Leizheng Zhang <zhangleizheng@eswincomputing.com>
> ---
> platform/generic/allwinner/sun20i-d1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/platform/generic/allwinner/sun20i-d1.c b/platform/generic/allwinner/sun20i-d1.c
> index 6a502e5..d2a0f53 100644
> --- a/platform/generic/allwinner/sun20i-d1.c
> +++ b/platform/generic/allwinner/sun20i-d1.c
> @@ -7,6 +7,7 @@
> #include <platform_override.h>
> #include <thead_c9xx.h>
> #include <sbi/riscv_io.h>
> +#include <sbi/sbi_console.h>
This header is not actually used anywhere in the file, so you can just
remove it.
Regards,
Samuel
> #include <sbi/sbi_bitops.h>
> #include <sbi/sbi_ecall_interface.h>
> #include <sbi/sbi_error.h>
> @@ -201,8 +202,6 @@ static int sun20i_d1_final_init(bool cold_boot, const struct fdt_match *match)
> return 0;
> }
>
> -#include <sbi/sbi_console.h>
> -
> static void thead_c9xx_pmu_ctr_enable_irq(uint32_t ctr_idx)
> {
> unsigned long mip_val;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-17 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 7:17 [PATCH] platform: generic/allwinner: Optimize header file location zhangleizheng
2022-11-17 7:28 ` Bin Meng
2022-11-17 15:04 ` Samuel Holland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.