All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuan Can <yuancan@huawei.com>
To: <andersson@kernel.org>, <mathieu.poirier@linaro.org>,
	<s-anna@ti.com>, <jaswinder.singh@linaro.org>, <t-kristo@ti.com>,
	<afd@ti.com>, <linux-remoteproc@vger.kernel.org>
Cc: <yuancan@huawei.com>
Subject: [PATCH] remoteproc: omap_remoteproc: Fix compile errors about casting
Date: Fri, 18 Nov 2022 07:47:55 +0000	[thread overview]
Message-ID: <20221118074755.121424-1-yuancan@huawei.com> (raw)

The following errors was given when compiling
drivers/remoteproc/omap_remoteproc.c:

drivers/remoteproc/omap_remoteproc.c: In function ‘omap_rproc_mbox_callback’:
drivers/remoteproc/omap_remoteproc.c:497:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  u32 msg = (u32)data;
            ^
drivers/remoteproc/omap_remoteproc.c: In function ‘omap_rproc_kick’:
drivers/remoteproc/omap_remoteproc.c:548:39: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  ret = mbox_send_message(oproc->mbox, (void *)vqid);
                                       ^
drivers/remoteproc/omap_remoteproc.c: In function ‘_omap_rproc_suspend’:
drivers/remoteproc/omap_remoteproc.c:783:39: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  ret = mbox_send_message(oproc->mbox, (void *)suspend_msg);
                                       ^
In file included from ./include/linux/device.h:15,
                 from ./include/linux/node.h:18,
                 from ./include/linux/cpu.h:17,
                 from ./include/linux/of_device.h:5,
                 from drivers/remoteproc/omap_remoteproc.c:22:
drivers/remoteproc/omap_remoteproc.c: In function ‘omap_rproc_of_get_internal_memories’:
drivers/remoteproc/omap_remoteproc.c:1211:16: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]
   dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %pK da 0x%x\n",
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 8841a66aaa7c ("mailbox/omap: adapt to the new mailbox framework")
Fixes: 5f31b232c674 ("remoteproc/omap: Add support for runtime auto-suspend/resume")
Fixes: 4a032199d3f7 ("remoteproc/omap: Add support to parse internal memories from DT")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 drivers/remoteproc/omap_remoteproc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index 430fab0266ed..be43b5d85e2b 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -494,7 +494,7 @@ static void omap_rproc_mbox_callback(struct mbox_client *client, void *data)
 						client);
 	struct device *dev = oproc->rproc->dev.parent;
 	const char *name = oproc->rproc->name;
-	u32 msg = (u32)data;
+	u32 msg = (u32)(unsigned long)data;
 
 	dev_dbg(dev, "mbox msg: 0x%x\n", msg);
 
@@ -545,7 +545,7 @@ static void omap_rproc_kick(struct rproc *rproc, int vqid)
 	}
 
 	/* send the index of the triggered virtqueue in the mailbox payload */
-	ret = mbox_send_message(oproc->mbox, (void *)vqid);
+	ret = mbox_send_message(oproc->mbox, (void *)(unsigned long)vqid);
 	if (ret < 0)
 		dev_err(dev, "failed to send mailbox message, status = %d\n",
 			ret);
@@ -780,7 +780,7 @@ static int _omap_rproc_suspend(struct rproc *rproc, bool auto_suspend)
 
 	reinit_completion(&oproc->pm_comp);
 	oproc->suspend_acked = false;
-	ret = mbox_send_message(oproc->mbox, (void *)suspend_msg);
+	ret = mbox_send_message(oproc->mbox, (void *)(unsigned long)suspend_msg);
 	if (ret < 0) {
 		dev_err(dev, "PM mbox_send_message failed: %d\n", ret);
 		return ret;
@@ -1208,7 +1208,7 @@ static int omap_rproc_of_get_internal_memories(struct platform_device *pdev,
 		oproc->mem[i].dev_addr = data->mems[i].dev_addr;
 		oproc->mem[i].size = resource_size(res);
 
-		dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %pK da 0x%x\n",
+		dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %pK da 0x%x\n",
 			data->mems[i].name, &oproc->mem[i].bus_addr,
 			oproc->mem[i].size, oproc->mem[i].cpu_addr,
 			oproc->mem[i].dev_addr);
-- 
2.17.1


             reply	other threads:[~2022-11-18  7:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  7:47 Yuan Can [this message]
2022-11-21 17:25 ` [PATCH] remoteproc: omap_remoteproc: Fix compile errors about casting Mathieu Poirier
2022-11-22  2:03   ` Yuan Can
2022-12-15  6:56     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221118074755.121424-1-yuancan@huawei.com \
    --to=yuancan@huawei.com \
    --cc=afd@ti.com \
    --cc=andersson@kernel.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=s-anna@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.