Re: [PATCH] remoteproc: omap_remoteproc: Fix compile errors about casting

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Yuan,

On 22/11/22 03:03, Yuan Can wrote:
> 在 2022/11/22 1:25, Mathieu Poirier 写道:
>> On Fri, Nov 18, 2022 at 07:47:55AM +0000, Yuan Can wrote:
>>> The following errors was given when compiling
>>> drivers/remoteproc/omap_remoteproc.c:
>>>
>>> drivers/remoteproc/omap_remoteproc.c: In function 
>>> ‘omap_rproc_mbox_callback’:
>>> drivers/remoteproc/omap_remoteproc.c:497:12: error: cast from pointer 
>>> to integer of different size [-Werror=pointer-to-int-cast]
>>>    u32 msg = (u32)data;
>>>              ^
>>> drivers/remoteproc/omap_remoteproc.c: In function ‘omap_rproc_kick’:
>>> drivers/remoteproc/omap_remoteproc.c:548:39: error: cast to pointer 
>>> from integer of different size [-Werror=int-to-pointer-cast]
>>>    ret = mbox_send_message(oproc->mbox, (void *)vqid);
>>>                                         ^
>>> drivers/remoteproc/omap_remoteproc.c: In function ‘_omap_rproc_suspend’:
>>> drivers/remoteproc/omap_remoteproc.c:783:39: error: cast to pointer 
>>> from integer of different size [-Werror=int-to-pointer-cast]
>>>    ret = mbox_send_message(oproc->mbox, (void *)suspend_msg);
>>>                                         ^
>>> In file included from ./include/linux/device.h:15,
>>>                   from ./include/linux/node.h:18,
>>>                   from ./include/linux/cpu.h:17,
>>>                   from ./include/linux/of_device.h:5,
>>>                   from drivers/remoteproc/omap_remoteproc.c:22:
>>> drivers/remoteproc/omap_remoteproc.c: In function 
>>> ‘omap_rproc_of_get_internal_memories’:
>>> drivers/remoteproc/omap_remoteproc.c:1211:16: error: format ‘%x’ 
>>> expects argument of type ‘unsigned int’, but argument 6 has type 
>>> ‘size_t’ {aka ‘long unsigned int’} [-Werror=format=]
>>>     dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %pK da 0x%x\n",
>>>                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>> I am not seeing any of this on my side with gcc 9.4.0:
>>
>> $ arm-linux-gnueabihf-gcc --version
>> arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
>>
>> What version do you use?
> Thanks for the reply, I was working with the wrong cross compiler, sorry 
> about the noise.

Don't worry about being noisy ;) What would have helped here is if you
mentioned the version of the compiler you used in the commit description
(usually the output of '$CC --version').

Back to your patch content, the format string fix is correct (the 3rd
hunk).

Regard,

Phil.