From: Michael Walle <michael@walle.cc>
To: Jonathan Corbet <corbet@lwn.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Michael Walle <michael@walle.cc>
Subject: [PATCH v3 11/18] nvmem: core: allow to modify a cell before adding it
Date: Fri, 18 Nov 2022 19:51:11 +0100 [thread overview]
Message-ID: <20221118185118.1190044-12-michael@walle.cc> (raw)
In-Reply-To: <20221118185118.1190044-1-michael@walle.cc>
Provide a way to modify a cell before it will get added. This is useful
to attach a custom post processing hook via a layout.
Signed-off-by: Michael Walle <michael@walle.cc>
---
changes since v2:
- none
changes since v1:
- new patch
drivers/nvmem/core.c | 4 ++++
include/linux/nvmem-provider.h | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index f0c0bf3b8b25..264a15d26c7c 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -694,6 +694,7 @@ static int nvmem_validate_keepouts(struct nvmem_device *nvmem)
static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
{
+ struct nvmem_layout *layout = nvmem->layout;
struct device *dev = &nvmem->dev;
struct nvmem_cell_entry *cell;
struct device_node *child;
@@ -730,6 +731,9 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
info.np = of_node_get(child);
+ if (layout && layout->fixup_cell_info)
+ layout->fixup_cell_info(nvmem, layout, &info);
+
ret = nvmem_add_one_cell(nvmem, &info);
kfree(info.name);
if (ret) {
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 1930496d8854..bfaba5227ac9 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -157,6 +157,8 @@ struct nvmem_cell_table {
* @add_cells: Will be called if a nvmem device is found which
* has this layout. The function will add layout
* specific cells with nvmem_add_one_cell().
+ * @fixup_cell_info: Will be called before a cell is added. Can be
+ * used to modify the nvmem_cell_info.
* @owner: Pointer to struct module.
* @node: List node.
*
@@ -170,6 +172,9 @@ struct nvmem_layout {
const struct of_device_id *of_match_table;
int (*add_cells)(struct device *dev, struct nvmem_device *nvmem,
struct nvmem_layout *layout);
+ void (*fixup_cell_info)(struct nvmem_device *nvmem,
+ struct nvmem_layout *layout,
+ struct nvmem_cell_info *cell);
/* private */
struct module *owner;
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Jonathan Corbet <corbet@lwn.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Michael Walle <michael@walle.cc>
Subject: [PATCH v3 11/18] nvmem: core: allow to modify a cell before adding it
Date: Fri, 18 Nov 2022 19:51:11 +0100 [thread overview]
Message-ID: <20221118185118.1190044-12-michael@walle.cc> (raw)
In-Reply-To: <20221118185118.1190044-1-michael@walle.cc>
Provide a way to modify a cell before it will get added. This is useful
to attach a custom post processing hook via a layout.
Signed-off-by: Michael Walle <michael@walle.cc>
---
changes since v2:
- none
changes since v1:
- new patch
drivers/nvmem/core.c | 4 ++++
include/linux/nvmem-provider.h | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index f0c0bf3b8b25..264a15d26c7c 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -694,6 +694,7 @@ static int nvmem_validate_keepouts(struct nvmem_device *nvmem)
static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
{
+ struct nvmem_layout *layout = nvmem->layout;
struct device *dev = &nvmem->dev;
struct nvmem_cell_entry *cell;
struct device_node *child;
@@ -730,6 +731,9 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem)
info.np = of_node_get(child);
+ if (layout && layout->fixup_cell_info)
+ layout->fixup_cell_info(nvmem, layout, &info);
+
ret = nvmem_add_one_cell(nvmem, &info);
kfree(info.name);
if (ret) {
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 1930496d8854..bfaba5227ac9 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -157,6 +157,8 @@ struct nvmem_cell_table {
* @add_cells: Will be called if a nvmem device is found which
* has this layout. The function will add layout
* specific cells with nvmem_add_one_cell().
+ * @fixup_cell_info: Will be called before a cell is added. Can be
+ * used to modify the nvmem_cell_info.
* @owner: Pointer to struct module.
* @node: List node.
*
@@ -170,6 +172,9 @@ struct nvmem_layout {
const struct of_device_id *of_match_table;
int (*add_cells)(struct device *dev, struct nvmem_device *nvmem,
struct nvmem_layout *layout);
+ void (*fixup_cell_info)(struct nvmem_device *nvmem,
+ struct nvmem_layout *layout,
+ struct nvmem_cell_info *cell);
/* private */
struct module *owner;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-18 18:52 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:51 [PATCH v3 00/18] nvmem: core: introduce NVMEM layouts Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 01/18] net: add helper eth_addr_add() Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 02/18] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 21:31 ` Michael Walle
2022-11-18 21:31 ` Michael Walle
2022-11-18 21:40 ` [PATCH] of: property: special #nvmem-cell-cells handling Michael Walle
2022-11-18 21:40 ` Michael Walle
2022-11-18 21:52 ` Rob Herring
2022-11-18 21:52 ` Rob Herring
2022-11-18 22:03 ` Michael Walle
2022-11-18 22:03 ` Michael Walle
2022-11-22 23:44 ` Rob Herring
2022-11-22 23:44 ` Rob Herring
2022-11-23 12:24 ` Miquel Raynal
2022-11-23 12:24 ` Miquel Raynal
2022-11-18 18:51 ` [PATCH v3 03/18] nvmem: core: fix device node refcounting Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 04/18] nvmem: core: add an index parameter to the cell Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 05/18] nvmem: core: move struct nvmem_cell_info to nvmem-provider.h Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 06/18] nvmem: core: drop the removal of the cells in nvmem_add_cells() Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-21 7:56 ` Sascha Hauer
2022-11-21 7:56 ` Sascha Hauer
2022-11-18 18:51 ` [PATCH v3 07/18] nvmem: core: add nvmem_add_one_cell() Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 08/18] nvmem: core: use nvmem_add_one_cell() in nvmem_add_cells_from_of() Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 09/18] nvmem: core: introduce NVMEM layouts Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 10/18] nvmem: core: add per-cell post processing Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` Michael Walle [this message]
2022-11-18 18:51 ` [PATCH v3 11/18] nvmem: core: allow to modify a cell before adding it Michael Walle
2022-11-18 18:51 ` [PATCH v3 12/18] nvmem: imx-ocotp: replace global post processing with layouts Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 13/18] nvmem: cell: drop global cell_post_process Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 14/18] nvmem: core: provide own priv pointer in post process callback Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 15/18] nvmem: layouts: add sl28vpd layout Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 16/18] MAINTAINERS: add myself as sl28vpd nvmem layout driver Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 17/18] nvmem: layouts: Add ONIE tlv " Michael Walle
2022-11-18 18:51 ` Michael Walle
2022-11-21 7:51 ` Sascha Hauer
2022-11-21 7:51 ` Sascha Hauer
2022-11-23 9:52 ` Michael Walle
2022-11-23 9:52 ` Michael Walle
2022-11-18 18:51 ` [PATCH v3 18/18] MAINTAINERS: Add myself as ONIE tlv NVMEM layout maintainer Michael Walle
2022-11-18 18:51 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118185118.1190044-12-michael@walle.cc \
--to=michael@walle.cc \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.