[Buildroot] [PATCH 1/1] package/gptfdisk: fix runtime failure with popt 1.19

[Buildroot] [PATCH 1/1] package/gptfdisk: fix runtime failure with popt 1.19

[Fabrice Fontaine]

Fix the following runtime failure raised since bump of popt to version
1.19 in commit 895bfba93f6e5535f2132aeea144d2cd87ebc71b:

Problem opening  for reading! Error is 2.
The specified file does not exist!

Fixes:
 - No autobuilder failure

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...h-of-sgdisk-when-compiled-with-lates.patch | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)
 create mode 100644 package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch

diff --git a/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch b/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch
new file mode 100644
index 0000000000..bdeedd95cc
--- /dev/null
+++ b/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch
@@ -0,0 +1,60 @@
+From 5d5e76d369a412bfb3d2cebb5fc0a7509cef878d Mon Sep 17 00:00:00 2001
+From: Rod Smith <rodsmith@rodsbooks.com>
+Date: Fri, 15 Apr 2022 18:10:14 -0400
+Subject: [PATCH] Fix failure & crash of sgdisk when compiled with latest
+ popt (commit 740; presumably eventually release 1.19)
+
+[Retrieved from:
+https://sourceforge.net/p/gptfdisk/code/ci/5d5e76d369a412bfb3d2cebb5fc0a7509cef878d/]
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ NEWS      | 8 ++++++++
+ gptcl.cc  | 2 +-
+ support.h | 2 +-
+ 3 files changed, 10 insertions(+), 2 deletions(-)
+
+diff --git a/NEWS b/NEWS
+index c7add56..9e153fd 100644
+--- a/NEWS
++++ b/NEWS
+@@ -1,3 +1,11 @@
++1.0.10 (?/??/2022):
++-------------------
++
++- Fixed problem that caused sgdisk to crash with errors about being unable
++  to read the disk's partition table when compiled with the latest popt
++  (commit 740, which is pre-release as I type; presumably version 1.19 and
++  later once released).
++
+ 1.0.9 (4/14/2022):
+ ------------------
+ 
+diff --git a/gptcl.cc b/gptcl.cc
+index 34c9421..0d578eb 100644
+--- a/gptcl.cc
++++ b/gptcl.cc
+@@ -155,7 +155,7 @@ int GPTDataCL::DoOptions(int argc, char* argv[]) {
+    } // while
+ 
+    // Assume first non-option argument is the device filename....
+-   device = (char*) poptGetArg(poptCon);
++   device = strdup((char*) poptGetArg(poptCon));
+    poptResetContext(poptCon);
+ 
+    if (device != NULL) {
+diff --git a/support.h b/support.h
+index 8ba9ad1..f91f1bc 100644
+--- a/support.h
++++ b/support.h
+@@ -8,7 +8,7 @@
+ #include <stdlib.h>
+ #include <string>
+ 
+-#define GPTFDISK_VERSION "1.0.9"
++#define GPTFDISK_VERSION "1.0.9.1"
+ 
+ #if defined (__FreeBSD__) || defined (__FreeBSD_kernel__) || defined (__APPLE__)
+ // Darwin (Mac OS) & FreeBSD: disk IOCTLs are different, and there is no lseek64
+-- 
+2.35.1
+
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gptfdisk: fix runtime failure with popt 1.19

[Florian Fainelli]

On 11/16/22 09:11, Fabrice Fontaine wrote:
> Fix the following runtime failure raised since bump of popt to version
> 1.19 in commit 895bfba93f6e5535f2132aeea144d2cd87ebc71b:
> 
> Problem opening  for reading! Error is 2.
> The specified file does not exist!
> 
> Fixes:
>   - No autobuilder failure
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reported-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 895bfba93f6e ("package/popt: bump to version 1.19")

Thanks a lot Fabrice!
-- 
Florian

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gptfdisk: fix runtime failure with popt 1.19

[Yann E. MORIN]

Fabrice, All,

On 2022-11-16 18:11 +0100, Fabrice Fontaine spake thusly:
> Fix the following runtime failure raised since bump of popt to version
> 1.19 in commit 895bfba93f6e5535f2132aeea144d2cd87ebc71b:
> 
> Problem opening  for reading! Error is 2.
> The specified file does not exist!
> 
> Fixes:
>  - No autobuilder failure
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...h-of-sgdisk-when-compiled-with-lates.patch | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch
> 
> diff --git a/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch b/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch
> new file mode 100644
> index 0000000000..bdeedd95cc
> --- /dev/null
> +++ b/package/gptfdisk/0002-Fix-failure-crash-of-sgdisk-when-compiled-with-lates.patch
> @@ -0,0 +1,60 @@
> +From 5d5e76d369a412bfb3d2cebb5fc0a7509cef878d Mon Sep 17 00:00:00 2001
> +From: Rod Smith <rodsmith@rodsbooks.com>
> +Date: Fri, 15 Apr 2022 18:10:14 -0400
> +Subject: [PATCH] Fix failure & crash of sgdisk when compiled with latest
> + popt (commit 740; presumably eventually release 1.19)
> +
> +[Retrieved from:
> +https://sourceforge.net/p/gptfdisk/code/ci/5d5e76d369a412bfb3d2cebb5fc0a7509cef878d/]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + NEWS      | 8 ++++++++
> + gptcl.cc  | 2 +-
> + support.h | 2 +-
> + 3 files changed, 10 insertions(+), 2 deletions(-)
> +
> +diff --git a/NEWS b/NEWS
> +index c7add56..9e153fd 100644
> +--- a/NEWS
> ++++ b/NEWS
> +@@ -1,3 +1,11 @@
> ++1.0.10 (?/??/2022):
> ++-------------------
> ++
> ++- Fixed problem that caused sgdisk to crash with errors about being unable
> ++  to read the disk's partition table when compiled with the latest popt
> ++  (commit 740, which is pre-release as I type; presumably version 1.19 and
> ++  later once released).
> ++
> + 1.0.9 (4/14/2022):
> + ------------------
> + 
> +diff --git a/gptcl.cc b/gptcl.cc
> +index 34c9421..0d578eb 100644
> +--- a/gptcl.cc
> ++++ b/gptcl.cc
> +@@ -155,7 +155,7 @@ int GPTDataCL::DoOptions(int argc, char* argv[]) {
> +    } // while
> + 
> +    // Assume first non-option argument is the device filename....
> +-   device = (char*) poptGetArg(poptCon);
> ++   device = strdup((char*) poptGetArg(poptCon));
> +    poptResetContext(poptCon);
> + 
> +    if (device != NULL) {
> +diff --git a/support.h b/support.h
> +index 8ba9ad1..f91f1bc 100644
> +--- a/support.h
> ++++ b/support.h
> +@@ -8,7 +8,7 @@
> + #include <stdlib.h>
> + #include <string>
> + 
> +-#define GPTFDISK_VERSION "1.0.9"
> ++#define GPTFDISK_VERSION "1.0.9.1"
> + 
> + #if defined (__FreeBSD__) || defined (__FreeBSD_kernel__) || defined (__APPLE__)
> + // Darwin (Mac OS) & FreeBSD: disk IOCTLs are different, and there is no lseek64
> +-- 
> +2.35.1
> +
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot