From: Jonathan Cameron <jic23@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: Olivier Moysan <olivier.moysan@foss.st.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-iio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] iio: adc: stm32: add smart calibration
Date: Wed, 23 Nov 2022 20:56:50 +0000 [thread overview]
Message-ID: <20221123205650.3be4ee4e@jic23-huawei> (raw)
In-Reply-To: <f7a2a680-4879-b6cf-3546-e890b3c96e32@foss.st.com>
On Wed, 23 Nov 2022 12:04:36 +0100
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 11/15/22 11:31, Olivier Moysan wrote:
> > Refine offset and linear calibration strategy for STM32MP15 and
> > STM32MP13 SoCs:
> >
> > - offset calibration
> > This calibration depends on factors such as temperature and voltage.
> > As it is not time consuming, it's worth doing it on each ADC
> > start, to get the best accuracy. There is no need to save these data.
> >
> > - linear calibration
> > This calibration is basically SoC dependent, so it can be done only once.
> > When this calibration has been performed at boot stage, the ADC kernel
> > driver can retrieve the calibration data from the ADC registers.
> > Otherwise, the linear calibration is performed once by the ADC driver.
> > The backup of these data, allows to restore them on successive ADC starts.
> >
> > Olivier Moysan (3):
> > iio: adc: stm32-adc: smart calibration support
> > iio: adc: stm32-adc: improve calibration error log
> > iio: adc: stm32-adc: add debugfs to read raw calibration result
>
> Hi Olivier,
>
> For the series, you can add my:
> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Applied to the togreg branch of iio.git and pushed out as testing to let
0-day have a first look at it.
Thanks,
Jonathan
>
> Thanks,
> Fabrice
>
> >
> > drivers/iio/adc/stm32-adc-core.h | 1 +
> > drivers/iio/adc/stm32-adc.c | 135 ++++++++++++++++++-------------
> > 2 files changed, 78 insertions(+), 58 deletions(-)
> >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: Olivier Moysan <olivier.moysan@foss.st.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-iio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] iio: adc: stm32: add smart calibration
Date: Wed, 23 Nov 2022 20:56:50 +0000 [thread overview]
Message-ID: <20221123205650.3be4ee4e@jic23-huawei> (raw)
In-Reply-To: <f7a2a680-4879-b6cf-3546-e890b3c96e32@foss.st.com>
On Wed, 23 Nov 2022 12:04:36 +0100
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 11/15/22 11:31, Olivier Moysan wrote:
> > Refine offset and linear calibration strategy for STM32MP15 and
> > STM32MP13 SoCs:
> >
> > - offset calibration
> > This calibration depends on factors such as temperature and voltage.
> > As it is not time consuming, it's worth doing it on each ADC
> > start, to get the best accuracy. There is no need to save these data.
> >
> > - linear calibration
> > This calibration is basically SoC dependent, so it can be done only once.
> > When this calibration has been performed at boot stage, the ADC kernel
> > driver can retrieve the calibration data from the ADC registers.
> > Otherwise, the linear calibration is performed once by the ADC driver.
> > The backup of these data, allows to restore them on successive ADC starts.
> >
> > Olivier Moysan (3):
> > iio: adc: stm32-adc: smart calibration support
> > iio: adc: stm32-adc: improve calibration error log
> > iio: adc: stm32-adc: add debugfs to read raw calibration result
>
> Hi Olivier,
>
> For the series, you can add my:
> Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Applied to the togreg branch of iio.git and pushed out as testing to let
0-day have a first look at it.
Thanks,
Jonathan
>
> Thanks,
> Fabrice
>
> >
> > drivers/iio/adc/stm32-adc-core.h | 1 +
> > drivers/iio/adc/stm32-adc.c | 135 ++++++++++++++++++-------------
> > 2 files changed, 78 insertions(+), 58 deletions(-)
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-23 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:31 [PATCH 0/3] iio: adc: stm32: add smart calibration Olivier Moysan
2022-11-15 10:31 ` Olivier Moysan
2022-11-15 10:31 ` [PATCH 1/3] iio: adc: stm32-adc: smart calibration support Olivier Moysan
2022-11-15 10:31 ` Olivier Moysan
2022-11-15 10:31 ` [PATCH 2/3] iio: adc: stm32-adc: improve calibration error log Olivier Moysan
2022-11-15 10:31 ` Olivier Moysan
2022-11-15 10:31 ` [PATCH 3/3] iio: adc: stm32-adc: add debugfs to read raw calibration result Olivier Moysan
2022-11-15 10:31 ` Olivier Moysan
2022-11-23 11:04 ` [PATCH 0/3] iio: adc: stm32: add smart calibration Fabrice Gasnier
2022-11-23 11:04 ` Fabrice Gasnier
2022-11-23 20:56 ` Jonathan Cameron [this message]
2022-11-23 20:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123205650.3be4ee4e@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.