From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Karl Palsson <karlp@tweak.net.au>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO reference
Date: Fri, 25 Nov 2022 21:42:38 +0000 [thread overview]
Message-ID: <20221125214238.66cd51f4@slackpad.lan> (raw)
In-Reply-To: <20221125195401.61642-2-samuel@sholland.org>
On Fri, 25 Nov 2022 13:54:01 -0600
Samuel Holland <samuel@sholland.org> wrote:
> The property named in the schema is 'enable-gpios', not 'enable-gpio'.
> This makes no difference at runtime, because the regulator is marked as
> always-on, but it breaks validation.
>
> Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> index 43641cb82398..343b02b97155 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> @@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator {
> regulator-ramp-delay = <50>; /* 4ms */
>
> enable-active-high;
> - enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
> + enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
> gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> gpios-states = <0x1>;
> states = <1100000 0>, <1300000 1>;
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Karl Palsson <karlp@tweak.net.au>,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO reference
Date: Fri, 25 Nov 2022 21:42:38 +0000 [thread overview]
Message-ID: <20221125214238.66cd51f4@slackpad.lan> (raw)
In-Reply-To: <20221125195401.61642-2-samuel@sholland.org>
On Fri, 25 Nov 2022 13:54:01 -0600
Samuel Holland <samuel@sholland.org> wrote:
> The property named in the schema is 'enable-gpios', not 'enable-gpio'.
> This makes no difference at runtime, because the regulator is marked as
> always-on, but it breaks validation.
>
> Fixes: 4701fc6e5dd9 ("ARM: dts: sun8i: add FriendlyARM NanoPi Duo2")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> index 43641cb82398..343b02b97155 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-duo2.dts
> @@ -57,7 +57,7 @@ reg_vdd_cpux: vdd-cpux-regulator {
> regulator-ramp-delay = <50>; /* 4ms */
>
> enable-active-high;
> - enable-gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
> + enable-gpios = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
> gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> gpios-states = <0x1>;
> states = <1100000 0>, <1300000 1>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-25 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 19:54 [PATCH 1/2] ARM: dts: sunxi: Fix GPIO LED node names Samuel Holland
2022-11-25 19:54 ` Samuel Holland
2022-11-25 19:54 ` [PATCH 2/2] ARM: dts: sun8i: nanopi-duo2: Fix regulator GPIO reference Samuel Holland
2022-11-25 19:54 ` Samuel Holland
2022-11-25 21:42 ` Andre Przywara [this message]
2022-11-25 21:42 ` Andre Przywara
2022-12-05 21:03 ` Jernej Škrabec
2022-12-05 21:03 ` Jernej Škrabec
2022-11-25 21:40 ` [PATCH 1/2] ARM: dts: sunxi: Fix GPIO LED node names Andre Przywara
2022-11-25 21:40 ` Andre Przywara
2022-11-25 21:50 ` Samuel Holland
2022-11-25 21:50 ` Samuel Holland
2022-12-05 21:07 ` Jernej Škrabec
2022-12-05 21:07 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125214238.66cd51f4@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=karlp@tweak.net.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.