All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: netdev@vger.kernel.org
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	Jiri Pirko <jiri@nvidia.com>, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v3 1/9] devlink: use min_t to calculate data_size
Date: Mon, 28 Nov 2022 12:36:39 -0800	[thread overview]
Message-ID: <20221128203647.1198669-2-jacob.e.keller@intel.com> (raw)
In-Reply-To: <20221128203647.1198669-1-jacob.e.keller@intel.com>

The calculation for the data_size in the devlink_nl_read_snapshot_fill
function uses an if statement that is better expressed using the min_t
macro.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
No changes since v2.

 net/core/devlink.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index cea154ddce7a..ff802788ee05 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -6485,10 +6485,8 @@ static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
 		u32 data_size;
 		u8 *data;
 
-		if (end_offset - curr_offset < DEVLINK_REGION_READ_CHUNK_SIZE)
-			data_size = end_offset - curr_offset;
-		else
-			data_size = DEVLINK_REGION_READ_CHUNK_SIZE;
+		data_size = min_t(u32, end_offset - curr_offset,
+				  DEVLINK_REGION_READ_CHUNK_SIZE);
 
 		data = &snapshot->data[curr_offset];
 		err = devlink_nl_cmd_region_read_chunk_fill(skb, devlink,
-- 
2.38.1.420.g319605f8f00e


  reply	other threads:[~2022-11-28 20:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 20:36 [PATCH net-next v3 0/9] support direct read from region Jacob Keller
2022-11-28 20:36 ` Jacob Keller [this message]
2022-11-28 20:36 ` [PATCH net-next v3 2/9] devlink: report extended error message in region_read_dumpit() Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 3/9] devlink: find snapshot in devlink_nl_cmd_region_read_dumpit Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 4/9] devlink: remove unnecessary parameter from chunk_fill function Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 5/9] devlink: refactor region_read_snapshot_fill to use a callback function Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 6/9] devlink: support directly reading from region memory Jacob Keller
2022-11-29  8:17   ` Jiri Pirko
2022-11-28 20:36 ` [PATCH net-next v3 7/9] ice: use same function to snapshot both NVM and Shadow RAM Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 8/9] ice: document 'shadow-ram' devlink region Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 9/9] ice: implement direct read for NVM and Shadow RAM regions Jacob Keller
2022-12-01  5:50 ` [PATCH net-next v3 0/9] support direct read from region patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221128203647.1198669-2-jacob.e.keller@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.