From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v3 6/9] devlink: support directly reading from region memory
Date: Tue, 29 Nov 2022 09:17:17 +0100 [thread overview]
Message-ID: <Y4XADTlOkROnuaWL@nanopsycho> (raw)
In-Reply-To: <20221128203647.1198669-7-jacob.e.keller@intel.com>
Mon, Nov 28, 2022 at 09:36:44PM CET, jacob.e.keller@intel.com wrote:
>To read from a region, user space must currently request a new snapshot of
>the region and then read from that snapshot. This can sometimes be overkill
>if user space only reads a tiny portion. They first create the snapshot,
>then request a read, then destroy the snapshot.
>
>For regions which have a single underlying "contents", it makes sense to
>allow supporting direct reading of the region data.
>
>Extend the DEVLINK_CMD_REGION_READ to allow direct reading from a region if
>requested via the new DEVLINK_ATTR_REGION_DIRECT. If this attribute is set,
>then perform a direct read instead of using a snapshot. Direct read is
>mutually exclusive with DEVLINK_ATTR_REGION_SNAPSHOT_ID, and care is taken
>to ensure that we reject commands which provide incorrect attributes.
>
>Regions must enable support for direct read by implementing the .read()
>callback function. If a region does not support such direct reads, a
>suitable extended error message is reported.
>
>Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2022-11-29 8:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:36 [PATCH net-next v3 0/9] support direct read from region Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 1/9] devlink: use min_t to calculate data_size Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 2/9] devlink: report extended error message in region_read_dumpit() Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 3/9] devlink: find snapshot in devlink_nl_cmd_region_read_dumpit Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 4/9] devlink: remove unnecessary parameter from chunk_fill function Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 5/9] devlink: refactor region_read_snapshot_fill to use a callback function Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 6/9] devlink: support directly reading from region memory Jacob Keller
2022-11-29 8:17 ` Jiri Pirko [this message]
2022-11-28 20:36 ` [PATCH net-next v3 7/9] ice: use same function to snapshot both NVM and Shadow RAM Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 8/9] ice: document 'shadow-ram' devlink region Jacob Keller
2022-11-28 20:36 ` [PATCH net-next v3 9/9] ice: implement direct read for NVM and Shadow RAM regions Jacob Keller
2022-12-01 5:50 ` [PATCH net-next v3 0/9] support direct read from region patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4XADTlOkROnuaWL@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.