From: Guillaume Nault <gnault@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Benjamin Coddington" <bcodding@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Josef Bacik" <josef@toxicpanda.com>,
"Keith Busch" <kbusch@kernel.org>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Lee Duncan" <lduncan@suse.com>,
"Chris Leech" <cleech@redhat.com>,
"Mike Christie" <michael.christie@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Valentina Manea" <valentina.manea.m@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Howells" <dhowells@redhat.com>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Steve French" <sfrench@samba.org>,
"Christine Caulfield" <ccaulfie@redhat.com>,
"David Teigland" <teigland@redhat.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Xiubo Li" <xiubli@redhat.com>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
nbd@other.debian.org, linux-nvme@lists.infradead.org,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com,
v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Wed, 30 Nov 2022 12:48:35 +0100 [thread overview]
Message-ID: <20221130114835.GA29316@pc-4.home> (raw)
In-Reply-To: <20221129140242.GA15747@lst.de>
On Tue, Nov 29, 2022 at 03:02:42PM +0100, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
That's something I originally considered. But, as far as I can see, nbd
needs this flag _and_ uses sockets created in user space. So it'd still
need to opt out manually.
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Nault <gnault@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Wed, 30 Nov 2022 12:48:35 +0100 [thread overview]
Message-ID: <20221130114835.GA29316@pc-4.home> (raw)
In-Reply-To: <20221129140242.GA15747@lst.de>
On Tue, Nov 29, 2022 at 03:02:42PM +0100, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
That's something I originally considered. But, as far as I can see, nbd
needs this flag _and_ uses sockets created in user space. So it'd still
need to opt out manually.
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Nault via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Latchesar Ionkov" <lucho@ionkov.net>,
samba-technical@lists.samba.org,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Valentina Manea" <valentina.manea.m@gmail.com>,
linux-nvme@lists.infradead.org,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"David Howells" <dhowells@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
linux-nfs@vger.kernel.org,
"Marc Dionne" <marc.dionne@auristor.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-afs@lists.infradead.org,
"Mike Christie" <michael.christie@oracle.com>,
drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org,
"Sagi Grimberg" <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, cluster-devel@redhat.com,
"Christine Caulfield" <ccaulfie@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Anna Schumaker" <anna@kernel.org>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Josef Bacik" <josef@toxicpanda.com>,
nbd@other.debian.org, linux-block@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
"Keith Busch" <kbusch@kernel.org>,
ceph-devel@vger.kernel.org, "Xiubo Li" <xiubli@redhat.com>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Jens Axboe" <axboe@kernel.dk>, "Chris Leech" <cleech@redhat.com>,
open-iscsi@googlegroups.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, "Jeff Layton" <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, "Steve French" <sfrench@samba.org>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Benjamin Coddington" <bcodding@redhat.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Lee Duncan" <lduncan@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Wed, 30 Nov 2022 12:48:35 +0100 [thread overview]
Message-ID: <20221130114835.GA29316@pc-4.home> (raw)
In-Reply-To: <20221129140242.GA15747@lst.de>
On Tue, Nov 29, 2022 at 03:02:42PM +0100, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
That's something I originally considered. But, as far as I can see, nbd
needs this flag _and_ uses sockets created in user space. So it'd still
need to opt out manually.
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Nault <gnault@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
linux-nvme@lists.infradead.org,
Philipp Reisner <philipp.reisner@linbit.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
linux-nfs@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>,
Shuah Khan <shuah@kernel.org>,
linux-afs@lists.infradead.org,
Mike Christie <michael.christie@oracle.com>,
drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com,
Christine Caulfield <ccaulfie@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Anna Schumaker <anna@kernel.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Josef Bacik <josef@toxicpanda.com>,
nbd@other.debian.org, linux-block@vger.kernel.org,
David Teigland <teigland@redhat.com>,
Joel Becker <jlbec@evilplan.org>,
v9fs-developer@lists.sourceforge.net,
Keith Busch <kbusch@kernel.org>,
ceph-devel@vger.kernel.org, Xiubo Li <xiubli@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Jens Axboe <axboe@kernel.dk>, Chris Leech <cleech@redhat.com>,
open-iscsi@googlegroups.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>,
Benjamin Coddington <bcodding@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Lee Duncan <lduncan@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Drbd-dev] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Wed, 30 Nov 2022 12:48:35 +0100 [thread overview]
Message-ID: <20221130114835.GA29316@pc-4.home> (raw)
In-Reply-To: <20221129140242.GA15747@lst.de>
On Tue, Nov 29, 2022 at 03:02:42PM +0100, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
That's something I originally considered. But, as far as I can see, nbd
needs this flag _and_ uses sockets created in user space. So it'd still
need to opt out manually.
next prev parent reply other threads:[~2022-11-30 11:49 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:35 [PATCH v1 0/3] Stop corrupting socket's task_frag Benjamin Coddington
2022-11-21 13:35 ` [PATCH v1 1/3] net: Introduce sk_use_task_frag in struct sock Benjamin Coddington
2022-12-09 12:09 ` Paolo Abeni
2022-12-09 14:16 ` Eric Dumazet
2022-11-21 13:35 ` [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2022-11-21 13:35 ` [Drbd-dev] " Benjamin Coddington
2022-11-21 13:35 ` [Ocfs2-devel] " Benjamin Coddington via Ocfs2-devel
2022-11-21 13:35 ` [Cluster-devel] " Benjamin Coddington
2022-11-21 13:56 ` David Howells
2022-11-21 13:56 ` [Drbd-dev] " David Howells
2022-11-21 13:56 ` [Ocfs2-devel] " David Howells via Ocfs2-devel
2022-11-21 13:56 ` [Cluster-devel] " David Howells
2022-11-21 14:34 ` Benjamin Coddington
2022-11-21 14:34 ` [Drbd-dev] " Benjamin Coddington
2022-11-21 14:34 ` [Ocfs2-devel] " Benjamin Coddington via Ocfs2-devel
2022-11-21 14:34 ` [Cluster-devel] " Benjamin Coddington
2022-11-21 21:40 ` Shuah Khan
2022-11-21 21:40 ` [Drbd-dev] " Shuah Khan
2022-11-21 21:40 ` [Ocfs2-devel] " Shuah Khan via Ocfs2-devel
2022-11-21 21:40 ` [Cluster-devel] " Shuah Khan
2022-11-21 21:43 ` Shuah Khan
2022-11-21 21:43 ` [Drbd-dev] " Shuah Khan
2022-11-21 21:43 ` [Ocfs2-devel] " Shuah Khan via Ocfs2-devel
2022-11-21 21:43 ` [Cluster-devel] " Shuah Khan
2022-11-21 22:01 ` Benjamin Coddington
2022-11-21 22:01 ` [Drbd-dev] " Benjamin Coddington
2022-11-21 22:01 ` [Ocfs2-devel] " Benjamin Coddington via Ocfs2-devel
2022-11-21 22:01 ` [Cluster-devel] " Benjamin Coddington
2022-11-21 22:32 ` Shuah Khan
2022-11-21 22:32 ` [Drbd-dev] " Shuah Khan
2022-11-21 22:32 ` [Ocfs2-devel] " Shuah Khan via Ocfs2-devel
2022-11-21 22:32 ` [Cluster-devel] " Shuah Khan
2022-11-22 14:23 ` Benjamin Coddington
2022-11-22 14:23 ` [Drbd-dev] " Benjamin Coddington
2022-11-22 14:23 ` [Ocfs2-devel] " Benjamin Coddington via Ocfs2-devel
2022-11-22 14:23 ` [Cluster-devel] " Benjamin Coddington
2022-11-29 14:02 ` Christoph Hellwig
2022-11-29 14:02 ` [Drbd-dev] " Christoph Hellwig
2022-11-29 14:02 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-11-29 14:02 ` [Cluster-devel] " Christoph Hellwig
2022-11-29 16:47 ` Benjamin Coddington
2022-11-29 16:47 ` [Drbd-dev] " Benjamin Coddington
2022-11-29 16:47 ` [Ocfs2-devel] " Benjamin Coddington via Ocfs2-devel
2022-11-29 16:47 ` [Cluster-devel] " Benjamin Coddington
2022-11-30 12:07 ` Guillaume Nault
2022-11-30 12:07 ` [Drbd-dev] " Guillaume Nault
2022-11-30 12:07 ` [Ocfs2-devel] " Guillaume Nault via Ocfs2-devel
2022-11-30 12:07 ` [Cluster-devel] " Guillaume Nault
2022-11-29 17:42 ` Jeff Layton
2022-11-29 17:42 ` [Drbd-dev] " Jeff Layton
2022-11-29 17:42 ` [Ocfs2-devel] " Jeff Layton via Ocfs2-devel
2022-11-29 17:42 ` [Cluster-devel] " Jeff Layton
2022-11-30 11:48 ` Guillaume Nault [this message]
2022-11-30 11:48 ` [Drbd-dev] " Guillaume Nault
2022-11-30 11:48 ` [Ocfs2-devel] " Guillaume Nault via Ocfs2-devel
2022-11-30 11:48 ` [Cluster-devel] " Guillaume Nault
2022-12-09 12:37 ` Paolo Abeni
2022-12-09 12:37 ` [Drbd-dev] " Paolo Abeni
2022-12-09 12:37 ` [Ocfs2-devel] " Paolo Abeni via Ocfs2-devel
2022-12-09 12:37 ` [Cluster-devel] " Paolo Abeni
2022-12-09 16:11 ` Jakub Kicinski
2022-12-09 16:11 ` [Drbd-dev] " Jakub Kicinski
2022-12-09 16:11 ` [Ocfs2-devel] " Jakub Kicinski via Ocfs2-devel
2022-12-09 16:11 ` [Cluster-devel] " Jakub Kicinski
2022-12-09 16:50 ` Paolo Abeni
2022-12-09 16:50 ` [Drbd-dev] " Paolo Abeni
2022-12-09 16:50 ` [Ocfs2-devel] " Paolo Abeni via Ocfs2-devel
2022-12-09 16:50 ` [Cluster-devel] " Paolo Abeni
2022-11-21 13:35 ` [PATCH v1 3/3] net: simplify sk_page_frag Benjamin Coddington
2022-12-09 16:42 ` Paolo Abeni
2022-12-09 16:44 ` Paolo Abeni
2022-12-09 16:44 ` Paolo Abeni
2022-12-07 11:44 ` [PATCH v1 0/3] Stop corrupting socket's task_frag Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130114835.GA29316@pc-4.home \
--to=gnault@redhat.com \
--cc=anna@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=bcodding@redhat.com \
--cc=ccaulfie@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=chuck.lever@oracle.com \
--cc=cleech@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=lduncan@suse.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=nbd@other.debian.org \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=open-iscsi@googlegroups.com \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=shuah@kernel.org \
--cc=teigland@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=valentina.manea.m@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.