* [folded-merged] mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch removed from -mm tree
@ 2022-11-30 22:47 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-11-30 22:47 UTC (permalink / raw)
To: mm-commits, zokeefe, mhocko, shy828301, akpm
The quilt patch titled
Subject: mm: replace VM_WARN_ON to pr_warn if the node is offline with __GFP_THISNODE
has been removed from the -mm tree. Its filename was
mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch
This patch was dropped because it was folded into mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode.patch
------------------------------------------------------
From: Yang Shi <shy828301@gmail.com>
Subject: mm: replace VM_WARN_ON to pr_warn if the node is offline with __GFP_THISNODE
Date: Wed, 23 Nov 2022 11:30:14 -0800
renamed nid to this_node and gfp to warn_gfp to make the code more
readable per Michal.
Link: https://lkml.kernel.org/r/20221123193014.153983-1-shy828301@gmail.com
Reported-by: syzbot+0044b22d177870ee974f@syzkaller.appspotmail.com
Signed-off-by: Yang Shi <shy828301@gmail.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Zach O'Keefe <zokeefe@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/gfp.h | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
--- a/include/linux/gfp.h~mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4
+++ a/include/linux/gfp.h
@@ -210,14 +210,18 @@ alloc_pages_bulk_array_node(gfp_t gfp, i
return __alloc_pages_bulk(gfp, nid, NULL, nr_pages, NULL, page_array);
}
-static inline void warn_if_node_offline(int nid, gfp_t gfp_mask)
+static inline void warn_if_node_offline(int this_node, gfp_t gfp_mask)
{
- gfp_t gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
+ gfp_t warn_gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
- if ((gfp == (__GFP_THISNODE|__GFP_NOWARN)) && !node_online(nid)) {
- pr_warn("%pGg allocation from offline node %d\n", &gfp, nid);
- dump_stack();
- }
+ if (warn_gfp != (__GFP_THISNODE|__GFP_NOWARN))
+ return;
+
+ if(node_online(this_node))
+ return;
+
+ pr_warn("%pGg allocation from offline node %d\n", &warn_gfp, this_node);
+ dump_stack();
}
/*
_
Patches currently in -mm which might be from shy828301@gmail.com are
mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-30 22:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-30 22:47 [folded-merged] mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.