All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: reatmon@ti.com
Cc: Praneeth Bajjuri <praneeth@ti.com>,
	Denys Dmytriyenko <denys@konsulko.com>,
	meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][master][PATCH] u-boot: Add lzop dependency
Date: Fri, 2 Dec 2022 11:10:51 -0500	[thread overview]
Message-ID: <20221202161051.GU22689@denix.org> (raw)
In-Reply-To: <20221202145817.28581-1-reatmon@ti.com>

On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> It turns out we do need lzop for building dra7 and am57 in u-boot,
> so add the dependency back in and add a layer dependency on
> meta-oe(openembedded-layer).

Oh, no, please don't do that! This is a heavy dependency and meta-ti BSP has 
stayed away from it since the beginning of times.

It would be better to figure out why lzop is used for those platforms and 
change that, as LZOP is pretty much deprecated these days...


> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  meta-ti-bsp/conf/layer.conf                  | 1 +
>  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf
> index 39e7f9eb..8bafa854 100644
> --- a/meta-ti-bsp/conf/layer.conf
> +++ b/meta-ti-bsp/conf/layer.conf
> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses"
>  
>  LAYERDEPENDS_meta-ti-bsp = " \
>      core \
> +    openembedded-layer \
>      meta-arm \
>  "
>  
> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> index d87dcbe1..5127e137 100644
> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
>  PV:append = "+git${SRCPV}"
>  
>  # u-boot needs devtree compiler to parse dts files
> -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native"
> +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
>  
>  DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
>  
> -- 
> 2.17.1


  reply	other threads:[~2022-12-02 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 14:58 [meta-ti][master][PATCH] u-boot: Add lzop dependency Ryan Eatmon
2022-12-02 16:10 ` Denys Dmytriyenko [this message]
2022-12-02 16:42   ` Ryan Eatmon
     [not found]   ` <172D078D53F719C6.27320@lists.yoctoproject.org>
2022-12-02 20:10     ` Ryan Eatmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221202161051.GU22689@denix.org \
    --to=denis@denix.org \
    --cc=denys@konsulko.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=praneeth@ti.com \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.