All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][master][PATCH] u-boot: Add lzop dependency
@ 2022-12-02 14:58 Ryan Eatmon
  2022-12-02 16:10 ` Denys Dmytriyenko
  0 siblings, 1 reply; 4+ messages in thread
From: Ryan Eatmon @ 2022-12-02 14:58 UTC (permalink / raw)
  To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

It turns out we do need lzop for building dra7 and am57 in u-boot,
so add the dependency back in and add a layer dependency on
meta-oe(openembedded-layer).

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 meta-ti-bsp/conf/layer.conf                  | 1 +
 meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf
index 39e7f9eb..8bafa854 100644
--- a/meta-ti-bsp/conf/layer.conf
+++ b/meta-ti-bsp/conf/layer.conf
@@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses"
 
 LAYERDEPENDS_meta-ti-bsp = " \
     core \
+    openembedded-layer \
     meta-arm \
 "
 
diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
index d87dcbe1..5127e137 100644
--- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
+++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
@@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
 PV:append = "+git${SRCPV}"
 
 # u-boot needs devtree compiler to parse dts files
-DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native"
+DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
 
 DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
 
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-ti][master][PATCH] u-boot: Add lzop dependency
  2022-12-02 14:58 [meta-ti][master][PATCH] u-boot: Add lzop dependency Ryan Eatmon
@ 2022-12-02 16:10 ` Denys Dmytriyenko
  2022-12-02 16:42   ` Ryan Eatmon
       [not found]   ` <172D078D53F719C6.27320@lists.yoctoproject.org>
  0 siblings, 2 replies; 4+ messages in thread
From: Denys Dmytriyenko @ 2022-12-02 16:10 UTC (permalink / raw)
  To: reatmon; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> It turns out we do need lzop for building dra7 and am57 in u-boot,
> so add the dependency back in and add a layer dependency on
> meta-oe(openembedded-layer).

Oh, no, please don't do that! This is a heavy dependency and meta-ti BSP has 
stayed away from it since the beginning of times.

It would be better to figure out why lzop is used for those platforms and 
change that, as LZOP is pretty much deprecated these days...


> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  meta-ti-bsp/conf/layer.conf                  | 1 +
>  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf
> index 39e7f9eb..8bafa854 100644
> --- a/meta-ti-bsp/conf/layer.conf
> +++ b/meta-ti-bsp/conf/layer.conf
> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses"
>  
>  LAYERDEPENDS_meta-ti-bsp = " \
>      core \
> +    openembedded-layer \
>      meta-arm \
>  "
>  
> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> index d87dcbe1..5127e137 100644
> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
>  PV:append = "+git${SRCPV}"
>  
>  # u-boot needs devtree compiler to parse dts files
> -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native"
> +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
>  
>  DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
>  
> -- 
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-ti][master][PATCH] u-boot: Add lzop dependency
  2022-12-02 16:10 ` Denys Dmytriyenko
@ 2022-12-02 16:42   ` Ryan Eatmon
       [not found]   ` <172D078D53F719C6.27320@lists.yoctoproject.org>
  1 sibling, 0 replies; 4+ messages in thread
From: Ryan Eatmon @ 2022-12-02 16:42 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti



On 12/2/2022 10:10, Denys Dmytriyenko wrote:
> On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>> It turns out we do need lzop for building dra7 and am57 in u-boot,
>> so add the dependency back in and add a layer dependency on
>> meta-oe(openembedded-layer).
> 
> Oh, no, please don't do that! This is a heavy dependency and meta-ti BSP has
> stayed away from it since the beginning of times.
> 
> It would be better to figure out why lzop is used for those platforms and
> change that, as LZOP is pretty much deprecated these days...

Ok.  I'll back this one out.  And look for an alternative solution.

> 
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>>   meta-ti-bsp/conf/layer.conf                  | 1 +
>>   meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf
>> index 39e7f9eb..8bafa854 100644
>> --- a/meta-ti-bsp/conf/layer.conf
>> +++ b/meta-ti-bsp/conf/layer.conf
>> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses"
>>   
>>   LAYERDEPENDS_meta-ti-bsp = " \
>>       core \
>> +    openembedded-layer \
>>       meta-arm \
>>   "
>>   
>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>> index d87dcbe1..5127e137 100644
>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>> @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
>>   PV:append = "+git${SRCPV}"
>>   
>>   # u-boot needs devtree compiler to parse dts files
>> -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native"
>> +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native"
>>   
>>   DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
>>   
>> -- 
>> 2.17.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-ti][master][PATCH] u-boot: Add lzop dependency
       [not found]   ` <172D078D53F719C6.27320@lists.yoctoproject.org>
@ 2022-12-02 20:10     ` Ryan Eatmon
  0 siblings, 0 replies; 4+ messages in thread
From: Ryan Eatmon @ 2022-12-02 20:10 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti



On 12/2/2022 10:42, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 12/2/2022 10:10, Denys Dmytriyenko wrote:
>> On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via 
>> lists.yoctoproject.org wrote:
>>> It turns out we do need lzop for building dra7 and am57 in u-boot,
>>> so add the dependency back in and add a layer dependency on
>>> meta-oe(openembedded-layer).
>>
>> Oh, no, please don't do that! This is a heavy dependency and meta-ti 
>> BSP has
>> stayed away from it since the beginning of times.
>>
>> It would be better to figure out why lzop is used for those platforms and
>> change that, as LZOP is pretty much deprecated these days...
> 
> Ok.  I'll back this one out.  And look for an alternative solution.


Ok.  Adding lzop to HOSTTOOLS in our build script and adding lzop to our 
build environment fixes this issue.


>>
>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>>> ---
>>>   meta-ti-bsp/conf/layer.conf                  | 1 +
>>>   meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
>>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf
>>> index 39e7f9eb..8bafa854 100644
>>> --- a/meta-ti-bsp/conf/layer.conf
>>> +++ b/meta-ti-bsp/conf/layer.conf
>>> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses"
>>>   LAYERDEPENDS_meta-ti-bsp = " \
>>>       core \
>>> +    openembedded-layer \
>>>       meta-arm \
>>>   "
>>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc 
>>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>>> index d87dcbe1..5127e137 100644
>>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
>>> @@ -23,7 +23,7 @@ SRC_URI = 
>>> "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}"
>>>   PV:append = "+git${SRCPV}"
>>>   # u-boot needs devtree compiler to parse dts files
>>> -DEPENDS += "dtc-native bc-native flex-native bison-native 
>>> python3-setuptools-native"
>>> +DEPENDS += "dtc-native bc-native lzop-native flex-native 
>>> bison-native python3-setuptools-native"
>>>   DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
>>> -- 
>>> 2.17.1
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15389): https://lists.yoctoproject.org/g/meta-ti/message/15389
> Mute This Topic: https://lists.yoctoproject.org/mt/95407408/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-02 20:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 14:58 [meta-ti][master][PATCH] u-boot: Add lzop dependency Ryan Eatmon
2022-12-02 16:10 ` Denys Dmytriyenko
2022-12-02 16:42   ` Ryan Eatmon
     [not found]   ` <172D078D53F719C6.27320@lists.yoctoproject.org>
2022-12-02 20:10     ` Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.