* [Buildroot] [PATCH 2/7] package/optee-benchmark: bump to version 3.19.0
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 3/7] package/optee-client: " Etienne Carriere
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
Bumps OP-TEE benchmark package version to OP-TEE release 3.19.0.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-benchmark/optee-benchmark.hash | 4 ++--
package/optee-benchmark/optee-benchmark.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/optee-benchmark/optee-benchmark.hash b/package/optee-benchmark/optee-benchmark.hash
index 27c91e0fb0..d74a24c8ab 100644
--- a/package/optee-benchmark/optee-benchmark.hash
+++ b/package/optee-benchmark/optee-benchmark.hash
@@ -1,4 +1,4 @@
-# From https://github.com/linaro-swg/optee_benchmark/archive/3.18.0/optee-benchmark-3.18.0.tar.gz
-sha256 2151aa5da062402518f35823d9c9dffa2e012f924625d2f7123e0d21d350a86b optee-benchmark-3.18.0.tar.gz
+# From https://github.com/linaro-swg/optee_benchmark/archive/3.19.0/optee-benchmark-3.19.0.tar.gz
+sha256 32f41854bf07eb7bb89dfc702da023c3a99518c33fbe7edf0e1f004e29a8c90c optee-benchmark-3.19.0.tar.gz
# Locally computed
sha256 0571be5b739142dc3e40e0a4e7e30d4ab8bff0d4d606a3f2db2010745587d383 LICENSE
diff --git a/package/optee-benchmark/optee-benchmark.mk b/package/optee-benchmark/optee-benchmark.mk
index 1071c4bb5c..338a51ada4 100644
--- a/package/optee-benchmark/optee-benchmark.mk
+++ b/package/optee-benchmark/optee-benchmark.mk
@@ -4,7 +4,7 @@
#
################################################################################
-OPTEE_BENCHMARK_VERSION = 3.18.0
+OPTEE_BENCHMARK_VERSION = 3.19.0
OPTEE_BENCHMARK_SITE = $(call github,linaro-swg,optee_benchmark,$(OPTEE_BENCHMARK_VERSION))
OPTEE_BENCHMARK_LICENSE = BSD-2-Clause
OPTEE_BENCHMARK_LICENSE_FILES = LICENSE
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 3/7] package/optee-client: bump to version 3.19.0
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 2/7] package/optee-benchmark: " Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 4/7] package/optee-examples: " Etienne Carriere
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
Bumps OP-TEE client package version to OP-TEE release 3.19.0.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-client/optee-client.hash | 4 ++--
package/optee-client/optee-client.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/optee-client/optee-client.hash b/package/optee-client/optee-client.hash
index 8e55bf5725..c067e26f4e 100644
--- a/package/optee-client/optee-client.hash
+++ b/package/optee-client/optee-client.hash
@@ -1,4 +1,4 @@
-# From https://github.com/OP-TEE/optee_client/archive/3.18.0/optee-client-3.18.0.tar.gz
-sha256 ecc0f04fdd5398aa52fea50427fbd624f7f90274aec7bbf2cc8a5bd16758202b optee-client-3.18.0.tar.gz
+# From https://github.com/OP-TEE/optee_client/archive/3.19.0/optee-client-3.19.0.tar.gz
+sha256 5f0d02efa0e496964e86ca9dd2461ada923d1f9e11a4b9cafb5393bd08337644 optee-client-3.19.0.tar.gz
# Locally computed
sha256 fda8385993f112d7ca61b88b54ba5b4cbeec7e43a0f9b317d5186703c1985e8f LICENSE
diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
index 252841ba10..54cc112c5c 100644
--- a/package/optee-client/optee-client.mk
+++ b/package/optee-client/optee-client.mk
@@ -4,7 +4,7 @@
#
################################################################################
-OPTEE_CLIENT_VERSION = 3.18.0
+OPTEE_CLIENT_VERSION = 3.19.0
OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
OPTEE_CLIENT_LICENSE = BSD-2-Clause
OPTEE_CLIENT_LICENSE_FILES = LICENSE
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 4/7] package/optee-examples: bump to version 3.19.0
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 2/7] package/optee-benchmark: " Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 3/7] package/optee-client: " Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 5/7] package/optee-test: " Etienne Carriere
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
Bumps OP-TEE examples package version to OP-TEE release 3.19.0.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-examples/optee-examples.hash | 4 ++--
package/optee-examples/optee-examples.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/optee-examples/optee-examples.hash b/package/optee-examples/optee-examples.hash
index 876584c5e9..937dd44c8c 100644
--- a/package/optee-examples/optee-examples.hash
+++ b/package/optee-examples/optee-examples.hash
@@ -1,4 +1,4 @@
-# From https://github.com/linaro-swg/optee_examples/archive/3.18.0/optee-examples-3.18.0.tar.gz
-sha256 6c64fbc6c5d1282b6311b4076351abbbfab10ac918c6cfc60e45ec705bb5a9ec optee-examples-3.18.0.tar.gz
+# From https://github.com/linaro-swg/optee_examples/archive/3.19.0/optee-examples-3.19.0.tar.gz
+sha256 545f9438885220e890a4f785249a586a957b22dacc31a3cbafa4656f8e9db349 optee-examples-3.19.0.tar.gz
# Locally computed
sha256 6f1ef8449cb82ae79d2155605f7985bdf0f08e7ab5007de9b4362e8bf28733b9 LICENSE
diff --git a/package/optee-examples/optee-examples.mk b/package/optee-examples/optee-examples.mk
index 17adce0fe0..bb2b208583 100644
--- a/package/optee-examples/optee-examples.mk
+++ b/package/optee-examples/optee-examples.mk
@@ -4,7 +4,7 @@
#
################################################################################
-OPTEE_EXAMPLES_VERSION = 3.18.0
+OPTEE_EXAMPLES_VERSION = 3.19.0
OPTEE_EXAMPLES_SITE = $(call github,linaro-swg,optee_examples,$(OPTEE_EXAMPLES_VERSION))
OPTEE_EXAMPLES_LICENSE = BSD-2-Clause
OPTEE_EXAMPLES_LICENSE_FILES = LICENSE
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 5/7] package/optee-test: bump to version 3.19.0
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
` (2 preceding siblings ...)
2022-11-30 7:54 ` [Buildroot] [PATCH 4/7] package/optee-examples: " Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf Etienne Carriere
2022-11-30 7:54 ` [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues Etienne Carriere
5 siblings, 0 replies; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
Bumps OP-TEE test package version to OP-TEE release 3.19.0.
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-test/optee-test.hash | 4 ++--
package/optee-test/optee-test.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/optee-test/optee-test.hash b/package/optee-test/optee-test.hash
index 2af1768155..4da3807bb5 100644
--- a/package/optee-test/optee-test.hash
+++ b/package/optee-test/optee-test.hash
@@ -1,4 +1,4 @@
-# From https://github.com/OP-TEE/optee_test/archive/3.18.0/optee-test-3.18.0.tar.gz
-sha256 cc36a9afb99bd299a3d3769ad634ab7d5cb0e27c84ad04e14c0ff593db0f3faf optee-test-3.18.0.tar.gz
+# From https://github.com/OP-TEE/optee_test/archive/3.19.0/optee-test-3.19.0.tar.gz
+sha256 9435901e9329a25ef4de3904e27d80377b8bb4dd6b215e8fb29d66a7b76afa11 optee-test-3.19.0.tar.gz
# Locally computed
sha256 6e6810981f0ddab9e0d44399d0700a15d9f760a3c2843cc866659c2074139ae7 LICENSE.md
diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk
index d522bb3300..7b065b6123 100644
--- a/package/optee-test/optee-test.mk
+++ b/package/optee-test/optee-test.mk
@@ -4,7 +4,7 @@
#
################################################################################
-OPTEE_TEST_VERSION = 3.18.0
+OPTEE_TEST_VERSION = 3.19.0
OPTEE_TEST_SITE = $(call github,OP-TEE,optee_test,$(OPTEE_TEST_VERSION))
OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause,
OPTEE_TEST_LICENSE_FILES = LICENSE.md
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
` (3 preceding siblings ...)
2022-11-30 7:54 ` [Buildroot] [PATCH 5/7] package/optee-test: " Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-12-04 11:17 ` Yann E. MORIN
2022-11-30 7:54 ` [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues Etienne Carriere
5 siblings, 1 reply; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
In order to use login methods `TEEC_LOGIN_USER` and `TEEC_LOGIN_GROUP`,
a user space application must initialize the tokens with the SHA1
hashed UUID of the user or group.
Select host-pkgconf, util-linux and libuuid in order to use `libuuid`
and add supporting libraries to optee_client for this type of ACL based
login initialization.
This change is based on commit [1] from Eero Aaltonen, merged in OP-TEE
test build environment.
Link: [1] https://github.com/OP-TEE/build/commit/4a27543494278a5d93e2f44d58e413d90739b08a
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-client/Config.in | 3 +++
package/optee-client/optee-client.mk | 1 +
2 files changed, 4 insertions(+)
diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in
index cc7f176c77..ed7da4edbc 100644
--- a/package/optee-client/Config.in
+++ b/package/optee-client/Config.in
@@ -2,6 +2,9 @@ config BR2_PACKAGE_OPTEE_CLIENT
bool "optee-client"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3 # MMC_IOC_MULTI_CMD
+ select BR2_PACKAGE_UTIL_LINUX
+ select BR2_PACKAGE_UTIL_LINUX_LIBS
+ select BR2_PACKAGE_UTIL_LINUX_LIBUUID
help
Enable the OP-TEE client package that brings non-secure
client application resources for OP-TEE support. OP-TEE
diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
index 54cc112c5c..a671b66662 100644
--- a/package/optee-client/optee-client.mk
+++ b/package/optee-client/optee-client.mk
@@ -9,6 +9,7 @@ OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
OPTEE_CLIENT_LICENSE = BSD-2-Clause
OPTEE_CLIENT_LICENSE_FILES = LICENSE
OPTEE_CLIENT_INSTALL_STAGING = YES
+OPTEE_CLIENT_EXT_DEPENDENCIES = host-pkgconf util-linux-libs
OPTEE_CLIENT_CONF_OPTS = \
-DCFG_TEE_FS_PARENT_PATH=$(BR2_PACKAGE_OPTEE_CLIENT_TEE_FS_PATH) \
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf
2022-11-30 7:54 ` [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf Etienne Carriere
@ 2022-12-04 11:17 ` Yann E. MORIN
2022-12-05 8:52 ` Etienne Carriere
0 siblings, 1 reply; 10+ messages in thread
From: Yann E. MORIN @ 2022-12-04 11:17 UTC (permalink / raw)
To: Etienne Carriere; +Cc: buildroot
Etienne, All,
On 2022-11-30 08:54 +0100, Etienne Carriere spake thusly:
> In order to use login methods `TEEC_LOGIN_USER` and `TEEC_LOGIN_GROUP`,
> a user space application must initialize the tokens with the SHA1
> hashed UUID of the user or group.
>
> Select host-pkgconf, util-linux and libuuid in order to use `libuuid`
> and add supporting libraries to optee_client for this type of ACL based
> login initialization.
Looking at the upstream code for optee-client, it looks like this is a
mandatory dependency, so that should be part of the patch that bumps the
version. Otherwise, this means that just applying the version bumps
introduces breakage.
Regards,
Yann E. MORIN.
> This change is based on commit [1] from Eero Aaltonen, merged in OP-TEE
> test build environment.
>
> Link: [1] https://github.com/OP-TEE/build/commit/4a27543494278a5d93e2f44d58e413d90739b08a
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> package/optee-client/Config.in | 3 +++
> package/optee-client/optee-client.mk | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in
> index cc7f176c77..ed7da4edbc 100644
> --- a/package/optee-client/Config.in
> +++ b/package/optee-client/Config.in
> @@ -2,6 +2,9 @@ config BR2_PACKAGE_OPTEE_CLIENT
> bool "optee-client"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3 # MMC_IOC_MULTI_CMD
> + select BR2_PACKAGE_UTIL_LINUX
> + select BR2_PACKAGE_UTIL_LINUX_LIBS
> + select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> help
> Enable the OP-TEE client package that brings non-secure
> client application resources for OP-TEE support. OP-TEE
> diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
> index 54cc112c5c..a671b66662 100644
> --- a/package/optee-client/optee-client.mk
> +++ b/package/optee-client/optee-client.mk
> @@ -9,6 +9,7 @@ OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
> OPTEE_CLIENT_LICENSE = BSD-2-Clause
> OPTEE_CLIENT_LICENSE_FILES = LICENSE
> OPTEE_CLIENT_INSTALL_STAGING = YES
> +OPTEE_CLIENT_EXT_DEPENDENCIES = host-pkgconf util-linux-libs
>
> OPTEE_CLIENT_CONF_OPTS = \
> -DCFG_TEE_FS_PARENT_PATH=$(BR2_PACKAGE_OPTEE_CLIENT_TEE_FS_PATH) \
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf
2022-12-04 11:17 ` Yann E. MORIN
@ 2022-12-05 8:52 ` Etienne Carriere
0 siblings, 0 replies; 10+ messages in thread
From: Etienne Carriere @ 2022-12-05 8:52 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
On Sun, 4 Dec 2022 at 12:17, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Etienne, All,
>
> On 2022-11-30 08:54 +0100, Etienne Carriere spake thusly:
> > In order to use login methods `TEEC_LOGIN_USER` and `TEEC_LOGIN_GROUP`,
> > a user space application must initialize the tokens with the SHA1
> > hashed UUID of the user or group.
> >
> > Select host-pkgconf, util-linux and libuuid in order to use `libuuid`
> > and add supporting libraries to optee_client for this type of ACL based
> > login initialization.
>
> Looking at the upstream code for optee-client, it looks like this is a
> mandatory dependency, so that should be part of the patch that bumps the
> version. Otherwise, this means that just applying the version bumps
> introduces breakage.
There is a change under review in optee-client to remove this
dependencies that is not mandatory in optee.
https://github.com/OP-TEE/optee_client/pull/336
The change has been approved by maintaiters but is not in optee 3.19.0 tag.
Are you ok if I add the patch from pull/336 to optee-client BR patch
for this optee-client 3.19.0?
I'll remove it when BR will bump to optee 3.20.0.
Br,
Etienne
>
> Regards,
> Yann E. MORIN.
>
> > This change is based on commit [1] from Eero Aaltonen, merged in OP-TEE
> > test build environment.
> >
> > Link: [1] https://github.com/OP-TEE/build/commit/4a27543494278a5d93e2f44d58e413d90739b08a
> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> > ---
> > package/optee-client/Config.in | 3 +++
> > package/optee-client/optee-client.mk | 1 +
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in
> > index cc7f176c77..ed7da4edbc 100644
> > --- a/package/optee-client/Config.in
> > +++ b/package/optee-client/Config.in
> > @@ -2,6 +2,9 @@ config BR2_PACKAGE_OPTEE_CLIENT
> > bool "optee-client"
> > depends on BR2_TOOLCHAIN_HAS_THREADS
> > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3 # MMC_IOC_MULTI_CMD
> > + select BR2_PACKAGE_UTIL_LINUX
> > + select BR2_PACKAGE_UTIL_LINUX_LIBS
> > + select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> > help
> > Enable the OP-TEE client package that brings non-secure
> > client application resources for OP-TEE support. OP-TEE
> > diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
> > index 54cc112c5c..a671b66662 100644
> > --- a/package/optee-client/optee-client.mk
> > +++ b/package/optee-client/optee-client.mk
> > @@ -9,6 +9,7 @@ OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
> > OPTEE_CLIENT_LICENSE = BSD-2-Clause
> > OPTEE_CLIENT_LICENSE_FILES = LICENSE
> > OPTEE_CLIENT_INSTALL_STAGING = YES
> > +OPTEE_CLIENT_EXT_DEPENDENCIES = host-pkgconf util-linux-libs
> >
> > OPTEE_CLIENT_CONF_OPTS = \
> > -DCFG_TEE_FS_PARENT_PATH=$(BR2_PACKAGE_OPTEE_CLIENT_TEE_FS_PATH) \
> > --
> > 2.25.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues
2022-11-30 7:54 [Buildroot] [PATCH 1/7] boot/optee-os: bump to version 3.19.0 Etienne Carriere
` (4 preceding siblings ...)
2022-11-30 7:54 ` [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf Etienne Carriere
@ 2022-11-30 7:54 ` Etienne Carriere
2022-12-03 21:16 ` Yann E. MORIN
5 siblings, 1 reply; 10+ messages in thread
From: Etienne Carriere @ 2022-11-30 7:54 UTC (permalink / raw)
To: buildroot; +Cc: Etienne Carriere
Fix issues reported by utils/check-package:
package/optee-client/S30optee:40: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
package/optee-client/S30optee:46: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
package/optee-client/S30optee:47: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
package/optee-client/S30optee:48: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
package/optee-client/S30optee | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/optee-client/S30optee b/package/optee-client/S30optee
index 17e6d6d2b8..abb7e77afe 100644
--- a/package/optee-client/S30optee
+++ b/package/optee-client/S30optee
@@ -37,13 +37,13 @@ restart() {
}
case "$1" in
- start|stop|restart)
+ start|stop|restart)
"$1";;
reload)
# Restart, since there is no true "reload" feature (does not
# reconfigure/restart on SIGHUP, just closes all open files).
restart;;
- *)
- echo "Usage: $0 {start|stop|restart|reload}"
- exit 1
+ *)
+ echo "Usage: $0 {start|stop|restart|reload}"
+ exit 1
esac
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues
2022-11-30 7:54 ` [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues Etienne Carriere
@ 2022-12-03 21:16 ` Yann E. MORIN
0 siblings, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2022-12-03 21:16 UTC (permalink / raw)
To: Etienne Carriere; +Cc: buildroot
Etienne, All,
On 2022-11-30 08:54 +0100, Etienne Carriere spake thusly:
> Fix issues reported by utils/check-package:
> package/optee-client/S30optee:40: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:46: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:47: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:48: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
I also had:
package/optee-client/S30optee:0: filename should be S<number><number><daemon name> (http://nightly.buildroot.org/#adding-packages-start-script)
package/optee-client/S30tee-supplicant:0: run 'shellcheck' and fix the warnings
So I also fixed those and applied to master, thanks.
Since those are fixes for existing issues, it should come early in the
series. I.e. a series should first fix issues, then add features (like
bumping a version).
That way, fixes can be applied early even if the rest of the series has
issues, and they can also more easily be backported as they do not
depend on the previous feature patches (in this case the fix applied
cleanly, but that's not always the case).
Regards,
Yann E. MORIN.
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> package/optee-client/S30optee | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/optee-client/S30optee b/package/optee-client/S30optee
> index 17e6d6d2b8..abb7e77afe 100644
> --- a/package/optee-client/S30optee
> +++ b/package/optee-client/S30optee
> @@ -37,13 +37,13 @@ restart() {
> }
>
> case "$1" in
> - start|stop|restart)
> + start|stop|restart)
> "$1";;
> reload)
> # Restart, since there is no true "reload" feature (does not
> # reconfigure/restart on SIGHUP, just closes all open files).
> restart;;
> - *)
> - echo "Usage: $0 {start|stop|restart|reload}"
> - exit 1
> + *)
> + echo "Usage: $0 {start|stop|restart|reload}"
> + exit 1
> esac
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread