From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Walle <michael@walle.cc>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: Document support for more MT25QU parts
Date: Mon, 5 Dec 2022 10:33:06 -0600 [thread overview]
Message-ID: <20221205163306.GB2012644-robh@kernel.org> (raw)
In-Reply-To: <CAMuHMdXN+HJb=zGeG=3t=Pie9cVpnBLYuEb_qX6=oSxG8eTkAw@mail.gmail.com>
On Fri, Dec 02, 2022 at 02:56:01PM +0100, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Fri, Dec 2, 2022 at 2:50 PM Michael Walle <michael@walle.cc> wrote:
> > Am 2022-12-02 14:37, schrieb Geert Uytterhoeven:
> > > Document support for the Micron MT25QU256A and MT25QU512A Serial NOR
> > > FLASHes.
> > >
> > > Merge the new entries with the existing entry for MT25QU02G.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > mt25qu512a is already in active use, causing "make dtbs_check" errors.
> > > mt25qu256a is supported by the Linux spi-nor driver, but there are no
> > > upstream users yet.
> >
> > Is it encouraged to use the specific compatible with SPI-NOR flashes?
> > As far as I know it isn't. The spi-nor subsys tries hard to identify
> > any flashes at runtime and any additional information in the device tree
> > is used as a last resort (just for flashes which doesn't support the
> > read jedec id command yet). And usually boards have different sources
> > for flash chips, so hardcoding a particular part in the device tree
> > doesn't make sense.
>
> Thanks, I am aware there have been pushbacks when trying to
> document more compatible values.
>
> IMHO either all or none of them should be documented.
> If device-specific compatible values are discouraged, the bindings
> should be updated to reflect that, and document a single compatible
> value ("jedec,spi-nor") only.
That's already allowed, so there's your answer.
The caveat is don't be adding them later to your DT when you find an
issue and new quirk properties will probably be rejected.
Rob
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Walle <michael@walle.cc>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: Document support for more MT25QU parts
Date: Mon, 5 Dec 2022 10:33:06 -0600 [thread overview]
Message-ID: <20221205163306.GB2012644-robh@kernel.org> (raw)
In-Reply-To: <CAMuHMdXN+HJb=zGeG=3t=Pie9cVpnBLYuEb_qX6=oSxG8eTkAw@mail.gmail.com>
On Fri, Dec 02, 2022 at 02:56:01PM +0100, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Fri, Dec 2, 2022 at 2:50 PM Michael Walle <michael@walle.cc> wrote:
> > Am 2022-12-02 14:37, schrieb Geert Uytterhoeven:
> > > Document support for the Micron MT25QU256A and MT25QU512A Serial NOR
> > > FLASHes.
> > >
> > > Merge the new entries with the existing entry for MT25QU02G.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > mt25qu512a is already in active use, causing "make dtbs_check" errors.
> > > mt25qu256a is supported by the Linux spi-nor driver, but there are no
> > > upstream users yet.
> >
> > Is it encouraged to use the specific compatible with SPI-NOR flashes?
> > As far as I know it isn't. The spi-nor subsys tries hard to identify
> > any flashes at runtime and any additional information in the device tree
> > is used as a last resort (just for flashes which doesn't support the
> > read jedec id command yet). And usually boards have different sources
> > for flash chips, so hardcoding a particular part in the device tree
> > doesn't make sense.
>
> Thanks, I am aware there have been pushbacks when trying to
> document more compatible values.
>
> IMHO either all or none of them should be documented.
> If device-specific compatible values are discouraged, the bindings
> should be updated to reflect that, and document a single compatible
> value ("jedec,spi-nor") only.
That's already allowed, so there's your answer.
The caveat is don't be adding them later to your DT when you find an
issue and new quirk properties will probably be rejected.
Rob
next prev parent reply other threads:[~2022-12-05 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 13:37 [PATCH] dt-bindings: mtd: jedec,spi-nor: Document support for more MT25QU parts Geert Uytterhoeven
2022-12-02 13:37 ` Geert Uytterhoeven
2022-12-02 13:50 ` Michael Walle
2022-12-02 13:50 ` Michael Walle
2022-12-02 13:56 ` Geert Uytterhoeven
2022-12-02 13:56 ` Geert Uytterhoeven
2022-12-05 16:33 ` Rob Herring [this message]
2022-12-05 16:33 ` Rob Herring
2022-12-06 8:32 ` Geert Uytterhoeven
2022-12-06 8:32 ` Geert Uytterhoeven
2023-09-21 14:45 ` Tudor Ambarus
2023-09-21 14:45 ` Tudor Ambarus
2023-09-21 15:10 ` Geert Uytterhoeven
2023-09-21 15:10 ` Geert Uytterhoeven
2023-09-21 16:01 ` Michael Walle
2023-09-21 16:01 ` Michael Walle
2023-09-21 17:01 ` Geert Uytterhoeven
2023-09-21 17:01 ` Geert Uytterhoeven
2023-09-22 7:10 ` Geert Uytterhoeven
2023-09-22 7:10 ` Geert Uytterhoeven
2023-09-22 7:59 ` Michael Walle
2023-09-22 7:59 ` Michael Walle
2022-12-05 16:25 ` Rob Herring
2022-12-05 16:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205163306.GB2012644-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.