Re: [PATCH] Linux: SPI: add Gigadevice part #

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Vlim <vlim@gigadevice.com>
Cc: Michael Walle <michael@walle.cc>,
	Victor Lim <victorswlim@gmail.com>,
	"tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
	"p.yadav@ti.com" <p.yadav@ti.com>,
	"richard@nod.at" <richard@nod.at>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
	"amit.kumar-mahapatra@amd.com" <amit.kumar-mahapatra@amd.com>,
	"alejandro.carmona@amd.com" <alejandro.carmona@amd.com>
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
Date: Tue, 6 Dec 2022 09:18:46 +0100	[thread overview]
Message-ID: <20221206091846.02f6396f@xps-13> (raw)
In-Reply-To: <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>

Hi Vlim,

vlim@gigadevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:

> Hi, Michael,
> 
> I will redo the patch following this doc.
> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.

Here are a few:
- The title is wrong (git log --oneline <file> for hints)
- The commit log is useless
- Don't make unrelated changes in your commit, one change == one commit
- Don't change how the code looks like for no reason or justification

And please avoid top posting when answering.

Good luck!

Thanks,
Miquèl

> 
> ________________________________
> From: Michael Walle <michael@walle.cc>
> Sent: Monday, December 5, 2022 00:22
> To: Victor Lim <victorswlim@gmail.com>
> Cc: tudor.ambarus@microchip.com <tudor.ambarus@microchip.com>; p.yadav@ti.com <p.yadav@ti.com>; miquel.raynal@bootlin.com <miquel.raynal@bootlin.com>; richard@nod.at <richard@nod.at>; vigneshr@ti.com <vigneshr@ti.com>; linux-mtd@lists.infradead.org <linux-mtd@lists.infradead.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; vikhyat.goyal@amd.com <vikhyat.goyal@amd.com>; amit.kumar-mahapatra@amd.com <amit.kumar-mahapatra@amd.com>; alejandro.carmona@amd.com <alejandro.carmona@amd.com>; Vlim <vlim@gigadevice.com>
> Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
> 
> [You don't often get email from michael@walle.cc. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> 
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> 
> 
> Hi,
> 
> Am 2022-12-04 09:00, schrieb Victor Lim:
> > Edited gigadevice.c  
> 
> Please have a look at
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> -michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/