All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC
@ 2022-11-07  7:13 Quan Nguyen
  2022-11-21  7:33 ` Quan Nguyen
  2022-12-07  6:48 ` Zev Weiss
  0 siblings, 2 replies; 4+ messages in thread
From: Quan Nguyen @ 2022-11-07  7:13 UTC (permalink / raw)
  To: Joel Stanley, openbmc
  Cc: Open Source Submission, Thang Nguyen, Phong Vo, Quan Nguyen

Add initial device tree for Aspeed AST2600-based Mt. Mitchell
BMC found on AmpereOne's reference platform.

Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
---
 arch/arm/dts/Makefile               |   1 +
 arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)
 create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 6c34b83336..b6f9df21fc 100755
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2600-dcscm.dtb \
 	ast2600-fpga.dtb \
 	ast2600-intel.dtb \
+	ast2600-mtmitchell.dtb \
 	ast2600-ncsi.dtb \
 	ast2600-p10bmc.dtb \
 	ast2600-pfr.dtb \
diff --git a/arch/arm/dts/ast2600-mtmitchell.dts b/arch/arm/dts/ast2600-mtmitchell.dts
new file mode 100644
index 0000000000..69ed0c5fbc
--- /dev/null
+++ b/arch/arm/dts/ast2600-mtmitchell.dts
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2022, Ampere Computing LLC
+
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "Ampere Mt.Mitchell BMC";
+	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	chosen {
+		stdout-path = &uart5;
+	};
+
+	aliases {
+		spi0 = &fmc;
+		ethernet0 = &mac0;
+	};
+
+	cpus {
+		cpu@0 {
+			clock-frequency = <800000000>;
+		};
+		cpu@1 {
+			clock-frequency = <800000000>;
+		};
+	};
+};
+
+&uart5 {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&sdrammc {
+	clock-frequency = <400000000>;
+};
+
+&wdt1 {
+	status = "okay";
+};
+
+&wdt2 {
+	status = "okay";
+};
+
+&wdt3 {
+	status = "okay";
+};
+
+&mdio {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <	&pinctrl_mdio1_default &pinctrl_mdio2_default
+			&pinctrl_mdio3_default &pinctrl_mdio4_default>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&fmc {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fmcquad_default>;
+
+	flash@0 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+
+	flash@1 {
+		compatible = "spi-flash", "sst,w25q256";
+		status = "okay";
+		spi-max-frequency = <50000000>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
+	};
+};
+
+&scu {
+	mac0-clk-delay = <0x10 0x0a
+			  0x10 0x10
+			  0x10 0x10>;
+};
+
+&hace {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
+
+&acry {
+	u-boot,dm-pre-reloc;
+	status = "okay";
+};
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC
  2022-11-07  7:13 [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC Quan Nguyen
@ 2022-11-21  7:33 ` Quan Nguyen
  2022-12-07  6:27   ` Quan Nguyen
  2022-12-07  6:48 ` Zev Weiss
  1 sibling, 1 reply; 4+ messages in thread
From: Quan Nguyen @ 2022-11-21  7:33 UTC (permalink / raw)
  To: Joel Stanley, openbmc; +Cc: Open Source Submission, Thang Nguyen, Phong Vo

Just a gentle ping on the patch.
Thanks
- Quan

On 07/11/2022 14:13, Quan Nguyen wrote:
> Add initial device tree for Aspeed AST2600-based Mt. Mitchell
> BMC found on AmpereOne's reference platform.
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
>   arch/arm/dts/Makefile               |   1 +
>   arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
>   2 files changed, 115 insertions(+)
>   create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 6c34b83336..b6f9df21fc 100755
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>   	ast2600-dcscm.dtb \
>   	ast2600-fpga.dtb \
>   	ast2600-intel.dtb \
> +	ast2600-mtmitchell.dtb \
>   	ast2600-ncsi.dtb \
>   	ast2600-p10bmc.dtb \
>   	ast2600-pfr.dtb \
> diff --git a/arch/arm/dts/ast2600-mtmitchell.dts b/arch/arm/dts/ast2600-mtmitchell.dts
> new file mode 100644
> index 0000000000..69ed0c5fbc
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-mtmitchell.dts
> @@ -0,0 +1,114 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Copyright (c) 2022, Ampere Computing LLC
> +
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> +	model = "Ampere Mt.Mitchell BMC";
> +	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x80000000 0x40000000>;
> +	};
> +
> +	chosen {
> +		stdout-path = &uart5;
> +	};
> +
> +	aliases {
> +		spi0 = &fmc;
> +		ethernet0 = &mac0;
> +	};
> +
> +	cpus {
> +		cpu@0 {
> +			clock-frequency = <800000000>;
> +		};
> +		cpu@1 {
> +			clock-frequency = <800000000>;
> +		};
> +	};
> +};
> +
> +&uart5 {
> +	u-boot,dm-pre-reloc;
> +	status = "okay";
> +};
> +
> +&sdrammc {
> +	clock-frequency = <400000000>;
> +};
> +
> +&wdt1 {
> +	status = "okay";
> +};
> +
> +&wdt2 {
> +	status = "okay";
> +};
> +
> +&wdt3 {
> +	status = "okay";
> +};
> +
> +&mdio {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <	&pinctrl_mdio1_default &pinctrl_mdio2_default
> +			&pinctrl_mdio3_default &pinctrl_mdio4_default>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	ethphy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
> +};
> +
> +&mac0 {
> +	status = "okay";
> +	phy-mode = "rgmii-rxid";
> +	phy-handle = <&ethphy0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rgmii1_default>;
> +};
> +
> +&fmc {
> +	status = "okay";
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fmcquad_default>;
> +
> +	flash@0 {
> +		compatible = "spi-flash", "sst,w25q256";
> +		status = "okay";
> +		spi-max-frequency = <50000000>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
> +	};
> +
> +	flash@1 {
> +		compatible = "spi-flash", "sst,w25q256";
> +		status = "okay";
> +		spi-max-frequency = <50000000>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
> +	};
> +};
> +
> +&scu {
> +	mac0-clk-delay = <0x10 0x0a
> +			  0x10 0x10
> +			  0x10 0x10>;
> +};
> +
> +&hace {
> +	u-boot,dm-pre-reloc;
> +	status = "okay";
> +};
> +
> +&acry {
> +	u-boot,dm-pre-reloc;
> +	status = "okay";
> +};

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC
  2022-11-21  7:33 ` Quan Nguyen
@ 2022-12-07  6:27   ` Quan Nguyen
  0 siblings, 0 replies; 4+ messages in thread
From: Quan Nguyen @ 2022-12-07  6:27 UTC (permalink / raw)
  To: Joel Stanley, openbmc; +Cc: Open Source Submission, Thang Nguyen, Phong Vo

Dear maintainers,

Just for a another gentle ping on the patch.

Thanks
- Quan

On 21/11/2022 14:33, Quan Nguyen wrote:
> Just a gentle ping on the patch.
> Thanks
> - Quan
> 
> On 07/11/2022 14:13, Quan Nguyen wrote:
>> Add initial device tree for Aspeed AST2600-based Mt. Mitchell
>> BMC found on AmpereOne's reference platform.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>>   arch/arm/dts/Makefile               |   1 +
>>   arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
>>   2 files changed, 115 insertions(+)
>>   create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index 6c34b83336..b6f9df21fc 100755
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>       ast2600-dcscm.dtb \
>>       ast2600-fpga.dtb \
>>       ast2600-intel.dtb \
>> +    ast2600-mtmitchell.dtb \
>>       ast2600-ncsi.dtb \
>>       ast2600-p10bmc.dtb \
>>       ast2600-pfr.dtb \
>> diff --git a/arch/arm/dts/ast2600-mtmitchell.dts 
>> b/arch/arm/dts/ast2600-mtmitchell.dts
>> new file mode 100644
>> index 0000000000..69ed0c5fbc
>> --- /dev/null
>> +++ b/arch/arm/dts/ast2600-mtmitchell.dts
>> @@ -0,0 +1,114 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +// Copyright (c) 2022, Ampere Computing LLC
>> +
>> +/dts-v1/;
>> +
>> +#include "ast2600-u-boot.dtsi"
>> +
>> +/ {
>> +    model = "Ampere Mt.Mitchell BMC";
>> +    compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
>> +
>> +    memory {
>> +        device_type = "memory";
>> +        reg = <0x80000000 0x40000000>;
>> +    };
>> +
>> +    chosen {
>> +        stdout-path = &uart5;
>> +    };
>> +
>> +    aliases {
>> +        spi0 = &fmc;
>> +        ethernet0 = &mac0;
>> +    };
>> +
>> +    cpus {
>> +        cpu@0 {
>> +            clock-frequency = <800000000>;
>> +        };
>> +        cpu@1 {
>> +            clock-frequency = <800000000>;
>> +        };
>> +    };
>> +};
>> +
>> +&uart5 {
>> +    u-boot,dm-pre-reloc;
>> +    status = "okay";
>> +};
>> +
>> +&sdrammc {
>> +    clock-frequency = <400000000>;
>> +};
>> +
>> +&wdt1 {
>> +    status = "okay";
>> +};
>> +
>> +&wdt2 {
>> +    status = "okay";
>> +};
>> +
>> +&wdt3 {
>> +    status = "okay";
>> +};
>> +
>> +&mdio {
>> +    status = "okay";
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <    &pinctrl_mdio1_default &pinctrl_mdio2_default
>> +            &pinctrl_mdio3_default &pinctrl_mdio4_default>;
>> +    #address-cells = <1>;
>> +    #size-cells = <0>;
>> +    ethphy0: ethernet-phy@0 {
>> +        reg = <0>;
>> +    };
>> +};
>> +
>> +&mac0 {
>> +    status = "okay";
>> +    phy-mode = "rgmii-rxid";
>> +    phy-handle = <&ethphy0>;
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&pinctrl_rgmii1_default>;
>> +};
>> +
>> +&fmc {
>> +    status = "okay";
>> +
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&pinctrl_fmcquad_default>;
>> +
>> +    flash@0 {
>> +        compatible = "spi-flash", "sst,w25q256";
>> +        status = "okay";
>> +        spi-max-frequency = <50000000>;
>> +        spi-tx-bus-width = <4>;
>> +        spi-rx-bus-width = <4>;
>> +    };
>> +
>> +    flash@1 {
>> +        compatible = "spi-flash", "sst,w25q256";
>> +        status = "okay";
>> +        spi-max-frequency = <50000000>;
>> +        spi-tx-bus-width = <4>;
>> +        spi-rx-bus-width = <4>;
>> +    };
>> +};
>> +
>> +&scu {
>> +    mac0-clk-delay = <0x10 0x0a
>> +              0x10 0x10
>> +              0x10 0x10>;
>> +};
>> +
>> +&hace {
>> +    u-boot,dm-pre-reloc;
>> +    status = "okay";
>> +};
>> +
>> +&acry {
>> +    u-boot,dm-pre-reloc;
>> +    status = "okay";
>> +};

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC
  2022-11-07  7:13 [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC Quan Nguyen
  2022-11-21  7:33 ` Quan Nguyen
@ 2022-12-07  6:48 ` Zev Weiss
  1 sibling, 0 replies; 4+ messages in thread
From: Zev Weiss @ 2022-12-07  6:48 UTC (permalink / raw)
  To: Quan Nguyen
  Cc: openbmc@lists.ozlabs.org, Open Source Submission, Joel Stanley,
	Phong Vo, Thang Nguyen

On Sun, Nov 06, 2022 at 11:13:48PM PST, Quan Nguyen wrote:
>Add initial device tree for Aspeed AST2600-based Mt. Mitchell
>BMC found on AmpereOne's reference platform.
>
>Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>---
> arch/arm/dts/Makefile               |   1 +
> arch/arm/dts/ast2600-mtmitchell.dts | 114 ++++++++++++++++++++++++++++
> 2 files changed, 115 insertions(+)
> create mode 100644 arch/arm/dts/ast2600-mtmitchell.dts
>
>diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>index 6c34b83336..b6f9df21fc 100755
>--- a/arch/arm/dts/Makefile
>+++ b/arch/arm/dts/Makefile
>@@ -687,6 +687,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> 	ast2600-dcscm.dtb \
> 	ast2600-fpga.dtb \
> 	ast2600-intel.dtb \
>+	ast2600-mtmitchell.dtb \
> 	ast2600-ncsi.dtb \
> 	ast2600-p10bmc.dtb \
> 	ast2600-pfr.dtb \
>diff --git a/arch/arm/dts/ast2600-mtmitchell.dts b/arch/arm/dts/ast2600-mtmitchell.dts
>new file mode 100644
>index 0000000000..69ed0c5fbc
>--- /dev/null
>+++ b/arch/arm/dts/ast2600-mtmitchell.dts
>@@ -0,0 +1,114 @@
>+// SPDX-License-Identifier: GPL-2.0-only
>+// Copyright (c) 2022, Ampere Computing LLC
>+
>+/dts-v1/;
>+
>+#include "ast2600-u-boot.dtsi"
>+
>+/ {
>+	model = "Ampere Mt.Mitchell BMC";
>+	compatible = "ampere,mtmitchell-bmc", "aspeed,ast2600";
>+
>+	memory {
>+		device_type = "memory";
>+		reg = <0x80000000 0x40000000>;
>+	};
>+
>+	chosen {
>+		stdout-path = &uart5;
>+	};
>+
>+	aliases {
>+		spi0 = &fmc;
>+		ethernet0 = &mac0;
>+	};
>+
>+	cpus {
>+		cpu@0 {
>+			clock-frequency = <800000000>;
>+		};
>+		cpu@1 {
>+			clock-frequency = <800000000>;
>+		};
>+	};
>+};
>+
>+&uart5 {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>+
>+&sdrammc {
>+	clock-frequency = <400000000>;
>+};
>+
>+&wdt1 {
>+	status = "okay";
>+};
>+
>+&wdt2 {
>+	status = "okay";
>+};
>+
>+&wdt3 {
>+	status = "okay";
>+};
>+
>+&mdio {
>+	status = "okay";
>+	pinctrl-names = "default";
>+	pinctrl-0 = <	&pinctrl_mdio1_default &pinctrl_mdio2_default

Not sure if there are any particular official style rules that apply
here, but the gap between the '<' and the first item looks a bit weird
IMO.

Aside from that small nit,

Reviewed-by: Zev Weiss <zweiss@equinix.com>

>+			&pinctrl_mdio3_default &pinctrl_mdio4_default>;
>+	#address-cells = <1>;
>+	#size-cells = <0>;
>+	ethphy0: ethernet-phy@0 {
>+		reg = <0>;
>+	};
>+};
>+
>+&mac0 {
>+	status = "okay";
>+	phy-mode = "rgmii-rxid";
>+	phy-handle = <&ethphy0>;
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&pinctrl_rgmii1_default>;
>+};
>+
>+&fmc {
>+	status = "okay";
>+
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&pinctrl_fmcquad_default>;
>+
>+	flash@0 {
>+		compatible = "spi-flash", "sst,w25q256";
>+		status = "okay";
>+		spi-max-frequency = <50000000>;
>+		spi-tx-bus-width = <4>;
>+		spi-rx-bus-width = <4>;
>+	};
>+
>+	flash@1 {
>+		compatible = "spi-flash", "sst,w25q256";
>+		status = "okay";
>+		spi-max-frequency = <50000000>;
>+		spi-tx-bus-width = <4>;
>+		spi-rx-bus-width = <4>;
>+	};
>+};
>+
>+&scu {
>+	mac0-clk-delay = <0x10 0x0a
>+			  0x10 0x10
>+			  0x10 0x10>;
>+};
>+
>+&hace {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>+
>+&acry {
>+	u-boot,dm-pre-reloc;
>+	status = "okay";
>+};
>-- 
>2.35.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-07  6:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-07  7:13 [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Ampere's Mt. Mitchell BMC Quan Nguyen
2022-11-21  7:33 ` Quan Nguyen
2022-12-07  6:27   ` Quan Nguyen
2022-12-07  6:48 ` Zev Weiss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.