From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@nvidia.com, razor@blackwall.org,
Ido Schimmel <idosch@nvidia.com>,
edumazet@google.com, roopa@nvidia.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: [Bridge] [PATCH net-next v2 08/14] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source
Date: Sat, 10 Dec 2022 16:56:27 +0200 [thread overview]
Message-ID: <20221210145633.1328511-9-idosch@nvidia.com> (raw)
In-Reply-To: <20221210145633.1328511-1-idosch@nvidia.com>
User space will soon be able to install a (*, G) with a source list,
prompting the creation of a (S, G) entry for each source.
In this case, the group timer of the (S, G) entry should never be set.
Solve this by adding a new field to the MDB configuration structure that
denotes whether the (S, G) corresponds to a source or not.
The field will be set in a subsequent patch where br_mdb_add_group_sg()
is called in order to create a (S, G) entry for each user provided
source.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
---
net/bridge/br_mdb.c | 2 +-
net/bridge/br_private.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 95780652cdbf..7cda9d1c5c93 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -814,7 +814,7 @@ static int br_mdb_add_group_sg(const struct br_mdb_config *cfg,
return -ENOMEM;
}
rcu_assign_pointer(*pp, p);
- if (!(flags & MDB_PG_FLAGS_PERMANENT))
+ if (!(flags & MDB_PG_FLAGS_PERMANENT) && !cfg->src_entry)
mod_timer(&p->timer,
now + brmctx->multicast_membership_interval);
br_mdb_notify(cfg->br->dev, mp, p, RTM_NEWMDB);
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 74f17b56c9eb..e98bfe3c02e1 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -98,6 +98,7 @@ struct br_mdb_config {
struct net_bridge_port *p;
struct br_mdb_entry *entry;
struct br_ip group;
+ bool src_entry;
};
#endif
--
2.37.3
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, roopa@nvidia.com, razor@blackwall.org,
mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next v2 08/14] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source
Date: Sat, 10 Dec 2022 16:56:27 +0200 [thread overview]
Message-ID: <20221210145633.1328511-9-idosch@nvidia.com> (raw)
In-Reply-To: <20221210145633.1328511-1-idosch@nvidia.com>
User space will soon be able to install a (*, G) with a source list,
prompting the creation of a (S, G) entry for each source.
In this case, the group timer of the (S, G) entry should never be set.
Solve this by adding a new field to the MDB configuration structure that
denotes whether the (S, G) corresponds to a source or not.
The field will be set in a subsequent patch where br_mdb_add_group_sg()
is called in order to create a (S, G) entry for each user provided
source.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
---
net/bridge/br_mdb.c | 2 +-
net/bridge/br_private.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 95780652cdbf..7cda9d1c5c93 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -814,7 +814,7 @@ static int br_mdb_add_group_sg(const struct br_mdb_config *cfg,
return -ENOMEM;
}
rcu_assign_pointer(*pp, p);
- if (!(flags & MDB_PG_FLAGS_PERMANENT))
+ if (!(flags & MDB_PG_FLAGS_PERMANENT) && !cfg->src_entry)
mod_timer(&p->timer,
now + brmctx->multicast_membership_interval);
br_mdb_notify(cfg->br->dev, mp, p, RTM_NEWMDB);
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 74f17b56c9eb..e98bfe3c02e1 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -98,6 +98,7 @@ struct br_mdb_config {
struct net_bridge_port *p;
struct br_mdb_entry *entry;
struct br_ip group;
+ bool src_entry;
};
#endif
--
2.37.3
next prev parent reply other threads:[~2022-12-10 14:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 14:56 [Bridge] [PATCH net-next v2 00/14] bridge: mcast: Extensions for EVPN Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 01/14] bridge: mcast: Do not derive entry type from its filter mode Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 02/14] bridge: mcast: Split (*, G) and (S, G) addition into different functions Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 03/14] bridge: mcast: Place netlink policy before validation functions Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 04/14] bridge: mcast: Add a centralized error path Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 05/14] bridge: mcast: Expose br_multicast_new_group_src() Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 06/14] bridge: mcast: Expose __br_multicast_del_group_src() Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 07/14] bridge: mcast: Add a flag for user installed source entries Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel [this message]
2022-12-10 14:56 ` [PATCH net-next v2 08/14] bridge: mcast: Avoid arming group timer when (S, G) corresponds to a source Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 09/14] bridge: mcast: Add support for (*, G) with a source list and filter mode Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 10/14] bridge: mcast: Allow user space to add " Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 11/14] bridge: mcast: Allow user space to specify MDB entry routing protocol Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 12/14] bridge: mcast: Support replacement of MDB port group entries Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-11 9:26 ` [Bridge] " Nikolay Aleksandrov
2022-12-11 9:26 ` Nikolay Aleksandrov
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 13/14] selftests: forwarding: Rename bridge_mdb test Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-10 14:56 ` [Bridge] [PATCH net-next v2 14/14] selftests: forwarding: Add bridge MDB test Ido Schimmel
2022-12-10 14:56 ` Ido Schimmel
2022-12-12 23:40 ` [Bridge] [PATCH net-next v2 00/14] bridge: mcast: Extensions for EVPN patchwork-bot+netdevbpf
2022-12-12 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210145633.1328511-9-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.