From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: mustafa.ismail@intel.com, leon@kernel.org,
benjamin.mikailenko@intel.com, jesse.brandeburg@intel.com,
leszek.kaliszczuk@intel.com, netdev@vger.kernel.org,
przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org,
shiraz.saleem@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 00/10] implement devlink reload in ice
Date: Mon, 12 Dec 2022 10:15:05 -0800 [thread overview]
Message-ID: <20221212101505.403a4084@kernel.org> (raw)
In-Reply-To: <20221212111645.1198680-1-michal.swiatkowski@linux.intel.com>
On Mon, 12 Dec 2022 12:16:35 +0100 Michal Swiatkowski wrote:
> This is a part of changes done in patchset [0]. Resource management is
> kind of controversial part, so I split it into two patchsets.
>
> It is the first one, covering refactor and implement reload API call.
> The refactor will unblock some of the patches needed by SIOV or
> subfunction.
>
> Most of this patchset is about implementing driver reload mechanism.
> Part of code from probe and rebuild is used to not duplicate code.
> To allow this reuse probe and rebuild path are split into smaller
> functions.
>
> Patch "ice: split ice_vsi_setup into smaller functions" changes
> boolean variable in function call to integer and adds define
> for it. Instead of having the function called with true/false now it
> can be called with readable defines ICE_VSI_FLAG_INIT or
> ICE_VSI_FLAG_NO_INIT. It was suggested by Jacob Keller and probably this
> mechanism will be implemented across ice driver in follow up patchset.
Does not apply, unfortunately, which makes it easier for me to answer
to the question "should I try to squeeze this into 6.2"..
Hopefully we can get some reviews, but the changes seem uncontroversial.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, alexandr.lobakin@intel.com,
sridhar.samudrala@intel.com, wojciech.drewek@intel.com,
lukasz.czapnik@intel.com, shiraz.saleem@intel.com,
jesse.brandeburg@intel.com, mustafa.ismail@intel.com,
przemyslaw.kitszel@intel.com, piotr.raczynski@intel.com,
jacob.e.keller@intel.com, david.m.ertman@intel.com,
leszek.kaliszczuk@intel.com, benjamin.mikailenko@intel.com,
paul.m.stillwell.jr@intel.com, netdev@vger.kernel.org,
leon@kernel.org
Subject: Re: [PATCH net-next v1 00/10] implement devlink reload in ice
Date: Mon, 12 Dec 2022 10:15:05 -0800 [thread overview]
Message-ID: <20221212101505.403a4084@kernel.org> (raw)
In-Reply-To: <20221212111645.1198680-1-michal.swiatkowski@linux.intel.com>
On Mon, 12 Dec 2022 12:16:35 +0100 Michal Swiatkowski wrote:
> This is a part of changes done in patchset [0]. Resource management is
> kind of controversial part, so I split it into two patchsets.
>
> It is the first one, covering refactor and implement reload API call.
> The refactor will unblock some of the patches needed by SIOV or
> subfunction.
>
> Most of this patchset is about implementing driver reload mechanism.
> Part of code from probe and rebuild is used to not duplicate code.
> To allow this reuse probe and rebuild path are split into smaller
> functions.
>
> Patch "ice: split ice_vsi_setup into smaller functions" changes
> boolean variable in function call to integer and adds define
> for it. Instead of having the function called with true/false now it
> can be called with readable defines ICE_VSI_FLAG_INIT or
> ICE_VSI_FLAG_NO_INIT. It was suggested by Jacob Keller and probably this
> mechanism will be implemented across ice driver in follow up patchset.
Does not apply, unfortunately, which makes it easier for me to answer
to the question "should I try to squeeze this into 6.2"..
Hopefully we can get some reviews, but the changes seem uncontroversial.
next prev parent reply other threads:[~2022-12-12 18:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 11:16 [Intel-wired-lan] [PATCH net-next v1 00/10] implement devlink reload in ice Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 01/10] ice: move RDMA init to ice_idc.c Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 02/10] ice: alloc id for RDMA using xa_array Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 03/10] ice: cleanup in VSI config/deconfig code Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 04/10] ice: split ice_vsi_setup into smaller functions Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 05/10] ice: stop hard coding the ICE_VSI_CTRL location Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 06/10] ice: split probe into smaller functions Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 07/10] ice: sync netdev filters after clearing VSI Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 08/10] ice: move VSI delete outside deconfig Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 09/10] ice: update VSI instead of init in some case Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 11:16 ` [Intel-wired-lan] [PATCH net-next v1 10/10] ice: implement devlink reinit action Michal Swiatkowski
2022-12-12 11:16 ` Michal Swiatkowski
2022-12-12 18:15 ` Jakub Kicinski [this message]
2022-12-12 18:15 ` [PATCH net-next v1 00/10] implement devlink reload in ice Jakub Kicinski
2022-12-12 18:46 ` [Intel-wired-lan] " Jacob Keller
2022-12-12 18:46 ` Jacob Keller
2022-12-13 6:37 ` [Intel-wired-lan] " Michal Swiatkowski
2022-12-13 6:37 ` Michal Swiatkowski
2022-12-14 1:18 ` [Intel-wired-lan] " Jakub Kicinski
2022-12-14 1:18 ` Jakub Kicinski
2022-12-15 6:42 ` [Intel-wired-lan] " Michal Swiatkowski
2022-12-15 6:42 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212101505.403a4084@kernel.org \
--to=kuba@kernel.org \
--cc=benjamin.mikailenko@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=leon@kernel.org \
--cc=leszek.kaliszczuk@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.