All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, eesposit@redhat.com,
	pbonzini@redhat.com, vsementsov@yandex-team.ru,
	qemu-devel@nongnu.org
Subject: [PATCH 06/14] block-backend: use bdrv_getlength instead of blk_getlength
Date: Tue, 13 Dec 2022 09:53:12 +0100	[thread overview]
Message-ID: <20221213085320.95673-7-kwolf@redhat.com> (raw)
In-Reply-To: <20221213085320.95673-1-kwolf@redhat.com>

From: Emanuele Giuseppe Esposito <eesposit@redhat.com>

The only difference is that blk_ checks if the block is available,
but this check is already performed above in blk_check_byte_request().

This is in preparation for the graph rdlock, which will be taken
by both the callers of blk_check_byte_request() and blk_getlength().

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/block-backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/block-backend.c b/block/block-backend.c
index 0194d86113..5b8da86772 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1253,7 +1253,7 @@ static int blk_check_byte_request(BlockBackend *blk, int64_t offset,
     }
 
     if (!blk->allow_write_beyond_eof) {
-        len = blk_getlength(blk);
+        len = bdrv_getlength(blk_bs(blk));
         if (len < 0) {
             return len;
         }
-- 
2.38.1



  parent reply	other threads:[~2022-12-13  8:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  8:53 [PATCH 00/14] block: Move more functions to coroutines Kevin Wolf
2022-12-13  8:53 ` [PATCH 01/14] block-coroutine-wrapper: support void functions Kevin Wolf
2022-12-16 14:21   ` Vladimir Sementsov-Ogievskiy
2022-12-13  8:53 ` [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper Kevin Wolf
2022-12-16 14:26   ` Vladimir Sementsov-Ogievskiy
2022-12-19 12:24     ` Emanuele Giuseppe Esposito
2022-12-16 16:12   ` Vladimir Sementsov-Ogievskiy
2022-12-19 12:26     ` Emanuele Giuseppe Esposito
2023-01-13 15:51       ` Kevin Wolf
2022-12-13  8:53 ` [PATCH 03/14] block: Convert bdrv_io_unplug() " Kevin Wolf
2022-12-13  8:53 ` [PATCH 04/14] block: Rename refresh_total_sectors to bdrv_refresh_total_sectors Kevin Wolf
2022-12-16 16:55   ` Vladimir Sementsov-Ogievskiy
2022-12-13  8:53 ` [PATCH 05/14] block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed Kevin Wolf
2022-12-16 17:19   ` Vladimir Sementsov-Ogievskiy
2022-12-13  8:53 ` Kevin Wolf [this message]
2022-12-16 17:22   ` [PATCH 06/14] block-backend: use bdrv_getlength instead of blk_getlength Vladimir Sementsov-Ogievskiy
2022-12-19 12:28     ` Emanuele Giuseppe Esposito
2022-12-13  8:53 ` [PATCH 07/14] block: use bdrv_co_refresh_total_sectors when possible Kevin Wolf
2022-12-16 17:26   ` Vladimir Sementsov-Ogievskiy
2022-12-13  8:53 ` [PATCH 08/14] block: Convert bdrv_get_allocated_file_size() to co_wrapper Kevin Wolf
2022-12-13  8:53 ` [PATCH 09/14] block: Convert bdrv_get_info() to co_wrapper_mixed Kevin Wolf
2022-12-13  8:53 ` [PATCH 10/14] block: Convert bdrv_is_inserted() to co_wrapper Kevin Wolf
2022-12-13  8:53 ` [PATCH 11/14] block: Convert bdrv_eject() " Kevin Wolf
2022-12-13  8:53 ` [PATCH 12/14] block: convert bdrv_lock_medium in co_wrapper Kevin Wolf
2022-12-13  8:53 ` [PATCH 13/14] block: Convert bdrv_debug_event to co_wrapper_mixed Kevin Wolf
2022-12-13  8:53 ` [PATCH 14/14] block: Rename newly converted BlockDriver IO coroutine functions Kevin Wolf
2022-12-16 17:30   ` Vladimir Sementsov-Ogievskiy
2022-12-15 12:39 ` [PATCH 00/14] block: Move more functions to coroutines Emanuele Giuseppe Esposito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221213085320.95673-7-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.