From: Kevin Wolf <kwolf@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
qemu-block@nongnu.org, hreitz@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper
Date: Fri, 13 Jan 2023 16:51:03 +0100 [thread overview]
Message-ID: <Y8F95z2Z5gprCzlZ@redhat.com> (raw)
In-Reply-To: <c4c1c417-bded-497f-b1bc-41af90d80dab@redhat.com>
Am 19.12.2022 um 13:26 hat Emanuele Giuseppe Esposito geschrieben:
> Am 16/12/2022 um 17:12 schrieb Vladimir Sementsov-Ogievskiy:
> > On 12/13/22 11:53, Kevin Wolf wrote:
> >> --- a/include/block/block_int-common.h
> >> +++ b/include/block/block_int-common.h
> >> @@ -729,7 +729,7 @@ struct BlockDriver {
> >> void (*bdrv_debug_event)(BlockDriverState *bs, BlkdebugEvent
> >> event);
> >> /* io queue for linux-aio */
> >> - void (*bdrv_io_plug)(BlockDriverState *bs);
> >> + void coroutine_fn (*bdrv_io_plug)(BlockDriverState *bs);
> >
> > But you didn't add coroutine_fn to realizations of this callback. Seems,
> > it should be done
>
> This has to be done by Paolo & Alberto Faria work to add missing
> coroutine_fn and various annotations in a systematic way. It has to be
> done using tools like vrc, and not manually because it's not feasible.
> Not covered by this serie.
I didn't want to change your patches too much (and I'm sure it has
nothing at all to do with laziness!), but Vladimir is really right.
Doing the renames in the final patch is a bit sloppy, just as not adding
coroutine_fn is.
I'll fix it for v2 to do all of the changes in the respective patches.
Kevin
next prev parent reply other threads:[~2023-01-13 16:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 8:53 [PATCH 00/14] block: Move more functions to coroutines Kevin Wolf
2022-12-13 8:53 ` [PATCH 01/14] block-coroutine-wrapper: support void functions Kevin Wolf
2022-12-16 14:21 ` Vladimir Sementsov-Ogievskiy
2022-12-13 8:53 ` [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper Kevin Wolf
2022-12-16 14:26 ` Vladimir Sementsov-Ogievskiy
2022-12-19 12:24 ` Emanuele Giuseppe Esposito
2022-12-16 16:12 ` Vladimir Sementsov-Ogievskiy
2022-12-19 12:26 ` Emanuele Giuseppe Esposito
2023-01-13 15:51 ` Kevin Wolf [this message]
2022-12-13 8:53 ` [PATCH 03/14] block: Convert bdrv_io_unplug() " Kevin Wolf
2022-12-13 8:53 ` [PATCH 04/14] block: Rename refresh_total_sectors to bdrv_refresh_total_sectors Kevin Wolf
2022-12-16 16:55 ` Vladimir Sementsov-Ogievskiy
2022-12-13 8:53 ` [PATCH 05/14] block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed Kevin Wolf
2022-12-16 17:19 ` Vladimir Sementsov-Ogievskiy
2022-12-13 8:53 ` [PATCH 06/14] block-backend: use bdrv_getlength instead of blk_getlength Kevin Wolf
2022-12-16 17:22 ` Vladimir Sementsov-Ogievskiy
2022-12-19 12:28 ` Emanuele Giuseppe Esposito
2022-12-13 8:53 ` [PATCH 07/14] block: use bdrv_co_refresh_total_sectors when possible Kevin Wolf
2022-12-16 17:26 ` Vladimir Sementsov-Ogievskiy
2022-12-13 8:53 ` [PATCH 08/14] block: Convert bdrv_get_allocated_file_size() to co_wrapper Kevin Wolf
2022-12-13 8:53 ` [PATCH 09/14] block: Convert bdrv_get_info() to co_wrapper_mixed Kevin Wolf
2022-12-13 8:53 ` [PATCH 10/14] block: Convert bdrv_is_inserted() to co_wrapper Kevin Wolf
2022-12-13 8:53 ` [PATCH 11/14] block: Convert bdrv_eject() " Kevin Wolf
2022-12-13 8:53 ` [PATCH 12/14] block: convert bdrv_lock_medium in co_wrapper Kevin Wolf
2022-12-13 8:53 ` [PATCH 13/14] block: Convert bdrv_debug_event to co_wrapper_mixed Kevin Wolf
2022-12-13 8:53 ` [PATCH 14/14] block: Rename newly converted BlockDriver IO coroutine functions Kevin Wolf
2022-12-16 17:30 ` Vladimir Sementsov-Ogievskiy
2022-12-15 12:39 ` [PATCH 00/14] block: Move more functions to coroutines Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8F95z2Z5gprCzlZ@redhat.com \
--to=kwolf@redhat.com \
--cc=eesposit@redhat.com \
--cc=hreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.