From: Rob Herring <robh@kernel.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, daniel@ffwll.ch,
paul@crapouillou.net, airlied@gmail.com, sam@ravnborg.org
Subject: Re: [PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01
Date: Tue, 13 Dec 2022 08:30:27 -0600 [thread overview]
Message-ID: <20221213143027.GA967686-robh@kernel.org> (raw)
In-Reply-To: <167093911506.912834.5336090745245447936.robh@kernel.org>
On Tue, Dec 13, 2022 at 07:46:32AM -0600, Rob Herring wrote:
>
> On Tue, 13 Dec 2022 09:10:34 +0100, Christophe Branchereau wrote:
> > Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3
> > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit
> > interface.
> >
> > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > ---
> > .../bindings/display/panel/auo,a030jtn01.yaml | 57 +++++++++++++++++++
> > 1 file changed, 57 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dts:22.11-21: Warning (reg_format): /example-0/panel@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
You need a minimal spi bus node in your example.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Cc: devicetree@vger.kernel.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
paul@crapouillou.net, thierry.reding@gmail.com,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01
Date: Tue, 13 Dec 2022 08:30:27 -0600 [thread overview]
Message-ID: <20221213143027.GA967686-robh@kernel.org> (raw)
In-Reply-To: <167093911506.912834.5336090745245447936.robh@kernel.org>
On Tue, Dec 13, 2022 at 07:46:32AM -0600, Rob Herring wrote:
>
> On Tue, 13 Dec 2022 09:10:34 +0100, Christophe Branchereau wrote:
> > Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3
> > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit
> > interface.
> >
> > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > ---
> > .../bindings/display/panel/auo,a030jtn01.yaml | 57 +++++++++++++++++++
> > 1 file changed, 57 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dts:22.11-21: Warning (reg_format): /example-0/panel@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.example.dtb: panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/auo,a030jtn01.yaml
You need a minimal spi bus node in your example.
next prev parent reply other threads:[~2022-12-13 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 8:10 [PATCH 1/2] drm/panel: Add driver for the AUO A030JTN01 TFT LCD Christophe Branchereau
2022-12-13 8:10 ` [PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01 Christophe Branchereau
2022-12-13 13:46 ` Rob Herring
2022-12-13 13:46 ` Rob Herring
2022-12-13 14:30 ` Rob Herring [this message]
2022-12-13 14:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213143027.GA967686-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=cbranchereau@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.