From: "Michael S. Tsirkin" <mst@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Wolfram Sang <wsa@kernel.org>,
asowang@redhat.com, Conghui <conghui.chen@intel.com>,
linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Jian Jun Chen <jian.jun.chen@intel.com>
Subject: Re: [PATCH] MAINTAINERS: Update maintainer list for virtio i2c
Date: Wed, 14 Dec 2022 06:58:29 -0500 [thread overview]
Message-ID: <20221214065417-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221214105642.3xagckvbbgu5mubl@vireshk-i7>
On Wed, Dec 14, 2022 at 04:26:42PM +0530, Viresh Kumar wrote:
> On 14-12-22, 11:20, Wolfram Sang wrote:
> > Dunno if this is really a rule, but if a maintainer steps out and makes
> > sure there is someone to pick up the work, this is more than welcome.
> > Way better than a stale entry in the MAINTAINERS file.
>
> Sure, a stale entry is always bad.
>
> > I mean, it does not limit the chance to have further maintainers, for
> > example. I believe in meritocracy here. Those who do and collaborate,
> > shall get responsibility. If not, then not. We can fix this, too, if
> > needed.
> >
> > What is the reason for your question?
>
> It was a general question that I asked myself and didn't know an
> answer to. I wasn't sure if adding someone to be a maintainer here to
> a driver, which they haven't contributed to until now (at least based
> on open source commits), is right or not, since this isn't a stale
> entry in MAINTAINERS anyway.
>
> An entry as R: would be okay normally IMO, as this makes sure
> interested party is kept aware of the development in the area. An M:
> entry somehow gives a higher level of authority to the person and
> without any prior contributions, it feels tricky at least.
>
> Anyway, I don't have any objection to the patch at least as it was
> primarily developed by Intel engineers.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
If a maintainer acks a patch I generally expect that the patch is good.
If we have a maintainer who's not familiar with the codebase, this
assumption does not hold.
R: would be ok with me.
> --
> viresh
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: asowang@redhat.com, Jian Jun Chen <jian.jun.chen@intel.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, Conghui <conghui.chen@intel.com>
Subject: Re: [PATCH] MAINTAINERS: Update maintainer list for virtio i2c
Date: Wed, 14 Dec 2022 06:58:29 -0500 [thread overview]
Message-ID: <20221214065417-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221214105642.3xagckvbbgu5mubl@vireshk-i7>
On Wed, Dec 14, 2022 at 04:26:42PM +0530, Viresh Kumar wrote:
> On 14-12-22, 11:20, Wolfram Sang wrote:
> > Dunno if this is really a rule, but if a maintainer steps out and makes
> > sure there is someone to pick up the work, this is more than welcome.
> > Way better than a stale entry in the MAINTAINERS file.
>
> Sure, a stale entry is always bad.
>
> > I mean, it does not limit the chance to have further maintainers, for
> > example. I believe in meritocracy here. Those who do and collaborate,
> > shall get responsibility. If not, then not. We can fix this, too, if
> > needed.
> >
> > What is the reason for your question?
>
> It was a general question that I asked myself and didn't know an
> answer to. I wasn't sure if adding someone to be a maintainer here to
> a driver, which they haven't contributed to until now (at least based
> on open source commits), is right or not, since this isn't a stale
> entry in MAINTAINERS anyway.
>
> An entry as R: would be okay normally IMO, as this makes sure
> interested party is kept aware of the development in the area. An M:
> entry somehow gives a higher level of authority to the person and
> without any prior contributions, it feels tricky at least.
>
> Anyway, I don't have any objection to the patch at least as it was
> primarily developed by Intel engineers.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
If a maintainer acks a patch I generally expect that the patch is good.
If we have a maintainer who's not familiar with the codebase, this
assumption does not hold.
R: would be ok with me.
> --
> viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-12-14 12:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 5:36 [PATCH] MAINTAINERS: Update maintainer list for virtio i2c Conghui
2022-12-14 6:31 ` Viresh Kumar
2022-12-14 6:31 ` Viresh Kumar
2022-12-14 10:20 ` Wolfram Sang
2022-12-14 10:56 ` Viresh Kumar
2022-12-14 10:56 ` Viresh Kumar
2022-12-14 11:58 ` Michael S. Tsirkin [this message]
2022-12-14 11:58 ` Michael S. Tsirkin
2022-12-14 12:00 ` Michael S. Tsirkin
2022-12-14 12:00 ` Michael S. Tsirkin
2022-12-27 4:05 ` Chen, Jian Jun
2022-12-27 4:05 ` Chen, Jian Jun
2022-12-27 7:21 ` Michael S. Tsirkin
2022-12-27 7:21 ` Michael S. Tsirkin
2022-12-14 11:37 ` Michael S. Tsirkin
2022-12-14 11:37 ` Michael S. Tsirkin
2022-12-27 4:04 ` Chen, Jian Jun
2022-12-27 4:04 ` Chen, Jian Jun
2022-12-27 7:08 ` Michael S. Tsirkin
2022-12-27 7:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214065417-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=asowang@redhat.com \
--cc=conghui.chen@intel.com \
--cc=jian.jun.chen@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.