* [PATCH] drm/amd/display: fix duplicate assignments
@ 2022-12-15 16:45 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:45 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira
Cc: Arnd Bergmann, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Nicholas Kazlauskas, Charlene Liu,
Alex Hung, Roman Li, Duncan Ma, Aurabindo Pillai, Michael Strauss,
amd-gfx, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The .set_odm_combine callback pointer was added twice, causing
a harmless -Wextra warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
258 | .set_odm_combine = optc314_set_odm_combine,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index f246aab23050..0086cafb0f7a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
.set_dsc_config = optc3_set_dsc_config,
.get_dsc_status = optc2_get_dsc_status,
.set_dwb_source = NULL,
- .set_odm_combine = optc314_set_odm_combine,
.get_optc_source = optc2_get_optc_source,
.set_out_mux = optc3_set_out_mux,
.set_drr_trigger_window = optc3_set_drr_trigger_window,
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: fix duplicate assignments
@ 2022-12-15 16:45 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:45 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira
Cc: Charlene Liu, Arnd Bergmann, Alex Hung, linux-kernel, Pan, Xinhui,
Roman Li, amd-gfx, Nicholas Kazlauskas, Aurabindo Pillai,
Michael Strauss, dri-devel, Daniel Vetter, Alex Deucher,
David Airlie, Christian König, Duncan Ma
From: Arnd Bergmann <arnd@arndb.de>
The .set_odm_combine callback pointer was added twice, causing
a harmless -Wextra warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
258 | .set_odm_combine = optc314_set_odm_combine,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index f246aab23050..0086cafb0f7a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
.set_dsc_config = optc3_set_dsc_config,
.get_dsc_status = optc2_get_dsc_status,
.set_dwb_source = NULL,
- .set_odm_combine = optc314_set_odm_combine,
.get_optc_source = optc2_get_optc_source,
.set_out_mux = optc3_set_out_mux,
.set_drr_trigger_window = optc3_set_drr_trigger_window,
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: fix duplicate assignments
@ 2022-12-15 16:45 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:45 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira
Cc: Charlene Liu, Arnd Bergmann, Alex Hung, linux-kernel, Pan, Xinhui,
Roman Li, amd-gfx, Nicholas Kazlauskas, Aurabindo Pillai,
Michael Strauss, dri-devel, Alex Deucher, Christian König,
Duncan Ma
From: Arnd Bergmann <arnd@arndb.de>
The .set_odm_combine callback pointer was added twice, causing
a harmless -Wextra warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
258 | .set_odm_combine = optc314_set_odm_combine,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index f246aab23050..0086cafb0f7a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
.set_dsc_config = optc3_set_dsc_config,
.get_dsc_status = optc2_get_dsc_status,
.set_dwb_source = NULL,
- .set_odm_combine = optc314_set_odm_combine,
.get_optc_source = optc2_get_optc_source,
.set_out_mux = optc3_set_out_mux,
.set_drr_trigger_window = optc3_set_drr_trigger_window,
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix duplicate assignments
2022-12-15 16:45 ` Arnd Bergmann
(?)
@ 2022-12-15 18:47 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-12-15 18:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Charlene Liu,
Arnd Bergmann, Alex Hung, linux-kernel, Pan, Xinhui, Roman Li,
amd-gfx, Nicholas Kazlauskas, Aurabindo Pillai, Michael Strauss,
dri-devel, Daniel Vetter, Alex Deucher, David Airlie,
Christian König, Duncan Ma
Applied. Thanks!
Alex
On Thu, Dec 15, 2022 at 11:46 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The .set_odm_combine callback pointer was added twice, causing
> a harmless -Wextra warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
> 258 | .set_odm_combine = optc314_set_odm_combine,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
>
> Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index f246aab23050..0086cafb0f7a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
> .set_dsc_config = optc3_set_dsc_config,
> .get_dsc_status = optc2_get_dsc_status,
> .set_dwb_source = NULL,
> - .set_odm_combine = optc314_set_odm_combine,
> .get_optc_source = optc2_get_optc_source,
> .set_out_mux = optc3_set_out_mux,
> .set_drr_trigger_window = optc3_set_drr_trigger_window,
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix duplicate assignments
@ 2022-12-15 18:47 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-12-15 18:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Charlene Liu, Arnd Bergmann, Christian König, Leo Li,
David Airlie, Pan, Xinhui, Rodrigo Siqueira, linux-kernel,
amd-gfx, Roman Li, Alex Hung, Aurabindo Pillai, Michael Strauss,
dri-devel, Daniel Vetter, Alex Deucher, Harry Wentland,
Nicholas Kazlauskas, Duncan Ma
Applied. Thanks!
Alex
On Thu, Dec 15, 2022 at 11:46 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The .set_odm_combine callback pointer was added twice, causing
> a harmless -Wextra warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
> 258 | .set_odm_combine = optc314_set_odm_combine,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
>
> Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index f246aab23050..0086cafb0f7a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
> .set_dsc_config = optc3_set_dsc_config,
> .get_dsc_status = optc2_get_dsc_status,
> .set_dwb_source = NULL,
> - .set_odm_combine = optc314_set_odm_combine,
> .get_optc_source = optc2_get_optc_source,
> .set_out_mux = optc3_set_out_mux,
> .set_drr_trigger_window = optc3_set_drr_trigger_window,
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix duplicate assignments
@ 2022-12-15 18:47 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-12-15 18:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Charlene Liu, Arnd Bergmann, Christian König, Leo Li,
Pan, Xinhui, Rodrigo Siqueira, linux-kernel, amd-gfx, Roman Li,
Alex Hung, Aurabindo Pillai, Michael Strauss, dri-devel,
Alex Deucher, Nicholas Kazlauskas, Duncan Ma
Applied. Thanks!
Alex
On Thu, Dec 15, 2022 at 11:46 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The .set_odm_combine callback pointer was added twice, causing
> a harmless -Wextra warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: error: initialized field overwritten [-Werror=override-init]
> 258 | .set_odm_combine = optc314_set_odm_combine,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:258:36: note: (near initialization for 'dcn314_tg_funcs.set_odm_combine')
>
> Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index f246aab23050..0086cafb0f7a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -241,7 +241,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = {
> .set_dsc_config = optc3_set_dsc_config,
> .get_dsc_status = optc2_get_dsc_status,
> .set_dwb_source = NULL,
> - .set_odm_combine = optc314_set_odm_combine,
> .get_optc_source = optc2_get_optc_source,
> .set_out_mux = optc3_set_out_mux,
> .set_drr_trigger_window = optc3_set_drr_trigger_window,
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-15 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 16:45 [PATCH] drm/amd/display: fix duplicate assignments Arnd Bergmann
2022-12-15 16:45 ` Arnd Bergmann
2022-12-15 16:45 ` Arnd Bergmann
2022-12-15 18:47 ` Alex Deucher
2022-12-15 18:47 ` Alex Deucher
2022-12-15 18:47 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.