* [PATCH] reset: ti-sci: fix compile test dependencies
@ 2022-12-15 17:00 Arnd Bergmann
2022-12-15 17:08 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2022-12-15 17:00 UTC (permalink / raw)
To: Philipp Zabel, Nishanth Menon; +Cc: Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The SCI reset driver can be compile testing on targets that
do not support the SCI firmware, but it fails to link when
the firmware driver is built as a module, and the reset driver
is built-in:
arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'
Prevent this configuration by limiting the compile test
to configurations without SCI firmware.
Fixes: a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index de176c2fbad9..2a52c990d4fe 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -257,7 +257,7 @@ config RESET_SUNXI
config RESET_TI_SCI
tristate "TI System Control Interface (TI-SCI) reset driver"
- depends on TI_SCI_PROTOCOL || COMPILE_TEST
+ depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
help
This enables the reset driver support over TI System Control Interface
available on some new TI's SoCs. If you wish to use reset resources
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] reset: ti-sci: fix compile test dependencies
2022-12-15 17:00 [PATCH] reset: ti-sci: fix compile test dependencies Arnd Bergmann
@ 2022-12-15 17:08 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-12-15 17:08 UTC (permalink / raw)
To: Arnd Bergmann, Philipp Zabel, Nishanth Menon; +Cc: Arnd Bergmann, linux-kernel
On 12/15/22 09:00, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The SCI reset driver can be compile testing on targets that
> do not support the SCI firmware, but it fails to link when
> the firmware driver is built as a module, and the reset driver
> is built-in:
>
> arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
> reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'
>
> Prevent this configuration by limiting the compile test
> to configurations without SCI firmware.
>
> Fixes: a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
https://lore.kernel.org/lkml/20221030055636.3139-1-rdunlap@infradead.org/
> ---
> drivers/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index de176c2fbad9..2a52c990d4fe 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -257,7 +257,7 @@ config RESET_SUNXI
>
> config RESET_TI_SCI
> tristate "TI System Control Interface (TI-SCI) reset driver"
> - depends on TI_SCI_PROTOCOL || COMPILE_TEST
> + depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
> help
> This enables the reset driver support over TI System Control Interface
> available on some new TI's SoCs. If you wish to use reset resources
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-15 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 17:00 [PATCH] reset: ti-sci: fix compile test dependencies Arnd Bergmann
2022-12-15 17:08 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.