From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Miaoqian Lin <linmq006@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marc Zyngier <maz@kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: nomadik: include linux/seq_file.h
Date: Thu, 15 Dec 2022 18:00:57 +0100 [thread overview]
Message-ID: <20221215170103.2349282-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
In some randconfig builds, the missing #include causes a
build failure:
drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
| ^~~~~~~~~~
| bstr_printf
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index f7d02513d8cc..1d8e36c2785d 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -17,6 +17,7 @@
#include <linux/gpio/driver.h>
#include <linux/spinlock.h>
#include <linux/interrupt.h>
+#include <linux/seq_file.h>
#include <linux/slab.h>
#include <linux/of_device.h>
#include <linux/of_address.h>
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Miaoqian Lin <linmq006@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marc Zyngier <maz@kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: nomadik: include linux/seq_file.h
Date: Thu, 15 Dec 2022 18:00:57 +0100 [thread overview]
Message-ID: <20221215170103.2349282-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
In some randconfig builds, the missing #include causes a
build failure:
drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
| ^~~~~~~~~~
| bstr_printf
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index f7d02513d8cc..1d8e36c2785d 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -17,6 +17,7 @@
#include <linux/gpio/driver.h>
#include <linux/spinlock.h>
#include <linux/interrupt.h>
+#include <linux/seq_file.h>
#include <linux/slab.h>
#include <linux/of_device.h>
#include <linux/of_address.h>
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-12-15 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 17:00 Arnd Bergmann [this message]
2022-12-15 17:00 ` [PATCH] pinctrl: nomadik: include linux/seq_file.h Arnd Bergmann
2022-12-15 17:16 ` Andy Shevchenko
2022-12-15 17:16 ` Andy Shevchenko
2022-12-28 8:52 ` Andy Shevchenko
2022-12-28 8:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215170103.2349282-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.