From: Ayan Kumar Halder <ayan.kumar.halder@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: <sstabellini@kernel.org>, <stefano.stabellini@amd.com>,
<julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
<bertrand.marquis@arm.com>,
Ayan Kumar Halder <ayan.kumar.halder@amd.com>
Subject: [XEN v1 7/9] xen/arm: Restrict zeroeth_table_offset for ARM_64
Date: Thu, 15 Dec 2022 19:32:43 +0000 [thread overview]
Message-ID: <20221215193245.48314-8-ayan.kumar.halder@amd.com> (raw)
In-Reply-To: <20221215193245.48314-1-ayan.kumar.halder@amd.com>
zeroeth_table_offset is not accessed for ARM_32.
This is a left over of the following commit
"
commit 5fa6e9abfb11
Author: Ian Campbell <ian.campbell@citrix.com>
Date: Thu Sep 18 01:09:48 2014 +0100
xen: arm: Implement variable levels in dump_pt_walk
"
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@amd.com>
---
xen/arch/arm/include/asm/lpae.h | 10 ++++++++++
xen/arch/arm/mm.c | 4 ++++
2 files changed, 14 insertions(+)
diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h
index 3fdd5d0de2..35769debf9 100644
--- a/xen/arch/arm/include/asm/lpae.h
+++ b/xen/arch/arm/include/asm/lpae.h
@@ -161,6 +161,7 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
#define lpae_set_mfn(pte, mfn) ((pte).walk.base = mfn_x(mfn))
/* Generate an array @var containing the offset for each level from @addr */
+#ifdef CONFIG_ARM_64
#define DECLARE_OFFSETS(var, addr) \
const unsigned int var[4] = { \
zeroeth_table_offset(addr), \
@@ -168,6 +169,15 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level)
second_table_offset(addr), \
third_table_offset(addr) \
}
+#else
+#define DECLARE_OFFSETS(var, addr) \
+ const unsigned int var[4] = { \
+ 0, \
+ first_table_offset(addr), \
+ second_table_offset(addr), \
+ third_table_offset(addr) \
+ }
+#endif
/*
* Standard entry type that we'll use to build Xen's own pagetables.
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 630175276f..be939fb106 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -184,7 +184,11 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" };
const mfn_t root_mfn = maddr_to_mfn(ttbr);
const unsigned int offsets[4] = {
+#ifdef CONFIG_ARM_64
zeroeth_table_offset(addr),
+#else
+ 0,
+#endif
first_table_offset(addr),
second_table_offset(addr),
third_table_offset(addr)
--
2.17.1
next prev parent reply other threads:[~2022-12-15 19:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 19:32 [XEN v1 0/9] Add support for 32 bit physical address Ayan Kumar Halder
2022-12-15 19:32 ` [XEN v1 1/9] xen/arm: Remove the extra assignment Ayan Kumar Halder
2022-12-16 7:56 ` Jan Beulich
2022-12-16 9:41 ` Julien Grall
2022-12-15 19:32 ` [XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t Ayan Kumar Halder
2022-12-16 9:51 ` Julien Grall
2022-12-17 0:46 ` Stefano Stabellini
2022-12-17 8:42 ` Julien Grall
2022-12-22 23:20 ` Stefano Stabellini
2022-12-23 10:01 ` Ayan Kumar Halder
2022-12-23 10:17 ` Julien Grall
2023-01-04 23:56 ` Stefano Stabellini
2022-12-15 19:32 ` [XEN v1 3/9] xen/arm: Always use 'u64' instead of 'paddr_t' for address and size in DT Ayan Kumar Halder
2022-12-16 9:57 ` Julien Grall
2022-12-16 10:49 ` Ayan Kumar Halder
2022-12-16 11:12 ` Julien Grall
2022-12-16 11:13 ` Julien Grall
2022-12-15 19:32 ` [XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t Ayan Kumar Halder
2022-12-15 19:32 ` [XEN v1 5/9] xen/arm: Use 'PRIpaddr' to display 'paddr_t' variable Ayan Kumar Halder
2022-12-15 19:32 ` [XEN v1 6/9] xen/arm: Use 'u64' to represent 'unsigned long long' Ayan Kumar Halder
2022-12-16 10:04 ` Julien Grall
2022-12-15 19:32 ` Ayan Kumar Halder [this message]
2022-12-15 22:08 ` [XEN v1 7/9] xen/arm: Restrict zeroeth_table_offset for ARM_64 Julien Grall
2022-12-15 19:32 ` [XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr Ayan Kumar Halder
2022-12-16 10:23 ` Julien Grall
2022-12-20 15:24 ` Ayan Kumar Halder
2022-12-20 16:22 ` Julien Grall
2022-12-15 19:32 ` [XEN v1 9/9] xen/arm: Introduce ARM_PA_32 to support 32 bit physical address Ayan Kumar Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215193245.48314-8-ayan.kumar.halder@amd.com \
--to=ayan.kumar.halder@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.