From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
Jan-Benedict Glaw <jbglaw@lug-owl.de>
Subject: Re: [PATCH v2] powerpc: Pass correct CPU reference to assembler
Date: Fri, 16 Dec 2022 11:18:21 -0600 [thread overview]
Message-ID: <20221216171821.GA25951@gate.crashing.org> (raw)
In-Reply-To: <01fe73614988e2402a7526fb6b6e903bc3777bb5.1671179743.git.christophe.leroy@csgroup.eu>
Hi!
On Fri, Dec 16, 2022 at 09:35:50AM +0100, Christophe Leroy wrote:
> The problem comes from the fact that CONFIG_PPC_E500MC is selected for
> both the e500mc (32 bits) and the e5500 (64 bits), and therefore the
> following makefile rule is wrong:
>
> cpu-as-$(CONFIG_PPC_E500MC) += $(call as-option,-Wa$(comma)-me500mc)
Yes.
> Today we have CONFIG_TARGET_CPU which provides the identification of the
> expected CPU, it is used for GCC. Use it as well for the assembler.
Why do you use -Wa, at all for this? The compiler should already pass
proper options always!
> +cpu-as-$(CONFIG_PPC_BOOK3S_64) += $(call as-option,-Wa$(comma)-many)
What is this for? Using -many is a huge step back, it hides many
problems :-(
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Jan-Benedict Glaw <jbglaw@lug-owl.de>
Subject: Re: [PATCH v2] powerpc: Pass correct CPU reference to assembler
Date: Fri, 16 Dec 2022 11:18:21 -0600 [thread overview]
Message-ID: <20221216171821.GA25951@gate.crashing.org> (raw)
In-Reply-To: <01fe73614988e2402a7526fb6b6e903bc3777bb5.1671179743.git.christophe.leroy@csgroup.eu>
Hi!
On Fri, Dec 16, 2022 at 09:35:50AM +0100, Christophe Leroy wrote:
> The problem comes from the fact that CONFIG_PPC_E500MC is selected for
> both the e500mc (32 bits) and the e5500 (64 bits), and therefore the
> following makefile rule is wrong:
>
> cpu-as-$(CONFIG_PPC_E500MC) += $(call as-option,-Wa$(comma)-me500mc)
Yes.
> Today we have CONFIG_TARGET_CPU which provides the identification of the
> expected CPU, it is used for GCC. Use it as well for the assembler.
Why do you use -Wa, at all for this? The compiler should already pass
proper options always!
> +cpu-as-$(CONFIG_PPC_BOOK3S_64) += $(call as-option,-Wa$(comma)-many)
What is this for? Using -many is a huge step back, it hides many
problems :-(
Segher
next prev parent reply other threads:[~2022-12-16 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 8:35 [PATCH v2] powerpc: Pass correct CPU reference to assembler Christophe Leroy
2022-12-16 8:35 ` Christophe Leroy
2022-12-16 17:18 ` Segher Boessenkool [this message]
2022-12-16 17:18 ` Segher Boessenkool
2022-12-16 17:57 ` Christophe Leroy
2022-12-16 17:57 ` Christophe Leroy
2022-12-16 18:10 ` Segher Boessenkool
2022-12-16 18:10 ` Segher Boessenkool
2022-12-17 0:59 ` Pali Rohár
2022-12-17 0:59 ` Pali Rohár
2022-12-17 1:10 ` Pali Rohár
2022-12-17 1:10 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216171821.GA25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jbglaw@lug-owl.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.