All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	linux-doc@vger.kernel.org, corbet@lwn.net, cohuck@redhat.com,
	virtualization@lists.linux-foundation.org, jasowang@redhat.com,
	kernel@collabora.com
Subject: Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux
Date: Mon, 19 Dec 2022 01:20:14 -0500	[thread overview]
Message-ID: <20221219011647-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87v8oqsq6k.fsf@rcn-XPS-13-9305.i-did-not-set--mail-host-address--so-tickle-me>

On Tue, Oct 11, 2022 at 10:46:43AM +0200, Ricardo Cañuelo wrote:
> >> +It's at this stage that the virtqueues will be allocated and configured
> >> +by calling the appropriate ``virtio_find`` helper function, such as
> >> +virtio_find_single_vq() or virtio_find_vqs(), which will end up
> >> +calling a transport-specific ``find_vqs`` method.
> >> +
> >
> > Looks like the wording at the beginning confuses me, so better say:
> >
> > ---- >8 ----
> > diff --git a/Documentation/driver-api/virtio/virtio.rst b/Documentation/driver-api/virtio/virtio.rst
> > index 07fd2d7c51e689..7947b4ca690efd 100644
> > --- a/Documentation/driver-api/virtio/virtio.rst
> > +++ b/Documentation/driver-api/virtio/virtio.rst
> > @@ -123,10 +123,10 @@ When the device is registered to the virtio bus the kernel will look
> >  for a driver in the bus that can handle the device and call that
> >  driver's ``probe`` method.
> 
> I think this is a matter of style as well, maybe a native speaker can
> pitch in about the correctness of it.
> 
> Cheers,
> Ricardo

I think I agree with this comment.  This seems minor enough so I applied
the patch for now. Bagas would you like to post your suggestion as a patch on
top? Would be appreciated. Thanks!

-- 
MST


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: corbet@lwn.net, cohuck@redhat.com, linux-doc@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	kernel@collabora.com
Subject: Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux
Date: Mon, 19 Dec 2022 01:20:14 -0500	[thread overview]
Message-ID: <20221219011647-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87v8oqsq6k.fsf@rcn-XPS-13-9305.i-did-not-set--mail-host-address--so-tickle-me>

On Tue, Oct 11, 2022 at 10:46:43AM +0200, Ricardo Cañuelo wrote:
> >> +It's at this stage that the virtqueues will be allocated and configured
> >> +by calling the appropriate ``virtio_find`` helper function, such as
> >> +virtio_find_single_vq() or virtio_find_vqs(), which will end up
> >> +calling a transport-specific ``find_vqs`` method.
> >> +
> >
> > Looks like the wording at the beginning confuses me, so better say:
> >
> > ---- >8 ----
> > diff --git a/Documentation/driver-api/virtio/virtio.rst b/Documentation/driver-api/virtio/virtio.rst
> > index 07fd2d7c51e689..7947b4ca690efd 100644
> > --- a/Documentation/driver-api/virtio/virtio.rst
> > +++ b/Documentation/driver-api/virtio/virtio.rst
> > @@ -123,10 +123,10 @@ When the device is registered to the virtio bus the kernel will look
> >  for a driver in the bus that can handle the device and call that
> >  driver's ``probe`` method.
> 
> I think this is a matter of style as well, maybe a native speaker can
> pitch in about the correctness of it.
> 
> Cheers,
> Ricardo

I think I agree with this comment.  This seems minor enough so I applied
the patch for now. Bagas would you like to post your suggestion as a patch on
top? Would be appreciated. Thanks!

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-12-19  6:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  6:43 [RESEND PATCH v5 0/1] docs: driver-api: virtio: virtio on Linux Ricardo Cañuelo
2022-10-10  6:43 ` Ricardo Cañuelo
2022-10-10  6:43 ` [RESEND PATCH v5 1/1] " Ricardo Cañuelo
2022-10-10  6:43   ` Ricardo Cañuelo
2022-10-10 13:04   ` Bagas Sanjaya
2022-10-10 13:43     ` Cornelia Huck
2022-10-10 13:43       ` Cornelia Huck
2022-10-10 17:11       ` Michael S. Tsirkin
2022-10-10 17:11         ` Michael S. Tsirkin
2022-10-11  6:51         ` Cornelia Huck
2022-10-11  6:51           ` Cornelia Huck
2022-10-11  7:20           ` Bagas Sanjaya
2022-10-11  7:57             ` Cornelia Huck
2022-10-11  7:57               ` Cornelia Huck
2022-10-11  8:30               ` Bagas Sanjaya
2022-10-11  8:46     ` Ricardo Cañuelo
2022-10-11  8:46       ` Ricardo Cañuelo
2022-12-19  6:20       ` Michael S. Tsirkin [this message]
2022-12-19  6:20         ` Michael S. Tsirkin
2022-12-19  8:38         ` Bagas Sanjaya
2022-12-19 10:53           ` Michael S. Tsirkin
2022-12-19 10:53             ` Michael S. Tsirkin
2022-12-20  8:13             ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221219011647-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=bagasdotme@gmail.com \
    --cc=cohuck@redhat.com \
    --cc=corbet@lwn.net \
    --cc=jasowang@redhat.com \
    --cc=kernel@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.