* [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
@ 2022-12-07 12:48 Neal Frager via buildroot
2022-12-11 17:03 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Neal Frager via buildroot @ 2022-12-07 12:48 UTC (permalink / raw)
To: buildroot; +Cc: michal.simek, luca.ceresoli, thomas.petazzoni, Neal Frager
The Linux DTS name has changed for the zynqmp_kria_kv260 with Xilinx 2022.2.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
configs/zynqmp_kria_kv260_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
index df01ad30b8..aef67b3cb4 100644
--- a/configs/zynqmp_kria_kv260_defconfig
+++ b/configs/zynqmp_kria_kv260_defconfig
@@ -8,7 +8,7 @@ BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,linux-xlnx,xlnx_rebase_v5.15_LTS_2022.2)/xlnx_rebase_v5.15_LTS_2022.2.tar.gz"
BR2_LINUX_KERNEL_DEFCONFIG="xilinx_zynqmp"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/smk-k26-revA-sck-kv-g-revB"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/zynqmp-smk-k26-revA-sck-kv-g-revB"
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
2022-12-07 12:48 [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name Neal Frager via buildroot
@ 2022-12-11 17:03 ` Thomas Petazzoni via buildroot
2022-12-11 17:55 ` Frager, Neal via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-12-11 17:03 UTC (permalink / raw)
To: Neal Frager via buildroot; +Cc: luca.ceresoli, michal.simek, Neal Frager
Hello,
On Wed, 7 Dec 2022 05:48:55 -0700
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> The Linux DTS name has changed for the zynqmp_kria_kv260 with Xilinx 2022.2.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> configs/zynqmp_kria_kv260_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
> index df01ad30b8..aef67b3cb4 100644
> --- a/configs/zynqmp_kria_kv260_defconfig
> +++ b/configs/zynqmp_kria_kv260_defconfig
> @@ -8,7 +8,7 @@ BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,linux-xlnx,xlnx_rebase_v5.15_LTS_2022.2)/xlnx_rebase_v5.15_LTS_2022.2.tar.gz"
> BR2_LINUX_KERNEL_DEFCONFIG="xilinx_zynqmp"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> -BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/smk-k26-revA-sck-kv-g-revB"
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/zynqmp-smk-k26-revA-sck-kv-g-revB"
Do you test your patches before sending them? Because it's quite
worrying to have some many fixes.
And in fact, it seems this patch is also broken: there is no Device
Tree named zynqmp-smk-k26-revA-sck-kv-g-revB.dts:
$ make zynqmp_kria_kv260_defconfig
$ make linux-patch
$ find output/build/linux-custom/ -name 'zynqmp-smk-k26-revA-sck-kv-g-revB.dts'
$
So unless I'm wrong, this patch doesn't look correct.
Please make sure to do a full build of your defconfigs (make clean;
make foobar_defconfig; make) before sending an update to your defconfig.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
2022-12-11 17:03 ` Thomas Petazzoni via buildroot
@ 2022-12-11 17:55 ` Frager, Neal via buildroot
2022-12-12 13:47 ` Frager, Neal via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Frager, Neal via buildroot @ 2022-12-11 17:55 UTC (permalink / raw)
To: Thomas Petazzoni, Neal Frager via buildroot
Cc: luca.ceresoli@bootlin.com, Simek, Michal
Hello Thomas,
> The Linux DTS name has changed for the zynqmp_kria_kv260 with Xilinx 2022.2.
>
> Signed-off-by: Neal Frager <mailto:neal.frager@amd.com>
> ---
> configs/zynqmp_kria_kv260_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/zynqmp_kria_kv260_defconfig
> b/configs/zynqmp_kria_kv260_defconfig
> index df01ad30b8..aef67b3cb4 100644
> --- a/configs/zynqmp_kria_kv260_defconfig
> +++ b/configs/zynqmp_kria_kv260_defconfig
> @@ -8,7 +8,7 @@ BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,linux-xlnx,xlnx_rebase_v5.15_LTS_2022.2)/xlnx_rebase_v5.15_LTS_2022.2.tar.gz"
> BR2_LINUX_KERNEL_DEFCONFIG="xilinx_zynqmp"
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> -BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/smk-k26-revA-sck-kv-g-revB"
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/zynqmp-smk-k26-revA-sck-kv-g-revB"
> Do you test your patches before sending them? Because it's quite worrying to have some many fixes.
I understand, and I promise to do a better job in the future to diligently test both building and running on hardware before submitting patches in the future.
> And in fact, it seems this patch is also broken: there is no Device Tree named zynqmp-smk-k26-revA-sck-kv-g-revB.dts:
> $ make zynqmp_kria_kv260_defconfig
> $ make linux-patch
> $ find output/build/linux-custom/ -name 'zynqmp-smk-k26-revA-sck-kv-g-revB.dts'
I have done a full build and run test on all of these patches you have been committing, including this one.
If you look in the dts Makefile for Xilinx zynqmp and versal products, you will find the following:
zynqmp-sm-k26-revA-sck-kv-g-revA-dtbs := zynqmp-sm-k26-revA.dtb zynqmp-sck-kv-g-revA.dtbo
zynqmp-sm-k26-revA-sck-kv-g-revB-dtbs := zynqmp-sm-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
zynqmp-smk-k26-revA-sck-kv-g-revA-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revA.dtbo
zynqmp-smk-k26-revA-sck-kv-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
zynqmp-sm-k26-revA-sck-kr-g-revA-dtbs := zynqmp-sm-k26-revA.dtb zynqmp-sck-kr-g-revA.dtbo
zynqmp-sm-k26-revA-sck-kr-g-revB-dtbs := zynqmp-sm-k26-revA.dtb zynqmp-sck-kr-g-revB.dtbo
zynqmp-smk-k26-revA-sck-kr-g-revA-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kr-g-revA.dtbo
zynqmp-smk-k26-revA-sck-kr-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kr-g-revB.dtbo
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-sm-k26-revA-sck-kv-g-revA.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-sm-k26-revA-sck-kv-g-revB.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kv-g-revA.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kv-g-revB.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-sm-k26-revA-sck-kr-g-revA.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-sm-k26-revA-sck-kr-g-revB.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kr-g-revA.dtb
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kr-g-revB.dtb
You can see this in the Makefile here:
https://github.com/Xilinx/linux-xlnx/blob/xlnx_rebase_v5.15_2022.2/arch/arm64/boot/dts/xilinx/Makefile
Essentially, the Kria Starter Kits have a SOM board (sm-k26-revA) and a carrier board (sck-kv-g-revX for kv260 and sck-kr-g-revX for kr260).
With this Makefile, Linux is able to apply the carrier board device tree as an overlay for the SOM board to generate the complete device tree for the starter kit.
This is what is currently missing in u-boot, and why u-boot requires an extra script for creating the proper device tree for the u-boot.itb. Linux does not require this.
I apologize for submitting bugs into buildroot with my 2022.2 bump patches for zynqmp and I promise to do a better job in the future.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
2022-12-11 17:55 ` Frager, Neal via buildroot
@ 2022-12-12 13:47 ` Frager, Neal via buildroot
2022-12-19 12:36 ` Luca Ceresoli via buildroot
0 siblings, 1 reply; 5+ messages in thread
From: Frager, Neal via buildroot @ 2022-12-12 13:47 UTC (permalink / raw)
To: Thomas Petazzoni, Neal Frager via buildroot
Cc: luca.ceresoli@bootlin.com, Simek, Michal
Hi Thomas,
> And in fact, it seems this patch is also broken: there is no Device Tree named zynqmp-smk-k26-revA-sck-kv-g-revB.dts:
> $ make zynqmp_kria_kv260_defconfig
> $ make linux-patch
> $ find output/build/linux-custom/ -name 'zynqmp-smk-k26-revA-sck-kv-g-revB.dts'
> I have done a full build and run test on all of these patches you have been committing, including this one.
In case my last message was not absolutely clear, the mistake I made when updating the zynqmp_kria_kv260_defconfig from Xilinx 2022.1 to 2022.2 was not handling the device tree name change.
2022.1 used smk-k26-revA-sck-kv-g-revB.dtb
https://github.com/Xilinx/linux-xlnx/blob/xlnx_rebase_v5.15_2022.1/arch/arm64/boot/dts/xilinx/Makefile
smk-k26-revA-sck-kv-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
dtb-$(CONFIG_ARCH_ZYNQMP) += smk-k26-revA-sck-kv-g-revB.dtb
2022.2 changed to zynqmp-smk-k26-revA-sck-kv-g-revB.dtb
https://github.com/Xilinx/linux-xlnx/blob/xlnx_rebase_v5.15_2022.2/arch/arm64/boot/dts/xilinx/Makefile
zynqmp-smk-k26-revA-sck-kv-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kv-g-revB.dtb
In both cases, the defconfig remains the default zynqmp xilinx_zynqmp_virt_defconfig which is used for all zynqmp builds.
In the future, I will be more thorough to fully check and test the details before bumping to a new software version. I have learned my lesson that assuming things will stay the same is a mistake.
Please let me know if this is clear and if you have any questions. Thank you for your understanding.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name
2022-12-12 13:47 ` Frager, Neal via buildroot
@ 2022-12-19 12:36 ` Luca Ceresoli via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli via buildroot @ 2022-12-19 12:36 UTC (permalink / raw)
To: Frager, Neal; +Cc: Simek, Michal, Thomas Petazzoni, Neal Frager via buildroot
On Mon, 12 Dec 2022 13:47:29 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> Hi Thomas,
>
> > And in fact, it seems this patch is also broken: there is no Device Tree named zynqmp-smk-k26-revA-sck-kv-g-revB.dts:
>
> > $ make zynqmp_kria_kv260_defconfig
> > $ make linux-patch
> > $ find output/build/linux-custom/ -name 'zynqmp-smk-k26-revA-sck-kv-g-revB.dts'
>
> > I have done a full build and run test on all of these patches you have been committing, including this one.
>
> In case my last message was not absolutely clear, the mistake I made when updating the zynqmp_kria_kv260_defconfig from Xilinx 2022.1 to 2022.2 was not handling the device tree name change.
>
> 2022.1 used smk-k26-revA-sck-kv-g-revB.dtb
> https://github.com/Xilinx/linux-xlnx/blob/xlnx_rebase_v5.15_2022.1/arch/arm64/boot/dts/xilinx/Makefile
> smk-k26-revA-sck-kv-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
> dtb-$(CONFIG_ARCH_ZYNQMP) += smk-k26-revA-sck-kv-g-revB.dtb
>
> 2022.2 changed to zynqmp-smk-k26-revA-sck-kv-g-revB.dtb
> https://github.com/Xilinx/linux-xlnx/blob/xlnx_rebase_v5.15_2022.2/arch/arm64/boot/dts/xilinx/Makefile
> zynqmp-smk-k26-revA-sck-kv-g-revB-dtbs := zynqmp-smk-k26-revA.dtb zynqmp-sck-kv-g-revB.dtbo
> dtb-$(CONFIG_ARCH_ZYNQMP) += zynqmp-smk-k26-revA-sck-kv-g-revB.dtb
>
> In both cases, the defconfig remains the default zynqmp xilinx_zynqmp_virt_defconfig which is used for all zynqmp builds.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-19 12:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 12:48 [Buildroot] [PATCH v1 1/1] configs/zynqmp_kria_kv260_defconfig: fix linux dts name Neal Frager via buildroot
2022-12-11 17:03 ` Thomas Petazzoni via buildroot
2022-12-11 17:55 ` Frager, Neal via buildroot
2022-12-12 13:47 ` Frager, Neal via buildroot
2022-12-19 12:36 ` Luca Ceresoli via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.