All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Michael Walle <michael@walle.cc>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Mauro Lima <mauro.lima@eclypsium.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone
Date: Tue, 20 Dec 2022 16:57:01 +0100	[thread overview]
Message-ID: <20221220165701.5696df1a@xps-13> (raw)
In-Reply-To: <cae6328b-5204-a1ab-810d-8fb64e466453@linaro.org>

Hi Tudor,

tudor.ambarus@linaro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:

> Hi, Arnd,
> 
> On 20.12.2022 16:13, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
> > fails to build, as it includes the shared CFI header:
> > 
> > include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp]
> >     62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> > 
> > linux/mtd/spi-nor.h does not actually need to include cfi.h, so
> > remove the inclusion here to fix the warning. This uncovers a
> > missing #include in spi-nor/core.c so add that there to
> > prevent a different build issue.
> > 
> > Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> 
> Looks good to me. I'll let the linux-0day bot run over it and apply it
> once -rc1 is out.

The issue sometimes produces build errors, shall I send it through a
fixes PR instead?

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Michael Walle <michael@walle.cc>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Mauro Lima <mauro.lima@eclypsium.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone
Date: Tue, 20 Dec 2022 16:57:01 +0100	[thread overview]
Message-ID: <20221220165701.5696df1a@xps-13> (raw)
In-Reply-To: <cae6328b-5204-a1ab-810d-8fb64e466453@linaro.org>

Hi Tudor,

tudor.ambarus@linaro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:

> Hi, Arnd,
> 
> On 20.12.2022 16:13, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
> > fails to build, as it includes the shared CFI header:
> > 
> > include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp]
> >     62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> > 
> > linux/mtd/spi-nor.h does not actually need to include cfi.h, so
> > remove the inclusion here to fix the warning. This uncovers a
> > missing #include in spi-nor/core.c so add that there to
> > prevent a different build issue.
> > 
> > Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> 
> Looks good to me. I'll let the linux-0day bot run over it and apply it
> once -rc1 is out.

The issue sometimes produces build errors, shall I send it through a
fixes PR instead?

Thanks,
Miquèl

  reply	other threads:[~2022-12-20 15:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 14:13 [PATCH] [v2] mtd: cfi: allow building spi-intel standalone Arnd Bergmann
2022-12-20 14:13 ` Arnd Bergmann
2022-12-20 14:19 ` Mika Westerberg
2022-12-20 14:19   ` Mika Westerberg
2022-12-20 15:44 ` Tudor Ambarus
2022-12-20 15:44   ` Tudor Ambarus
2022-12-20 15:57   ` Miquel Raynal [this message]
2022-12-20 15:57     ` Miquel Raynal
2022-12-21  6:49     ` Tudor Ambarus
2022-12-21  6:49       ` Tudor Ambarus
2022-12-26 14:22       ` Tudor Ambarus
2022-12-26 14:22         ` Tudor Ambarus
2022-12-30 12:50         ` Miquel Raynal
2022-12-30 12:50           ` Miquel Raynal
2022-12-21 16:47 ` Tokunori Ikegami
2022-12-21 16:47   ` Tokunori Ikegami
2022-12-26 14:14 ` Pratyush Yadav
2022-12-26 14:14   ` Pratyush Yadav
2023-01-02 11:17 ` Miquel Raynal
2023-01-02 11:17   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220165701.5696df1a@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Takahiro.Kuwano@infineon.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mauro.lima@eclypsium.com \
    --cc=michael@walle.cc \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.