From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21
Date: Tue, 20 Dec 2022 12:19:48 -0600 [thread overview]
Message-ID: <20221220181948.GA828243-robh@kernel.org> (raw)
In-Reply-To: <20221217183806.bvo5vypm6axycdte@pengutronix.de>
On Sat, Dec 17, 2022 at 07:38:06PM +0100, Uwe Kleine-König wrote:
> On Fri, Dec 16, 2022 at 05:57:58PM -0600, Rob Herring wrote:
> > On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > Changes since v2:
> > >
> > > - added allOf as Krzysztof requested
> > > - reworked driver based on Philipp's comments
> > > (improved error handling, different selects, moved driver to a subdirectory,
> > > header sorting, drm_err instead of DRM_ERROR, inlined
> > > imx_lcdc_check_mode_change, make use of dev_err_probe())
> > >
> > > Krzysztof also pointed out that we're now having two compatibles for a
> > > single hardware. Admittedly this is unusual, but this is the chance that
> > > the (bad) compatible identifier imx21-fb gets deprecated. The hardware
> > > is called LCDC and only the linux (framebuffer) driver is called imxfb.
> >
> > The problem is you can't have firmware (with the DTB) that supports
> > both. Well, you can if you want to have some firmware setting that
> > selects which one. Otherwise, it's really an OS problem to decide what
> > to use.
>
> I don't understand what you intend to say here. The same applies if the
> compatible is the same for both binding alternatives, isn't it?
Only if you have both nodes in the DT and both enabled. But 2 enabled
nodes at the same address is also a dtc warning, so I was assuming you
didn't do that.
> Do you consider a firmware problem better or an OS problem?
The OS created the problem, so they get to keep it. But a PC BIOS is
full of OS compatibility switches, so...
In the end, it's the platforms' decision really. I just want what the
implications of having 2 compatibles are to be understood.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21
Date: Tue, 20 Dec 2022 12:19:48 -0600 [thread overview]
Message-ID: <20221220181948.GA828243-robh@kernel.org> (raw)
In-Reply-To: <20221217183806.bvo5vypm6axycdte@pengutronix.de>
On Sat, Dec 17, 2022 at 07:38:06PM +0100, Uwe Kleine-König wrote:
> On Fri, Dec 16, 2022 at 05:57:58PM -0600, Rob Herring wrote:
> > On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > Changes since v2:
> > >
> > > - added allOf as Krzysztof requested
> > > - reworked driver based on Philipp's comments
> > > (improved error handling, different selects, moved driver to a subdirectory,
> > > header sorting, drm_err instead of DRM_ERROR, inlined
> > > imx_lcdc_check_mode_change, make use of dev_err_probe())
> > >
> > > Krzysztof also pointed out that we're now having two compatibles for a
> > > single hardware. Admittedly this is unusual, but this is the chance that
> > > the (bad) compatible identifier imx21-fb gets deprecated. The hardware
> > > is called LCDC and only the linux (framebuffer) driver is called imxfb.
> >
> > The problem is you can't have firmware (with the DTB) that supports
> > both. Well, you can if you want to have some firmware setting that
> > selects which one. Otherwise, it's really an OS problem to decide what
> > to use.
>
> I don't understand what you intend to say here. The same applies if the
> compatible is the same for both binding alternatives, isn't it?
Only if you have both nodes in the DT and both enabled. But 2 enabled
nodes at the same address is also a dtc warning, so I was assuming you
didn't do that.
> Do you consider a firmware problem better or an OS problem?
The OS created the problem, so they get to keep it. But a PC BIOS is
full of OS compatibility switches, so...
In the end, it's the platforms' decision really. I just want what the
implications of having 2 compatibles are to be understood.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21
Date: Tue, 20 Dec 2022 12:19:48 -0600 [thread overview]
Message-ID: <20221220181948.GA828243-robh@kernel.org> (raw)
In-Reply-To: <20221217183806.bvo5vypm6axycdte@pengutronix.de>
On Sat, Dec 17, 2022 at 07:38:06PM +0100, Uwe Kleine-König wrote:
> On Fri, Dec 16, 2022 at 05:57:58PM -0600, Rob Herring wrote:
> > On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > Changes since v2:
> > >
> > > - added allOf as Krzysztof requested
> > > - reworked driver based on Philipp's comments
> > > (improved error handling, different selects, moved driver to a subdirectory,
> > > header sorting, drm_err instead of DRM_ERROR, inlined
> > > imx_lcdc_check_mode_change, make use of dev_err_probe())
> > >
> > > Krzysztof also pointed out that we're now having two compatibles for a
> > > single hardware. Admittedly this is unusual, but this is the chance that
> > > the (bad) compatible identifier imx21-fb gets deprecated. The hardware
> > > is called LCDC and only the linux (framebuffer) driver is called imxfb.
> >
> > The problem is you can't have firmware (with the DTB) that supports
> > both. Well, you can if you want to have some firmware setting that
> > selects which one. Otherwise, it's really an OS problem to decide what
> > to use.
>
> I don't understand what you intend to say here. The same applies if the
> compatible is the same for both binding alternatives, isn't it?
Only if you have both nodes in the DT and both enabled. But 2 enabled
nodes at the same address is also a dtc warning, so I was assuming you
didn't do that.
> Do you consider a firmware problem better or an OS problem?
The OS created the problem, so they get to keep it. But a PC BIOS is
full of OS compatibility switches, so...
In the end, it's the platforms' decision really. I just want what the
implications of having 2 compatibles are to be understood.
Rob
next prev parent reply other threads:[~2022-12-20 18:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 17:50 [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21 Uwe Kleine-König
2022-12-16 17:50 ` Uwe Kleine-König
2022-12-16 17:50 ` Uwe Kleine-König
2022-12-16 17:50 ` [PATCH v3 1/2] dt-bindings: display: imx: Describe drm binding for fsl,imx-lcdc Uwe Kleine-König
2022-12-16 17:50 ` [PATCH v3 1/2] dt-bindings: display: imx: Describe drm binding for fsl, imx-lcdc Uwe Kleine-König
2022-12-16 17:50 ` [PATCH v3 1/2] dt-bindings: display: imx: Describe drm binding for fsl,imx-lcdc Uwe Kleine-König
2022-12-16 17:50 ` [PATCH v3 2/2] drm/imx/lcdc: Implement DRM driver for imx21 Uwe Kleine-König
2022-12-16 17:50 ` Uwe Kleine-König
2022-12-16 18:05 ` Philipp Zabel
2022-12-16 18:05 ` Philipp Zabel
2022-12-16 21:00 ` Uwe Kleine-König
2022-12-16 21:00 ` Uwe Kleine-König
2022-12-19 9:57 ` Philipp Zabel
2022-12-19 9:57 ` Philipp Zabel
2022-12-18 15:11 ` Sam Ravnborg
2022-12-18 15:11 ` Sam Ravnborg
2022-12-19 9:59 ` Philipp Zabel
2022-12-19 9:59 ` Philipp Zabel
2022-12-16 18:06 ` [PATCH v3 0/2] " Philipp Zabel
2022-12-16 18:06 ` Philipp Zabel
2022-12-16 18:06 ` Philipp Zabel
2022-12-16 23:57 ` Rob Herring
2022-12-16 23:57 ` Rob Herring
2022-12-16 23:57 ` Rob Herring
2022-12-17 18:38 ` Uwe Kleine-König
2022-12-17 18:38 ` Uwe Kleine-König
2022-12-17 18:38 ` Uwe Kleine-König
2022-12-20 18:19 ` Rob Herring [this message]
2022-12-20 18:19 ` Rob Herring
2022-12-20 18:19 ` Rob Herring
2022-12-21 10:48 ` Uwe Kleine-König
2022-12-21 10:48 ` Uwe Kleine-König
2022-12-21 10:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220181948.GA828243-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.