From: Frederic Weisbecker <frederic@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC 0/2] srcu: Remove pre-flip memory barrier
Date: Tue, 20 Dec 2022 23:57:56 +0100 [thread overview]
Message-ID: <20221220225756.GB26563@lothringen> (raw)
In-Reply-To: <5bd5ee4a-710a-96bc-abe8-772b2e60f478@efficios.com>
On Tue, Dec 20, 2022 at 02:01:30PM -0500, Mathieu Desnoyers wrote:
> On 2022-12-20 13:29, Joel Fernandes wrote:
> >
>
> > I do want to finish my memory barrier studies of SRCU over the holidays since I have been deep in the hole with that already. Back to the post flip memory barrier here since I think now even that might not be needed…
>
> I strongly suspect the memory barrier after flip is useless for the same
> reasons I mentioned explaining why the barrier before the flip is useless.
>
> However, we need to double-check that we have memory barriers at the
> beginning and end of synchronize_srcu, and between load of "unlock" counters
> and load of "lock" counters.
>
> Where is the barrier at the beginning of synchronize_srcu ?
rcu_seq_snap() ?
>
> Thanks,
>
> Mathieu
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> https://www.efficios.com
>
next prev parent reply other threads:[~2022-12-20 22:58 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 19:13 [RFC 0/2] srcu: Remove pre-flip memory barrier Joel Fernandes (Google)
2022-12-18 19:13 ` [RFC 1/2] srcu: Remove comment about prior read lock counts Joel Fernandes (Google)
2022-12-18 21:08 ` Mathieu Desnoyers
2022-12-18 21:19 ` Joel Fernandes
2022-12-18 19:13 ` [RFC 2/2] srcu: Remove memory barrier "E" as it is not required Joel Fernandes (Google)
2022-12-18 21:42 ` Frederic Weisbecker
2022-12-18 23:26 ` Joel Fernandes
2022-12-19 0:30 ` Joel Fernandes
2022-12-18 20:57 ` [RFC 0/2] srcu: Remove pre-flip memory barrier Mathieu Desnoyers
2022-12-18 21:30 ` Joel Fernandes
2022-12-18 23:26 ` Paul E. McKenney
2022-12-18 23:38 ` Mathieu Desnoyers
2022-12-19 0:04 ` Joel Fernandes
2022-12-19 0:24 ` Joel Fernandes
2022-12-19 1:50 ` Mathieu Desnoyers
2022-12-20 0:55 ` Joel Fernandes
2022-12-20 1:04 ` Joel Fernandes
2022-12-20 17:00 ` Mathieu Desnoyers
2022-12-20 18:05 ` Joel Fernandes
2022-12-20 18:14 ` Mathieu Desnoyers
2022-12-20 18:29 ` Joel Fernandes
2022-12-20 19:01 ` Mathieu Desnoyers
2022-12-20 19:06 ` Joel Fernandes
2022-12-20 23:05 ` Frederic Weisbecker
2022-12-20 23:46 ` Joel Fernandes
2022-12-21 0:27 ` Frederic Weisbecker
2022-12-20 22:57 ` Frederic Weisbecker [this message]
2022-12-21 3:34 ` Mathieu Desnoyers
2022-12-21 11:59 ` Frederic Weisbecker
2022-12-21 17:11 ` Mathieu Desnoyers
2022-12-22 12:40 ` Frederic Weisbecker
2022-12-22 13:19 ` Joel Fernandes
2022-12-22 16:43 ` Paul E. McKenney
2022-12-22 18:19 ` Joel Fernandes
2022-12-22 18:53 ` Paul E. McKenney
2022-12-22 18:56 ` Joel Fernandes
2022-12-22 19:45 ` Paul E. McKenney
2022-12-23 4:43 ` Joel Fernandes
2022-12-23 16:12 ` Joel Fernandes
2022-12-23 18:15 ` Paul E. McKenney
2022-12-23 20:10 ` Joel Fernandes
2022-12-23 20:52 ` Paul E. McKenney
2022-12-20 20:55 ` Joel Fernandes
2022-12-21 3:52 ` Mathieu Desnoyers
2022-12-21 5:02 ` Joel Fernandes
2022-12-21 0:07 ` Frederic Weisbecker
2022-12-21 3:47 ` Mathieu Desnoyers
2022-12-20 4:07 ` Joel Fernandes
2022-12-20 12:34 ` Frederic Weisbecker
2022-12-20 12:40 ` Frederic Weisbecker
2022-12-20 13:44 ` Joel Fernandes
2022-12-20 14:07 ` Frederic Weisbecker
2022-12-20 14:20 ` Joel Fernandes
2022-12-20 22:44 ` Frederic Weisbecker
2022-12-21 0:15 ` Joel Fernandes
2022-12-21 0:49 ` Frederic Weisbecker
2022-12-21 0:58 ` Frederic Weisbecker
2022-12-21 3:43 ` Mathieu Desnoyers
2022-12-21 4:26 ` Joel Fernandes
2022-12-21 14:04 ` Frederic Weisbecker
2022-12-21 16:30 ` Mathieu Desnoyers
2022-12-21 12:11 ` Frederic Weisbecker
2022-12-21 17:20 ` Mathieu Desnoyers
2022-12-21 18:18 ` Joel Fernandes
2022-12-21 2:41 ` Joel Fernandes
2022-12-21 11:26 ` Frederic Weisbecker
2022-12-21 16:02 ` Boqun Feng
2022-12-21 17:30 ` Frederic Weisbecker
2022-12-21 19:33 ` Joel Fernandes
2022-12-21 19:57 ` Joel Fernandes
2022-12-21 20:19 ` Boqun Feng
2022-12-22 12:16 ` Frederic Weisbecker
2022-12-22 12:24 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220225756.GB26563@lothringen \
--to=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.