All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1
@ 2022-12-23 17:38 Fabrice Fontaine
  2022-12-23 17:38 ` [Buildroot] [PATCH 2/2] package/ucl: drop package Fabrice Fontaine
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-12-23 17:38 UTC (permalink / raw)
  To: buildroot; +Cc: Samuel Martin, Fabrice Fontaine

- Drop patch (already in version)
- cmake must be used since
  https://github.com/upx/upx/commit/c7d8b6fed1b551158540e1d2e884dc224fce474c
- ucl and zlib are directly included in upx since
  https://github.com/upx/upx/commit/61e1366122f8d1b9e2434a8103e7af00a35ea902

https://github.com/upx/upx/blob/v4.0.1/NEWS

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...ck-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch | 80 -------------------
 package/upx/upx.hash                          |  2 +-
 package/upx/upx.mk                            | 22 +----
 3 files changed, 4 insertions(+), 100 deletions(-)
 delete mode 100644 package/upx/0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch

diff --git a/package/upx/0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch b/package/upx/0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch
deleted file mode 100644
index 6fae9cac0e..0000000000
--- a/package/upx/0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch
+++ /dev/null
@@ -1,80 +0,0 @@
-From 3781df9da23840e596d5e9e8493f22666802fe6c Mon Sep 17 00:00:00 2001
-From: John Reiser <jreiser@BitWagon.com>
-Date: Fri, 11 Dec 2020 13:38:18 -0800
-Subject: [PATCH] Check DT_REL/DT_RELA, DT_RELSZ/DT_RELASZ
-
-https://github.com/upx/upx/issues/421
-	modified:   p_lx_elf.cpp
-
-[Retrieved from:
-https://github.com/upx/upx/commit/3781df9da23840e596d5e9e8493f22666802fe6c]
-Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
----
- src/p_lx_elf.cpp | 34 +++++++++++++++++++++++++++++-----
- 1 file changed, 29 insertions(+), 5 deletions(-)
-
-diff --git a/src/p_lx_elf.cpp b/src/p_lx_elf.cpp
-index 182db192f..3a4101cf7 100644
---- a/src/p_lx_elf.cpp
-+++ b/src/p_lx_elf.cpp
-@@ -2222,8 +2222,20 @@ bool PackLinuxElf32::canPack()
-                         int z_rsz = dt_table[Elf32_Dyn::DT_RELSZ];
-                         if (z_rel && z_rsz) {
-                             unsigned rel_off = get_te32(&dynseg[-1+ z_rel].d_val);
-+                            if ((unsigned)file_size <= rel_off) {
-+                                char msg[70]; snprintf(msg, sizeof(msg),
-+                                     "bad Elf32_Dynamic[DT_REL] %#x\n",
-+                                     rel_off);
-+                                throwCantPack(msg);
-+                            }
-                             Elf32_Rel *rp = (Elf32_Rel *)&file_image[rel_off];
-                             unsigned relsz   = get_te32(&dynseg[-1+ z_rsz].d_val);
-+                            if ((unsigned)file_size <= relsz) {
-+                                char msg[70]; snprintf(msg, sizeof(msg),
-+                                     "bad Elf32_Dynamic[DT_RELSZ] %#x\n",
-+                                     relsz);
-+                                throwCantPack(msg);
-+                            }
-                             Elf32_Rel *last = (Elf32_Rel *)(relsz + (char *)rp);
-                             for (; rp < last; ++rp) {
-                                 unsigned r_va = get_te32(&rp->r_offset);
-@@ -2562,14 +2574,26 @@ PackLinuxElf64::canPack()
-                         int z_rel = dt_table[Elf64_Dyn::DT_RELA];
-                         int z_rsz = dt_table[Elf64_Dyn::DT_RELASZ];
-                         if (z_rel && z_rsz) {
--                            unsigned rel_off = get_te64(&dynseg[-1+ z_rel].d_val);
-+                            upx_uint64_t rel_off = get_te64(&dynseg[-1+ z_rel].d_val);
-+                            if ((u64_t)file_size <= rel_off) {
-+                                char msg[70]; snprintf(msg, sizeof(msg),
-+                                     "bad Elf64_Dynamic[DT_RELA] %#llx\n",
-+                                     rel_off);
-+                                throwCantPack(msg);
-+                            }
-                             Elf64_Rela *rp = (Elf64_Rela *)&file_image[rel_off];
--                            unsigned relsz   = get_te64(&dynseg[-1+ z_rsz].d_val);
-+                            upx_uint64_t relsz   = get_te64(&dynseg[-1+ z_rsz].d_val);
-+                            if ((u64_t)file_size <= relsz) {
-+                                char msg[70]; snprintf(msg, sizeof(msg),
-+                                     "bad Elf64_Dynamic[DT_RELASZ] %#llx\n",
-+                                     relsz);
-+                                throwCantPack(msg);
-+                            }
-                             Elf64_Rela *last = (Elf64_Rela *)(relsz + (char *)rp);
-                             for (; rp < last; ++rp) {
--                                unsigned r_va = get_te64(&rp->r_offset);
-+                                upx_uint64_t r_va = get_te64(&rp->r_offset);
-                                 if (r_va == user_init_ava) { // found the Elf64_Rela
--                                    unsigned r_info = get_te64(&rp->r_info);
-+                                    upx_uint64_t r_info = get_te64(&rp->r_info);
-                                     unsigned r_type = ELF64_R_TYPE(r_info);
-                                     if (Elf64_Ehdr::EM_AARCH64 == e_machine
-                                     &&  R_AARCH64_RELATIVE == r_type) {
-@@ -2581,7 +2605,7 @@ PackLinuxElf64::canPack()
-                                     }
-                                     else {
-                                         char msg[50]; snprintf(msg, sizeof(msg),
--                                            "bad relocation %#x DT_INIT_ARRAY[0]",
-+                                            "bad relocation %#llx DT_INIT_ARRAY[0]",
-                                             r_info);
-                                         throwCantPack(msg);
-                                     }
diff --git a/package/upx/upx.hash b/package/upx/upx.hash
index 7f3698ca0d..9f7c40c819 100644
--- a/package/upx/upx.hash
+++ b/package/upx/upx.hash
@@ -1,3 +1,3 @@
 # Locally computed:
-sha256  47774df5c958f2868ef550fb258b97c73272cb1f44fe776b798e393465993714  upx-3.96-src.tar.xz
+sha256  77003c8e2e29aa9804e2fbaeb30f055903420b3e01d95eafe01aed957fb7e190  upx-4.0.1-src.tar.xz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/upx/upx.mk b/package/upx/upx.mk
index e693a70db1..ef346b2310 100644
--- a/package/upx/upx.mk
+++ b/package/upx/upx.mk
@@ -4,28 +4,12 @@
 #
 ################################################################################
 
-UPX_VERSION = 3.96
+UPX_VERSION = 4.0.1
 UPX_SITE = https://github.com/upx/upx/releases/download/v$(UPX_VERSION)
 UPX_SOURCE = upx-$(UPX_VERSION)-src.tar.xz
 UPX_LICENSE = GPL-2.0+
 UPX_LICENSE_FILES = COPYING
 UPX_CPE_ID_VENDOR = upx_project
+UPX_SUPPORTS_IN_SOURCE_BUILD = NO
 
-# 0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch
-UPX_IGNORE_CVES += CVE-2021-20285
-
-HOST_UPX_DEPENDENCIES = host-ucl host-zlib
-
-# We need to specify all, otherwise the default target only prints a message
-# stating to "please choose a target for 'make'"... :-(
-define HOST_UPX_BUILD_CMDS
-	$(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
-		UPX_UCLDIR=$(HOST_DIR) CXXFLAGS_WERROR= -C $(@D) all
-endef
-
-# UPX has no install procedure, so install it manually.
-define HOST_UPX_INSTALL_CMDS
-	$(INSTALL) -D -m 0755 $(@D)/src/upx.out $(HOST_DIR)/bin/upx
-endef
-
-$(eval $(host-generic-package))
+$(eval $(host-cmake-package))
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/ucl: drop package
  2022-12-23 17:38 [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Fabrice Fontaine
@ 2022-12-23 17:38 ` Fabrice Fontaine
  2022-12-27 21:32 ` [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Thomas Petazzoni via buildroot
  2023-02-21 20:38 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-12-23 17:38 UTC (permalink / raw)
  To: buildroot; +Cc: Samuel Martin, Fabrice Fontaine

ucl is directly vendored in upx since version 3.99 and
https://github.com/upx/upx/commit/61e1366122f8d1b9e2434a8103e7af00a35ea902

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ucl/ucl.hash |  3 ---
 package/ucl/ucl.mk   | 15 ---------------
 2 files changed, 18 deletions(-)
 delete mode 100644 package/ucl/ucl.hash
 delete mode 100644 package/ucl/ucl.mk

diff --git a/package/ucl/ucl.hash b/package/ucl/ucl.hash
deleted file mode 100644
index 0252f69297..0000000000
--- a/package/ucl/ucl.hash
+++ /dev/null
@@ -1,3 +0,0 @@
-# Locally calculated
-sha256  b865299ffd45d73412293369c9754b07637680e5c826915f097577cd27350348  ucl-1.03.tar.gz
-sha256  70439f6e2b47057a408d2390ed6663b9875f5a08066a06a060a357ef1df89a8c  COPYING
diff --git a/package/ucl/ucl.mk b/package/ucl/ucl.mk
deleted file mode 100644
index aac068ef60..0000000000
--- a/package/ucl/ucl.mk
+++ /dev/null
@@ -1,15 +0,0 @@
-################################################################################
-#
-# ucl
-#
-################################################################################
-
-UCL_VERSION = 1.03
-UCL_SITE = http://www.oberhumer.com/opensource/ucl/download
-UCL_LICENSE = GPL-2.0+
-UCL_LICENSE_FILES = COPYING
-
-# Fix ACC conformance test failure for host gcc 6.x
-HOST_UCL_CONF_ENV += CPPFLAGS="$(HOST_CPPFLAGS) -std=iso9899:1990"
-
-$(eval $(host-autotools-package))
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1
  2022-12-23 17:38 [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Fabrice Fontaine
  2022-12-23 17:38 ` [Buildroot] [PATCH 2/2] package/ucl: drop package Fabrice Fontaine
@ 2022-12-27 21:32 ` Thomas Petazzoni via buildroot
  2023-02-21 20:38 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-12-27 21:32 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Samuel Martin, buildroot

On Fri, 23 Dec 2022 18:38:17 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> - Drop patch (already in version)
> - cmake must be used since
>   https://github.com/upx/upx/commit/c7d8b6fed1b551158540e1d2e884dc224fce474c
> - ucl and zlib are directly included in upx since
>   https://github.com/upx/upx/commit/61e1366122f8d1b9e2434a8103e7af00a35ea902
> 
> https://github.com/upx/upx/blob/v4.0.1/NEWS
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...ck-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch | 80 -------------------
>  package/upx/upx.hash                          |  2 +-
>  package/upx/upx.mk                            | 22 +----
>  3 files changed, 4 insertions(+), 100 deletions(-)
>  delete mode 100644 package/upx/0001-Check-DT_REL-DT_RELA-DT_RELSZ-DT_RELASZ.patch

Both applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1
  2022-12-23 17:38 [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Fabrice Fontaine
  2022-12-23 17:38 ` [Buildroot] [PATCH 2/2] package/ucl: drop package Fabrice Fontaine
  2022-12-27 21:32 ` [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Thomas Petazzoni via buildroot
@ 2023-02-21 20:38 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2023-02-21 20:38 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Samuel Martin, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > - Drop patch (already in version)
 > - cmake must be used since
 >   https://github.com/upx/upx/commit/c7d8b6fed1b551158540e1d2e884dc224fce474c
 > - ucl and zlib are directly included in upx since
 >   https://github.com/upx/upx/commit/61e1366122f8d1b9e2434a8103e7af00a35ea902

 > https://github.com/upx/upx/blob/v4.0.1/NEWS

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-21 20:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 17:38 [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Fabrice Fontaine
2022-12-23 17:38 ` [Buildroot] [PATCH 2/2] package/ucl: drop package Fabrice Fontaine
2022-12-27 21:32 ` [Buildroot] [PATCH 1/2] package/upx: bump to version 4.0.1 Thomas Petazzoni via buildroot
2023-02-21 20:38 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.