* [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL
@ 2022-12-29 17:15 Pali Rohár
2022-12-29 22:38 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pali Rohár @ 2022-12-29 17:15 UTC (permalink / raw)
To: Simon Glass, Stefan Roese, Tom Rini; +Cc: u-boot
sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:
LD u-boot
ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bus'
ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe':
drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf'
ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_read_config16'
ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_map_bar'
ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_map_bar'
ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_write_config16'
ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_read_config16'
ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bus'
ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd':
drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bus'
ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext':
drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
make: *** [Makefile:1778: u-boot] Error 1
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index a063b221cd1f..3fe53d6d4f3a 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -135,6 +135,7 @@ config SATA_MV
config SATA_SIL
bool "Enable Silicon Image SIL3131 / SIL3132 / SIL3124 SATA driver support"
+ depends on PCI
select AHCI
select LIBATA
help
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL
2022-12-29 17:15 [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL Pali Rohár
@ 2022-12-29 22:38 ` Simon Glass
2023-01-02 8:08 ` Stefan Roese
2023-01-12 15:19 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2022-12-29 22:38 UTC (permalink / raw)
To: Pali Rohár; +Cc: Stefan Roese, Tom Rini, u-boot
On Thu, 29 Dec 2022 at 11:15, Pali Rohár <pali@kernel.org> wrote:
>
> sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:
>
> LD u-boot
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
> drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe':
> drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf'
> ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_write_config16'
> ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
> drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd':
> drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext':
> drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
> make: *** [Makefile:1778: u-boot] Error 1
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL
2022-12-29 17:15 [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL Pali Rohár
2022-12-29 22:38 ` Simon Glass
@ 2023-01-02 8:08 ` Stefan Roese
2023-01-12 15:19 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2023-01-02 8:08 UTC (permalink / raw)
To: Pali Rohár, Simon Glass, Tom Rini; +Cc: u-boot
On 12/29/22 18:15, Pali Rohár wrote:
> sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:
>
> LD u-boot
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
> drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe':
> drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf'
> ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_write_config16'
> ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
> drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd':
> drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext':
> drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
> make: *** [Makefile:1778: u-boot] Error 1
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index a063b221cd1f..3fe53d6d4f3a 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -135,6 +135,7 @@ config SATA_MV
>
> config SATA_SIL
> bool "Enable Silicon Image SIL3131 / SIL3132 / SIL3124 SATA driver support"
> + depends on PCI
> select AHCI
> select LIBATA
> help
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL
2022-12-29 17:15 [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL Pali Rohár
2022-12-29 22:38 ` Simon Glass
2023-01-02 8:08 ` Stefan Roese
@ 2023-01-12 15:19 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-01-12 15:19 UTC (permalink / raw)
To: Pali Rohár; +Cc: Simon Glass, Stefan Roese, u-boot
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
On Thu, Dec 29, 2022 at 06:15:35PM +0100, Pali Rohár wrote:
> sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing:
>
> LD u-boot
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd':
> drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_pci_probe':
> drivers/ata/sata_sil.c:687: undefined reference to `dm_pci_get_bdf'
> ld.bfd: drivers/ata/sata_sil.c:691: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.c:701: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:704: undefined reference to `dm_pci_map_bar'
> ld.bfd: drivers/ata/sata_sil.c:713: undefined reference to `dm_pci_write_config16'
> ld.bfd: drivers/ata/sata_sil.c:717: undefined reference to `dm_pci_read_config16'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_cmd_identify_device':
> drivers/ata/sata_sil.c:256: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd':
> drivers/ata/sata_sil.c:330: undefined reference to `dm_pci_phys_to_bus'
> ld.bfd: drivers/ata/sata_sil.o: in function `sil_sata_rw_cmd_ext':
> drivers/ata/sata_sil.c:377: undefined reference to `dm_pci_phys_to_bus'
> make: *** [Makefile:1778: u-boot] Error 1
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-12 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-29 17:15 [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL Pali Rohár
2022-12-29 22:38 ` Simon Glass
2023-01-02 8:08 ` Stefan Roese
2023-01-12 15:19 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.