From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Simon Glass <sjg@chromium.org>, Heiko Schocher <hs@denx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx
Date: Fri, 30 Dec 2022 10:21:04 -0500 [thread overview]
Message-ID: <20221230152104.GZ3787616@bill-the-cat> (raw)
In-Reply-To: <20221230124811.zkzqgnxszidyy4ae@pali>
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
On Fri, Dec 30, 2022 at 01:48:11PM +0100, Pali Rohár wrote:
> On Thursday 29 December 2022 16:39:11 Simon Glass wrote:
> > Hi Pali,
> >
> > On Wed, 28 Dec 2022 at 14:06, Pali Rohár <pali@kernel.org> wrote:
> > >
> > > U-Boot build process currently always produces broken u-boot-dtb.bin binary
> > > for PowerPC mpc85xx architecture on boards which needs mpc85xx reset
> > > vector. For these boards this (intermediate) binary is not used as input
> > > for any other Makefile target on this architecture, so there is no real
> > > problem with it.
> > >
> > > But it is not a good idea to produce broken binaries during build phase. So
> > > try to improve it. Binary u-boot-dtb.bin should contains u-boot code with
> > > DTB blob. Such binary for those boards is build by binman. So change binman
> > > output file name from u-boot.bin to u-boot-dtb.bin and then let generic
> > > Makefile rule to generate final u-boot.bin from u-boot-dtb.bin. And finally
> > > disable generic u-boot-dtb.bin rule for mpc85xx.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > > Makefile | 17 ++++++++---------
> > > arch/powerpc/dts/socrates-u-boot.dtsi | 2 +-
> > > arch/powerpc/dts/u-boot.dtsi | 2 +-
> > > 3 files changed, 10 insertions(+), 11 deletions(-)
> >
> > Can you instead use a new filename, like u-boot-powerpc.bin for this?
>
> This would lead to the same situation as described here:
> https://patchwork.ozlabs.org/project/uboot/patch/20221228181839.22003-1-pali@kernel.org/
>
> > I'm not fan of adding SoC-specific rules in the Makefile - in fact
> > one of the goals of binman is to drop these.
>
> In this case it would be better to build u-boot-dts.bin only by binman
> (for all platforms) instead of cat-ing rules in Makefile.
This would also be an easier path forward perhaps for making sure that
the dtb is always 8 byte aligned?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-12-30 15:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 20:04 [PATCH u-boot 1/2] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin Pali Rohár
2022-12-28 20:04 ` [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx Pali Rohár
2022-12-29 22:39 ` Simon Glass
2022-12-30 12:48 ` Pali Rohár
2022-12-30 15:21 ` Tom Rini [this message]
2022-12-30 15:24 ` Pali Rohár
2022-12-30 15:41 ` Tom Rini
2022-12-30 15:44 ` Pali Rohár
2022-12-30 15:49 ` Simon Glass
2022-12-30 16:06 ` Tom Rini
2022-12-30 16:06 ` Pali Rohár
2022-12-30 17:43 ` Simon Glass
2022-12-30 17:55 ` Pali Rohár
2022-12-30 18:51 ` Simon Glass
2022-12-30 19:12 ` Pali Rohár
2023-01-03 17:02 ` Simon Glass
2023-01-03 17:05 ` Pali Rohár
2023-01-07 0:13 ` Simon Glass
2023-01-11 0:12 ` Pali Rohár
2023-01-11 10:08 ` Heiko Schocher
2023-01-11 12:52 ` Heiko Schocher
2023-01-11 14:01 ` Tom Rini
2023-01-11 17:55 ` Pali Rohár
2023-01-11 18:02 ` Pali Rohár
2023-01-11 18:13 ` Pali Rohár
2023-01-12 6:27 ` Heiko Schocher
2023-01-12 10:50 ` Heiko Schocher
2023-01-12 17:39 ` Pali Rohár
2023-01-13 5:52 ` Heiko Schocher
2023-01-12 5:27 ` Heiko Schocher
2023-01-13 23:11 ` [PATCH v2 u-boot 1/3] powerpc/mpc85xx: socrates: Use u-boot.dtb instead of dts/dt.dtb Pali Rohár
2023-01-13 23:11 ` [PATCH v2 u-boot 2/3] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin Pali Rohár
2023-01-13 23:16 ` Tom Rini
2023-01-14 21:12 ` Pali Rohár
2023-01-14 21:24 ` Tom Rini
2023-01-16 5:37 ` Heiko Schocher
2023-01-13 23:11 ` [PATCH v2 u-boot 3/3] Makefile: Build working u-boot-dtb.bin target also for mpc85xx Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221230152104.GZ3787616@bill-the-cat \
--to=trini@konsulko.com \
--cc=hs@denx.de \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.