From: Shawn Guo <shawnguo@kernel.org>
To: Nikolaus Voss <nikolaus.voss@haag-streit.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
nv@vosn.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] imx6qdl.dtsi: use MAC-address from nvmem
Date: Sat, 31 Dec 2022 14:49:24 +0800 [thread overview]
Message-ID: <20221231064923.GD6112@T480> (raw)
In-Reply-To: <20221128084749.5F10D1D73@mail.steuer-voss.de>
On Wed, Nov 02, 2022 at 03:27:19PM +0100, Nikolaus Voss wrote:
> IMX6QDL has fuse locations specified for storing the MAC for the
> built-in ethernet (Table 5-8 in Reference Manual).
> Define the fuse location in ocotp and refer to them in fec-ethernet.
>
> If the cells are not flashed, the driver behavior is unchanged, i.e.
> other MAC sources will be probed and a random MAC will be used as a
> last resort.
>
> Signed-off-by: Nikolaus Voss <nikolaus.voss@haag-streit.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 4f7fefc14d0ac..7449d554ef1aa 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1053,6 +1053,8 @@ fec: ethernet@2188000 {
> <&clks IMX6QDL_CLK_ENET_REF>;
> clock-names = "ipg", "ahb", "ptp", "enet_out";
> fsl,stop-mode = <&gpr 0x34 27>;
> + nvmem-cells = <&fec_mac_addr>;
> + nvmem-cell-names = "mac-address";
May I ask where is the support of FEC driver for this?
Shawn
> status = "disabled";
> };
>
> @@ -1186,6 +1188,10 @@ tempmon_calib: calib@38 {
> tempmon_temp_grade: temp-grade@20 {
> reg = <0x20 4>;
> };
> +
> + fec_mac_addr: mac-addr@88 {
> + reg = <0x88 6>;
> + };
> };
>
> tzasc@21d0000 { /* TZASC1 */
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Nikolaus Voss <nikolaus.voss@haag-streit.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
nv@vosn.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] imx6qdl.dtsi: use MAC-address from nvmem
Date: Sat, 31 Dec 2022 14:49:24 +0800 [thread overview]
Message-ID: <20221231064923.GD6112@T480> (raw)
In-Reply-To: <20221128084749.5F10D1D73@mail.steuer-voss.de>
On Wed, Nov 02, 2022 at 03:27:19PM +0100, Nikolaus Voss wrote:
> IMX6QDL has fuse locations specified for storing the MAC for the
> built-in ethernet (Table 5-8 in Reference Manual).
> Define the fuse location in ocotp and refer to them in fec-ethernet.
>
> If the cells are not flashed, the driver behavior is unchanged, i.e.
> other MAC sources will be probed and a random MAC will be used as a
> last resort.
>
> Signed-off-by: Nikolaus Voss <nikolaus.voss@haag-streit.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 4f7fefc14d0ac..7449d554ef1aa 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1053,6 +1053,8 @@ fec: ethernet@2188000 {
> <&clks IMX6QDL_CLK_ENET_REF>;
> clock-names = "ipg", "ahb", "ptp", "enet_out";
> fsl,stop-mode = <&gpr 0x34 27>;
> + nvmem-cells = <&fec_mac_addr>;
> + nvmem-cell-names = "mac-address";
May I ask where is the support of FEC driver for this?
Shawn
> status = "disabled";
> };
>
> @@ -1186,6 +1188,10 @@ tempmon_calib: calib@38 {
> tempmon_temp_grade: temp-grade@20 {
> reg = <0x20 4>;
> };
> +
> + fec_mac_addr: mac-addr@88 {
> + reg = <0x88 6>;
> + };
> };
>
> tzasc@21d0000 { /* TZASC1 */
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-12-31 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 14:27 [PATCH 2/2] imx6qdl.dtsi: use MAC-address from nvmem Nikolaus Voss
2022-11-02 14:27 ` Nikolaus Voss
2022-12-31 6:49 ` Shawn Guo [this message]
2022-12-31 6:49 ` Shawn Guo
2022-12-31 17:08 ` Andrew Lunn
2022-12-31 17:08 ` Andrew Lunn
2023-01-01 2:19 ` Shawn Guo
2023-01-01 2:19 ` Shawn Guo
2023-01-01 2:32 ` Shawn Guo
2023-01-01 2:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231064923.GD6112@T480 \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolaus.voss@haag-streit.com \
--cc=nv@vosn.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.