From: Tomasz Figa <tomasz.figa@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Leela Krishna Amudala <l.krishna@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Simon Glass <sjg@chromium.org>,
Thomas P Abraham <thomas.ab@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
s.nawrocki@samsung.com
Subject: Re: [PATCH 1/3] ARM: dts: add pinctrl support to Exynos5420
Date: Wed, 12 Jun 2013 23:38:07 +0200 [thread overview]
Message-ID: <2022855.FJPYCTz0ZP@flatron> (raw)
In-Reply-To: <CAD=FV=Un9=cm_Drhvgba9jnhGgh4ss2YBb+CFDTNMfUmaoVjFA@mail.gmail.com>
On Wednesday 12 of June 2013 14:35:30 Doug Anderson wrote:
> Tomasz,
>
> On Wed, Jun 12, 2013 at 2:20 PM, Doug Anderson <dianders@chromium.org>
wrote:
> > Tomasz,
> >
> > On Wed, Jun 12, 2013 at 1:58 PM, Tomasz Figa <tomasz.figa@gmail.com>
wrote:
> >>> + pinctrl@13400000 {
> >>> + gpy7: gpy7 {
> >>> + gpio-controller;
> >>> + #gpio-cells = <2>;
> >>> +
> >>> + interrupt-controller;
> >>> + #interrupt-cells = <2>;
> >>
> >> According to patch 2/3, this bank doesn't support interrupts, as it's
> >> defined using EINTN macro. Which variant is correct?
> >
> > As far as I know the GPY registers don't support interrupts, so this
> > should be removed. Nice catch!
>
> Argh. I'm not sure what I was just searching before (I probably
> messed up and searched for gpy6 or something), but I just searched
> again and am now seeing that GPY7 actually does support interrupts,
> unlike all of the other gpy banks.
This or other way, one of the patches needs to be fixed. If this bank
supports interrupts, the patch adding driver data needs to be adjusted to
use the EINTG macro.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-06-12 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 14:51 [PATCH 0/3] Add pinctrl support to Exynos5420 Leela Krishna Amudala
2013-06-12 14:51 ` [PATCH 1/3] ARM: dts: add " Leela Krishna Amudala
2013-06-12 20:58 ` Tomasz Figa
2013-06-12 21:20 ` Doug Anderson
2013-06-12 21:35 ` Doug Anderson
2013-06-12 21:38 ` Tomasz Figa [this message]
2013-06-14 12:21 ` Leela Krishna Amudala
2013-06-16 4:23 ` Doug Anderson
2013-06-14 4:49 ` Leela Krishna Amudala
2013-06-12 14:51 ` [PATCH 2/3] pinctrl: exynos: add exynos5420 SoC specific data Leela Krishna Amudala
2013-06-12 21:00 ` Tomasz Figa
2013-06-12 21:37 ` Doug Anderson
2013-06-12 14:51 ` [PATCH 3/3] gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5420 Leela Krishna Amudala
2013-06-12 21:02 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022855.FJPYCTz0ZP@flatron \
--to=tomasz.figa@gmail.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sjg@chromium.org \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.