From: Tomasz Figa <tomasz.figa@gmail.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
dianders@chromium.org, sjg@chromium.org, thomas.ab@samsung.com,
t.figa@samsung.com
Subject: Re: [PATCH 3/3] gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5420
Date: Wed, 12 Jun 2013 23:02:24 +0200 [thread overview]
Message-ID: <21123416.h5QvJGGsDv@flatron> (raw)
In-Reply-To: <1371048688-9089-4-git-send-email-l.krishna@samsung.com>
On Wednesday 12 of June 2013 20:21:28 Leela Krishna Amudala wrote:
> Skip exynos5420 gpiolib registration if pinctrl support is enabled.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> drivers/gpio/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 83a0d71..b3dd984 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3033,6 +3033,7 @@ static __init int samsung_gpiolib_init(void)
> { .compatible = "samsung,exynos4210-pinctrl", },
> { .compatible = "samsung,exynos4x12-pinctrl", },
> { .compatible = "samsung,exynos5250-pinctrl", },
> + { .compatible = "samsung,exynos5420-pinctrl", },
> { .compatible = "samsung,exynos5440-pinctrl", },
IMHO after Kukjin's patches removing non-DT support for Exynos, we can
just remove Exynos support from this legacy driver. I will send
appropriate patch this Friday, along with other cleanup patches.
Best regards,
Tomasz
> { }
> };
prev parent reply other threads:[~2013-06-12 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 14:51 [PATCH 0/3] Add pinctrl support to Exynos5420 Leela Krishna Amudala
2013-06-12 14:51 ` [PATCH 1/3] ARM: dts: add " Leela Krishna Amudala
2013-06-12 20:58 ` Tomasz Figa
2013-06-12 21:20 ` Doug Anderson
2013-06-12 21:35 ` Doug Anderson
2013-06-12 21:38 ` Tomasz Figa
2013-06-14 12:21 ` Leela Krishna Amudala
2013-06-16 4:23 ` Doug Anderson
2013-06-14 4:49 ` Leela Krishna Amudala
2013-06-12 14:51 ` [PATCH 2/3] pinctrl: exynos: add exynos5420 SoC specific data Leela Krishna Amudala
2013-06-12 21:00 ` Tomasz Figa
2013-06-12 21:37 ` Doug Anderson
2013-06-12 14:51 ` [PATCH 3/3] gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5420 Leela Krishna Amudala
2013-06-12 21:02 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21123416.h5QvJGGsDv@flatron \
--to=tomasz.figa@gmail.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjg@chromium.org \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.