Re: [PATCH 2/7] mtd: rawnand: sunxi: Remove an unnecessary check

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/7] mtd: rawnand: sunxi: Remove an unnecessary check
Date: Mon, 2 Jan 2023 09:59:11 +0100	[thread overview]
Message-ID: <20230102095911.0243d5b8@xps-13> (raw)
In-Reply-To: <20221229181526.53766-3-samuel@sholland.org>

Hi Samuel,

samuel@sholland.org wrote on Thu, 29 Dec 2022 12:15:21 -0600:

> sunxi_nand->nsels cannot be zero, so the second check implies the first.

Actually this check comes from a time where we did check against -1 :)
But, yeah, now it's a duplicate.

> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
> index 2ee86f7b0905..8b221f9f10a7 100644
> --- a/drivers/mtd/nand/raw/sunxi_nand.c
> +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> @@ -421,7 +421,7 @@ static void sunxi_nfc_select_chip(struct nand_chip *nand, unsigned int cs)
>  	struct sunxi_nand_chip_sel *sel;
>  	u32 ctl;
>  
> -	if (cs > 0 && cs >= sunxi_nand->nsels)
> +	if (cs >= sunxi_nand->nsels)
>  		return;
>  
>  	ctl = readl(nfc->regs + NFC_REG_CTL) &


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/7] mtd: rawnand: sunxi: Remove an unnecessary check
Date: Mon, 2 Jan 2023 09:59:11 +0100	[thread overview]
Message-ID: <20230102095911.0243d5b8@xps-13> (raw)
In-Reply-To: <20221229181526.53766-3-samuel@sholland.org>

Hi Samuel,

samuel@sholland.org wrote on Thu, 29 Dec 2022 12:15:21 -0600:

> sunxi_nand->nsels cannot be zero, so the second check implies the first.

Actually this check comes from a time where we did check against -1 :)
But, yeah, now it's a duplicate.

> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
> index 2ee86f7b0905..8b221f9f10a7 100644
> --- a/drivers/mtd/nand/raw/sunxi_nand.c
> +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> @@ -421,7 +421,7 @@ static void sunxi_nfc_select_chip(struct nand_chip *nand, unsigned int cs)
>  	struct sunxi_nand_chip_sel *sel;
>  	u32 ctl;
>  
> -	if (cs > 0 && cs >= sunxi_nand->nsels)
> +	if (cs >= sunxi_nand->nsels)
>  		return;
>  
>  	ctl = readl(nfc->regs + NFC_REG_CTL) &


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/7] mtd: rawnand: sunxi: Remove an unnecessary check
Date: Mon, 2 Jan 2023 09:59:11 +0100	[thread overview]
Message-ID: <20230102095911.0243d5b8@xps-13> (raw)
In-Reply-To: <20221229181526.53766-3-samuel@sholland.org>

Hi Samuel,

samuel@sholland.org wrote on Thu, 29 Dec 2022 12:15:21 -0600:

> sunxi_nand->nsels cannot be zero, so the second check implies the first.

Actually this check comes from a time where we did check against -1 :)
But, yeah, now it's a duplicate.

> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
> index 2ee86f7b0905..8b221f9f10a7 100644
> --- a/drivers/mtd/nand/raw/sunxi_nand.c
> +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> @@ -421,7 +421,7 @@ static void sunxi_nfc_select_chip(struct nand_chip *nand, unsigned int cs)
>  	struct sunxi_nand_chip_sel *sel;
>  	u32 ctl;
>  
> -	if (cs > 0 && cs >= sunxi_nand->nsels)
> +	if (cs >= sunxi_nand->nsels)
>  		return;
>  
>  	ctl = readl(nfc->regs + NFC_REG_CTL) &


Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2023-01-02  9:04 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 18:15 [PATCH 0/7] mtd: rawnand: sunxi: Bug fixes and cleanup Samuel Holland
2022-12-29 18:15 ` Samuel Holland
2022-12-29 18:15 ` Samuel Holland
2022-12-29 18:15 ` [PATCH 1/7] mtd: rawnand: sunxi: Clean up chips after failed init Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02 11:20   ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 2/7] mtd: rawnand: sunxi: Remove an unnecessary check Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02  8:59   ` Miquel Raynal [this message]
2023-01-02  8:59     ` Miquel Raynal
2023-01-02  8:59     ` Miquel Raynal
2023-01-02 11:20   ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 3/7] " Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02 11:20   ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 4/7] mtd: rawnand: sunxi: Fix ECC strength maximization Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02  9:11   ` Miquel Raynal
2023-01-02  9:11     ` Miquel Raynal
2023-01-02  9:11     ` Miquel Raynal
2023-01-02 15:59     ` Samuel Holland
2023-01-02 15:59       ` Samuel Holland
2023-01-02 15:59       ` Samuel Holland
2023-01-02 16:45       ` Miquel Raynal
2023-01-02 16:45         ` Miquel Raynal
2023-01-02 16:45         ` Miquel Raynal
2023-01-02 17:06         ` Samuel Holland
2023-01-02 17:06           ` Samuel Holland
2023-01-02 17:06           ` Samuel Holland
2023-01-03 14:41           ` Miquel Raynal
2023-01-03 14:41             ` Miquel Raynal
2023-01-03 14:41             ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 5/7] mtd: rawnand: sunxi: Fix the size of the last OOB region Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02  9:00   ` Gole, Dhruva
2023-01-02  9:00     ` Gole, Dhruva
2023-01-02  9:00     ` Gole, Dhruva
2023-01-02 11:20   ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2023-01-02 11:20     ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 6/7] mtd: rawnand: sunxi: Update OOB layout to match hardware Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02  9:21   ` Miquel Raynal
2023-01-02  9:21     ` Miquel Raynal
2023-01-02  9:21     ` Miquel Raynal
2023-01-02 16:26     ` Samuel Holland
2023-01-02 16:26       ` Samuel Holland
2023-01-02 16:26       ` Samuel Holland
2023-01-02 16:53       ` Miquel Raynal
2023-01-02 16:53         ` Miquel Raynal
2023-01-02 16:53         ` Miquel Raynal
2022-12-29 18:15 ` [PATCH 7/7] mtd: rawnand: sunxi: Precompute the ECC_CTL register value Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2022-12-29 18:15   ` Samuel Holland
2023-01-02  9:30   ` Miquel Raynal
2023-01-02  9:30     ` Miquel Raynal
2023-01-02  9:30     ` Miquel Raynal
2023-01-02 16:33     ` Samuel Holland
2023-01-02 16:33       ` Samuel Holland
2023-01-02 16:33       ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230102095911.0243d5b8@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=richard@nod.at \
    --cc=samuel@sholland.org \
    --cc=vigneshr@ti.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.