All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Marek Vasut <marex@denx.de>, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0
Date: Mon, 2 Jan 2023 10:40:04 +0100	[thread overview]
Message-ID: <20230102104004.6abae6da@xps-13> (raw)
In-Reply-To: <Y5ydGhn/qYUalamm@francesco-nb.int.toradex.com>

Hi Francesco,

francesco@dolcini.it wrote on Fri, 16 Dec 2022 17:30:18 +0100:

> On Fri, Dec 16, 2022 at 04:35:01PM +0100, Miquel Raynal wrote:
> > marex@denx.de wrote on Fri, 16 Dec 2022 15:32:28 +0100:  
> > > The second part of the message, as far as I understand it, is
> > > "ignore problems this will cause to users of boards we do not know
> > > about, let them run into unbootable systems after some linux kernel
> > > update,   
> > 
> > Now you know what kernel update will break them, so you can prevent it
> > from happening. 
> > 
> > For boards without even a dtsi in the kernel, should we care?  
> 
> Would caring for those boards not be just exact the same as caring for
> some UEFI/ACPI mess for which no source code is normally available and
> nobody really known at which point the various vendors have forked their
> source code from some Intel or AMD or whatever reference code?

I am sorry I don't know UEFI/ACPI well enough to discuss it.

> IMHO we should care for the multiple reason I have already written in my
> previous emails.
> 
> And honestly, just as a side comment, I would feel way more happy
> to know that the elevator control system in the elevator I use everyday
> or the chemical industrial plan HMI next to my home is running an up to
> date Linux system that is not affected by known security vulnerabilities
> and they did stop updating it just because there was some random bug
> preventing the updated kernel to boot and nobody had the time/skill to
> investigate and fix it. [1]

The issue comes from a very specific U-Boot function that should have
never existed. I hope people working on chemical plants do not make
use of these and will not disregard the "your DT is broken there [...]"
warning we plan to add right before their updated board will fail. We
are not living people in the dark, I agreed for a warning, but I don't
think applying the proposed fix blindly is wise and future-proof.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Marek Vasut <marex@denx.de>, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0
Date: Mon, 2 Jan 2023 10:40:04 +0100	[thread overview]
Message-ID: <20230102104004.6abae6da@xps-13> (raw)
In-Reply-To: <Y5ydGhn/qYUalamm@francesco-nb.int.toradex.com>

Hi Francesco,

francesco@dolcini.it wrote on Fri, 16 Dec 2022 17:30:18 +0100:

> On Fri, Dec 16, 2022 at 04:35:01PM +0100, Miquel Raynal wrote:
> > marex@denx.de wrote on Fri, 16 Dec 2022 15:32:28 +0100:  
> > > The second part of the message, as far as I understand it, is
> > > "ignore problems this will cause to users of boards we do not know
> > > about, let them run into unbootable systems after some linux kernel
> > > update,   
> > 
> > Now you know what kernel update will break them, so you can prevent it
> > from happening. 
> > 
> > For boards without even a dtsi in the kernel, should we care?  
> 
> Would caring for those boards not be just exact the same as caring for
> some UEFI/ACPI mess for which no source code is normally available and
> nobody really known at which point the various vendors have forked their
> source code from some Intel or AMD or whatever reference code?

I am sorry I don't know UEFI/ACPI well enough to discuss it.

> IMHO we should care for the multiple reason I have already written in my
> previous emails.
> 
> And honestly, just as a side comment, I would feel way more happy
> to know that the elevator control system in the elevator I use everyday
> or the chemical industrial plan HMI next to my home is running an up to
> date Linux system that is not affected by known security vulnerabilities
> and they did stop updating it just because there was some random bug
> preventing the updated kernel to boot and nobody had the time/skill to
> investigate and fix it. [1]

The issue comes from a very specific U-Boot function that should have
never existed. I hope people working on chemical plants do not make
use of these and will not disregard the "your DT is broken there [...]"
warning we plan to add right before their updated board will fail. We
are not living people in the dark, I agreed for a warning, but I don't
think applying the proposed fix blindly is wise and future-proof.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Marek Vasut <marex@denx.de>, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0
Date: Mon, 2 Jan 2023 10:40:04 +0100	[thread overview]
Message-ID: <20230102104004.6abae6da@xps-13> (raw)
In-Reply-To: <Y5ydGhn/qYUalamm@francesco-nb.int.toradex.com>

Hi Francesco,

francesco@dolcini.it wrote on Fri, 16 Dec 2022 17:30:18 +0100:

> On Fri, Dec 16, 2022 at 04:35:01PM +0100, Miquel Raynal wrote:
> > marex@denx.de wrote on Fri, 16 Dec 2022 15:32:28 +0100:  
> > > The second part of the message, as far as I understand it, is
> > > "ignore problems this will cause to users of boards we do not know
> > > about, let them run into unbootable systems after some linux kernel
> > > update,   
> > 
> > Now you know what kernel update will break them, so you can prevent it
> > from happening. 
> > 
> > For boards without even a dtsi in the kernel, should we care?  
> 
> Would caring for those boards not be just exact the same as caring for
> some UEFI/ACPI mess for which no source code is normally available and
> nobody really known at which point the various vendors have forked their
> source code from some Intel or AMD or whatever reference code?

I am sorry I don't know UEFI/ACPI well enough to discuss it.

> IMHO we should care for the multiple reason I have already written in my
> previous emails.
> 
> And honestly, just as a side comment, I would feel way more happy
> to know that the elevator control system in the elevator I use everyday
> or the chemical industrial plan HMI next to my home is running an up to
> date Linux system that is not affected by known security vulnerabilities
> and they did stop updating it just because there was some random bug
> preventing the updated kernel to boot and nobody had the time/skill to
> investigate and fix it. [1]

The issue comes from a very specific U-Boot function that should have
never existed. I hope people working on chemical plants do not make
use of these and will not disregard the "your DT is broken there [...]"
warning we plan to add right before their updated board will fail. We
are not living people in the dark, I agreed for a warning, but I don't
think applying the proposed fix blindly is wise and future-proof.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-02  9:42 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  7:19 [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0 Francesco Dolcini
2022-12-02  7:19 ` Francesco Dolcini
2022-12-02  7:19 ` Francesco Dolcini
2022-12-02  9:14 ` Miquel Raynal
2022-12-02  9:14   ` Miquel Raynal
2022-12-02  9:14   ` Miquel Raynal
2022-12-02 10:12   ` Francesco Dolcini
2022-12-02 10:12     ` Francesco Dolcini
2022-12-02 10:12     ` Francesco Dolcini
2022-12-02 10:24     ` Francesco Dolcini
2022-12-02 10:24       ` Francesco Dolcini
2022-12-02 10:24       ` Francesco Dolcini
2022-12-02 10:53       ` Miquel Raynal
2022-12-02 10:53         ` Miquel Raynal
2022-12-02 10:53         ` Miquel Raynal
2022-12-02 11:23         ` Francesco Dolcini
2022-12-02 11:23           ` Francesco Dolcini
2022-12-02 11:23           ` Francesco Dolcini
2022-12-02 14:05           ` Miquel Raynal
2022-12-02 14:05             ` Miquel Raynal
2022-12-02 14:05             ` Miquel Raynal
2022-12-02 14:31             ` Marek Vasut
2022-12-02 14:31               ` Marek Vasut
2022-12-02 14:31               ` Marek Vasut
2022-12-02 15:00               ` Miquel Raynal
2022-12-02 15:00                 ` Miquel Raynal
2022-12-02 15:00                 ` Miquel Raynal
2022-12-02 15:23                 ` Marek Vasut
2022-12-02 15:23                   ` Marek Vasut
2022-12-02 15:23                   ` Marek Vasut
2022-12-02 15:49                   ` Miquel Raynal
2022-12-02 15:49                     ` Miquel Raynal
2022-12-02 15:49                     ` Miquel Raynal
2022-12-02 16:01                     ` Miquel Raynal
2022-12-02 16:01                       ` Miquel Raynal
2022-12-02 16:01                       ` Miquel Raynal
2022-12-02 16:17                     ` Marek Vasut
2022-12-02 16:17                       ` Marek Vasut
2022-12-02 16:17                       ` Marek Vasut
2022-12-02 16:42                       ` Miquel Raynal
2022-12-02 16:42                         ` Miquel Raynal
2022-12-02 16:42                         ` Miquel Raynal
2022-12-02 16:52                         ` Marek Vasut
2022-12-02 16:52                           ` Marek Vasut
2022-12-02 16:52                           ` Marek Vasut
2022-12-02 16:57                           ` Miquel Raynal
2022-12-02 16:57                             ` Miquel Raynal
2022-12-02 16:57                             ` Miquel Raynal
2022-12-02 17:08                             ` Marek Vasut
2022-12-02 17:08                               ` Marek Vasut
2022-12-02 17:08                               ` Marek Vasut
2022-12-05 11:26                               ` Francesco Dolcini
2022-12-05 11:26                                 ` Francesco Dolcini
2022-12-05 11:26                                 ` Francesco Dolcini
2022-12-05 13:49                                 ` Miquel Raynal
2022-12-05 13:49                                   ` Miquel Raynal
2022-12-05 13:49                                   ` Miquel Raynal
2022-12-05 16:25                                   ` Marek Vasut
2022-12-05 16:25                                     ` Marek Vasut
2022-12-05 16:25                                     ` Marek Vasut
2022-12-15  7:16                                     ` Miquel Raynal
2022-12-15  7:16                                       ` Miquel Raynal
2022-12-15  7:16                                       ` Miquel Raynal
2022-12-15  7:45                                       ` Marek Vasut
2022-12-15  7:45                                         ` Marek Vasut
2022-12-15  7:45                                         ` Marek Vasut
2022-12-15  8:04                                         ` Miquel Raynal
2022-12-15  8:04                                           ` Miquel Raynal
2022-12-15  8:04                                           ` Miquel Raynal
2022-12-16  0:36                                           ` Marek Vasut
2022-12-16  0:36                                             ` Marek Vasut
2022-12-16  0:36                                             ` Marek Vasut
2022-12-16  7:52                                             ` Francesco Dolcini
2022-12-16  7:52                                               ` Francesco Dolcini
2022-12-16  7:52                                               ` Francesco Dolcini
2022-12-16  7:45                                       ` Francesco Dolcini
2022-12-16  7:45                                         ` Francesco Dolcini
2022-12-16  7:45                                         ` Francesco Dolcini
2022-12-16 10:46                                         ` Marek Vasut
2022-12-16 10:46                                           ` Marek Vasut
2022-12-16 10:46                                           ` Marek Vasut
2022-12-16 11:01                                           ` Miquel Raynal
2022-12-16 11:01                                             ` Miquel Raynal
2022-12-16 11:01                                             ` Miquel Raynal
2022-12-16 12:37                                             ` Francesco Dolcini
2022-12-16 12:37                                               ` Francesco Dolcini
2022-12-16 12:37                                               ` Francesco Dolcini
2022-12-16 13:37                                               ` Miquel Raynal
2022-12-16 13:37                                                 ` Miquel Raynal
2022-12-16 13:37                                                 ` Miquel Raynal
2022-12-16 14:32                                                 ` Marek Vasut
2022-12-16 14:32                                                   ` Marek Vasut
2022-12-16 14:32                                                   ` Marek Vasut
2022-12-16 15:35                                                   ` Miquel Raynal
2022-12-16 15:35                                                     ` Miquel Raynal
2022-12-16 15:35                                                     ` Miquel Raynal
2022-12-16 16:30                                                     ` Francesco Dolcini
2022-12-16 16:30                                                       ` Francesco Dolcini
2022-12-16 16:30                                                       ` Francesco Dolcini
2023-01-02  9:40                                                       ` Miquel Raynal [this message]
2023-01-02  9:40                                                         ` Miquel Raynal
2023-01-02  9:40                                                         ` Miquel Raynal
2023-01-05 11:33                                                         ` Miquel Raynal
2023-01-05 11:33                                                           ` Miquel Raynal
2023-01-05 11:33                                                           ` Miquel Raynal
2023-01-05 12:47                                                           ` Francesco Dolcini
2023-01-05 12:47                                                             ` Francesco Dolcini
2023-01-05 12:47                                                             ` Francesco Dolcini
2023-01-05 14:51                                                             ` Marek Vasut
2023-01-05 14:51                                                               ` Marek Vasut
2023-01-05 14:51                                                               ` Marek Vasut
2023-01-05 15:03                                                               ` Miquel Raynal
2023-01-05 15:03                                                                 ` Miquel Raynal
2023-01-05 15:03                                                                 ` Miquel Raynal
2022-12-02 17:20                         ` Francesco Dolcini
2022-12-02 17:20                           ` Francesco Dolcini
2022-12-02 17:20                           ` Francesco Dolcini
2022-12-05 11:30                           ` Francesco Dolcini
2022-12-05 11:30                             ` Francesco Dolcini
2022-12-05 11:30                             ` Francesco Dolcini
2022-12-05 15:28                             ` Miquel Raynal
2022-12-05 15:28                               ` Miquel Raynal
2022-12-05 15:28                               ` Miquel Raynal
2022-12-02 16:45                       ` Francesco Dolcini
2022-12-02 16:45                         ` Francesco Dolcini
2022-12-02 16:45                         ` Francesco Dolcini
2022-12-02 17:05                         ` Miquel Raynal
2022-12-02 17:05                           ` Miquel Raynal
2022-12-02 17:05                           ` Miquel Raynal
2022-12-02 15:56               ` Thorsten Leemhuis
2022-12-02 15:56                 ` Thorsten Leemhuis
2022-12-02 15:56                 ` Thorsten Leemhuis
2022-12-04 12:50                 ` Marek Vasut
2022-12-04 12:50                   ` Marek Vasut
2022-12-04 12:50                   ` Marek Vasut
2022-12-04 12:59                   ` Thorsten Leemhuis
2022-12-04 12:59                     ` Thorsten Leemhuis
2022-12-04 12:59                     ` Thorsten Leemhuis
2022-12-04 15:50                     ` Marek Vasut
2022-12-04 15:50                       ` Marek Vasut
2022-12-04 15:50                       ` Marek Vasut
2022-12-02 12:43 ` Greg KH
2022-12-02 12:43   ` Greg KH
2022-12-02 12:43   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230102104004.6abae6da@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=richard@nod.at \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.