From: Thomas Zimmermann <tzimmermann@suse.de>
To: mripard@kernel.org, emma@anholt.net, airlied@gmail.com, daniel@ffwll.ch
Cc: "Maíra Canal" <mcanal@igalia.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org,
"Javier Martinez Canillas" <javierm@redhat.com>
Subject: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth
Date: Thu, 5 Jan 2023 09:07:34 +0100 [thread overview]
Message-ID: <20230105080734.23554-1-tzimmermann@suse.de> (raw)
Invoke the generic console emulation with a 32 bits per pixel. The
preferred color depth is 24, so the current value of 16 bpp is too
small. This results in the following error message
vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported
vc4-drm gpu: [drm] No compatible format found
------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]
The problem has been present for a long, but has only now surfaced
as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format
selection") attempts to improve selection of the color format.
See [1] for the initial bug report.
Reported-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Maíra Canal <mcanal@igalia.com>
Fixes: 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/dri-devel/20230102112927.26565-1-tzimmermann@suse.de/T/#mb09eb6f615f4b0302c78f250b4241ee48d1915f8 # 1
---
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 0ccaee57fe9a..64423b79982f 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
if (ret < 0)
goto unbind_all;
- drm_fbdev_generic_setup(drm, 16);
+ drm_fbdev_generic_setup(drm, 32);
return 0;
--
2.39.0
next reply other threads:[~2023-01-05 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 8:07 Thomas Zimmermann [this message]
2023-01-05 8:14 ` [PATCH] drm/vc4: Start console with 32 bpp / 24 depth Thomas Zimmermann
2023-01-05 8:36 ` Maxime Ripard
2023-01-05 9:11 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105080734.23554-1-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=javierm@redhat.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.