* [PATCH] drm/vc4: Start console with 32 bpp / 24 depth
@ 2023-01-05 8:07 Thomas Zimmermann
2023-01-05 8:14 ` Thomas Zimmermann
2023-01-05 8:36 ` Maxime Ripard
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-01-05 8:07 UTC (permalink / raw)
To: mripard, emma, airlied, daniel
Cc: Maíra Canal, Thomas Zimmermann, dri-devel,
Javier Martinez Canillas
Invoke the generic console emulation with a 32 bits per pixel. The
preferred color depth is 24, so the current value of 16 bpp is too
small. This results in the following error message
vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported
vc4-drm gpu: [drm] No compatible format found
------------[ cut here ]------------
WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]
The problem has been present for a long, but has only now surfaced
as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format
selection") attempts to improve selection of the color format.
See [1] for the initial bug report.
Reported-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Maíra Canal <mcanal@igalia.com>
Fixes: 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/dri-devel/20230102112927.26565-1-tzimmermann@suse.de/T/#mb09eb6f615f4b0302c78f250b4241ee48d1915f8 # 1
---
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 0ccaee57fe9a..64423b79982f 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
if (ret < 0)
goto unbind_all;
- drm_fbdev_generic_setup(drm, 16);
+ drm_fbdev_generic_setup(drm, 32);
return 0;
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth
2023-01-05 8:07 [PATCH] drm/vc4: Start console with 32 bpp / 24 depth Thomas Zimmermann
@ 2023-01-05 8:14 ` Thomas Zimmermann
2023-01-05 8:36 ` Maxime Ripard
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-01-05 8:14 UTC (permalink / raw)
To: mripard, emma, airlied, daniel
Cc: Maíra Canal, Javier Martinez Canillas, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2085 bytes --]
Am 05.01.23 um 09:07 schrieb Thomas Zimmermann:
> Invoke the generic console emulation with a 32 bits per pixel. The
> preferred color depth is 24, so the current value of 16 bpp is too
> small. This results in the following error message
>
> vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported
> vc4-drm gpu: [drm] No compatible format found
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]
>
> The problem has been present for a long, but has only now surfaced
'for a long time'
> as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format
> selection") attempts to improve selection of the color format.
>
> See [1] for the initial bug report.
>
> Reported-by: Maíra Canal <mcanal@igalia.com>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Tested-by: Maíra Canal <mcanal@igalia.com>
> Fixes: 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Link: https://lore.kernel.org/dri-devel/20230102112927.26565-1-tzimmermann@suse.de/T/#mb09eb6f615f4b0302c78f250b4241ee48d1915f8 # 1
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 0ccaee57fe9a..64423b79982f 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
> if (ret < 0)
> goto unbind_all;
>
> - drm_fbdev_generic_setup(drm, 16);
> + drm_fbdev_generic_setup(drm, 32);
>
> return 0;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth
2023-01-05 8:07 [PATCH] drm/vc4: Start console with 32 bpp / 24 depth Thomas Zimmermann
2023-01-05 8:14 ` Thomas Zimmermann
@ 2023-01-05 8:36 ` Maxime Ripard
2023-01-05 9:11 ` Thomas Zimmermann
1 sibling, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2023-01-05 8:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: emma, Maíra Canal, Javier Martinez Canillas, dri-devel
[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]
Hi,
On Thu, Jan 05, 2023 at 09:07:34AM +0100, Thomas Zimmermann wrote:
> Invoke the generic console emulation with a 32 bits per pixel. The
> preferred color depth is 24, so the current value of 16 bpp is too
> small. This results in the following error message
>
> vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported
> vc4-drm gpu: [drm] No compatible format found
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]
>
> The problem has been present for a long, but has only now surfaced
> as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format
> selection") attempts to improve selection of the color format.
>
> See [1] for the initial bug report.
>
> Reported-by: Maíra Canal <mcanal@igalia.com>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Tested-by: Maíra Canal <mcanal@igalia.com>
> Fixes: 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Link: https://lore.kernel.org/dri-devel/20230102112927.26565-1-tzimmermann@suse.de/T/#mb09eb6f615f4b0302c78f250b4241ee48d1915f8 # 1
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 0ccaee57fe9a..64423b79982f 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
> if (ret < 0)
> goto unbind_all;
>
> - drm_fbdev_generic_setup(drm, 16);
> + drm_fbdev_generic_setup(drm, 32);
This is essentially a revert of f741b28fb299.
It's not clear to me what sets the depth preference to 24, because I'd
rather change that.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth
2023-01-05 8:36 ` Maxime Ripard
@ 2023-01-05 9:11 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-01-05 9:11 UTC (permalink / raw)
To: Maxime Ripard; +Cc: dri-devel, Maíra Canal, Javier Martinez Canillas, emma
[-- Attachment #1.1: Type: text/plain, Size: 2501 bytes --]
Hi
Am 05.01.23 um 09:36 schrieb Maxime Ripard:
> Hi,
>
> On Thu, Jan 05, 2023 at 09:07:34AM +0100, Thomas Zimmermann wrote:
>> Invoke the generic console emulation with a 32 bits per pixel. The
>> preferred color depth is 24, so the current value of 16 bpp is too
>> small. This results in the following error message
>>
>> vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported
>> vc4-drm gpu: [drm] No compatible format found
>> ------------[ cut here ]------------
>> WARNING: CPU: 2 PID: 66 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x2e8/0x314 [drm]
>>
>> The problem has been present for a long, but has only now surfaced
>> as commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format
>> selection") attempts to improve selection of the color format.
>>
>> See [1] for the initial bug report.
>>
>> Reported-by: Maíra Canal <mcanal@igalia.com>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Tested-by: Maíra Canal <mcanal@igalia.com>
>> Fixes: 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format selection")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Link: https://lore.kernel.org/dri-devel/20230102112927.26565-1-tzimmermann@suse.de/T/#mb09eb6f615f4b0302c78f250b4241ee48d1915f8 # 1
>> ---
>> drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
>> index 0ccaee57fe9a..64423b79982f 100644
>> --- a/drivers/gpu/drm/vc4/vc4_drv.c
>> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
>> @@ -387,7 +387,7 @@ static int vc4_drm_bind(struct device *dev)
>> if (ret < 0)
>> goto unbind_all;
>>
>> - drm_fbdev_generic_setup(drm, 16);
>> + drm_fbdev_generic_setup(drm, 32);
>
> This is essentially a revert of f741b28fb299.
>
> It's not clear to me what sets the depth preference to 24, because I'd
> rather change that.
I see. We should reduce the preferred color depth to 16 then. [1]
Best regards
Thomas
[1]
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/vc4/vc4_kms.c#L1048
>
> Maxime
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-05 9:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-05 8:07 [PATCH] drm/vc4: Start console with 32 bpp / 24 depth Thomas Zimmermann
2023-01-05 8:14 ` Thomas Zimmermann
2023-01-05 8:36 ` Maxime Ripard
2023-01-05 9:11 ` Thomas Zimmermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.