All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <code@tyhicks.com>
To: stable@vger.kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	"Tyler Hicks" <code@tyhicks.com>
Subject: [PATCH 5.4 0/2] Fix kselftest builds when specifying an output dir
Date: Fri,  6 Jan 2023 16:08:42 -0600	[thread overview]
Message-ID: <20230106220844.763870-1-code@tyhicks.com> (raw)

From: "Tyler Hicks" <code@tyhicks.com>

When attempting to build kselftests with a separate output directory, a
number of the tests fail to build.

For example,

 $ rm -rf build && \
   make INSTALL_HDR_PATH=build/usr headers_install > /dev/null && \
   make O=build FORCE_TARGETS=1 TARGETS=breakpoints -C tools/testing/selftests > /dev/null
 /usr/bin/ld: cannot open output file
 build/kselftest/breakpoints/step_after_suspend_test: No such file or directory
 collect2: error: ld returned 1 exit status
 make[1]: *** [../lib.mk:146: build/kselftest/breakpoints/step_after_suspend_test] Error 1
 make: *** [Makefile:163: all] Error 2

This has already been addressed upstream with v5.18 commit 5ad51ab618de
("selftests: set the BUILD variable to absolute path"). It does not
cleanly cherry pick to the linux-5.4.y branch without v5.7 commit
29e911ef7b70 ("selftests: Fix kselftest O=objdir build from cluttering
top level objdir"). Commit 5ad51ab618de was written in a way that
assumes that the kselftests aren't build in the top level objdir so it
makes sense to bring the pre-req commit back but it does represent a
slight change in behavior since the kselftests will now be built in a
subdir of the specified objdir (O=). 

Tyler

Muhammad Usama Anjum (1):
  selftests: set the BUILD variable to absolute path

Shuah Khan (1):
  selftests: Fix kselftest O=objdir build from cluttering top level
    objdir

 tools/testing/selftests/Makefile | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-01-06 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 22:08 Tyler Hicks [this message]
2023-01-06 22:08 ` [PATCH 5.4 1/2] selftests: Fix kselftest O=objdir build from cluttering top level objdir Tyler Hicks
2023-01-06 22:08 ` [PATCH 5.4 2/2] selftests: set the BUILD variable to absolute path Tyler Hicks
2023-01-12 12:49 ` [PATCH 5.4 0/2] Fix kselftest builds when specifying an output dir Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230106220844.763870-1-code@tyhicks.com \
    --to=code@tyhicks.com \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.