From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations
Date: Sat, 7 Jan 2023 16:01:05 +0100 [thread overview]
Message-ID: <20230107160105.66df4136@aktux> (raw)
In-Reply-To: <0ab84fb8-6173-54e0-abad-a0e0e4ba82e7@linaro.org>
On Sat, 7 Jan 2023 15:09:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 07/01/2023 15:07, Andreas Kemnade wrote:
> > On Sat, 7 Jan 2023 15:00:56 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> > [...]
> >>>> I asked to remove half-compatible. Not to enforce.
> >>>>
> > so you are saying that allowing
> > compatible = "A", "B"
> > is not ok, if B is not fully compatible. I agree with that
> > one.
>
> I did not say that. It's not related to this problem.
>
You said "I asked to remove half-compatible" that means to me
remove "B" if not fully compatible with A which sounds sane to me.
> Again - you cannot have device which is and is not compatible with
> something else. It's not a Schroedinger's cat to be in two states,
> unless you explicitly document the cases (there are exception). If this
> is such exception, it requires it's own documentation.
>
so conclusion:
If having A and B half-compatible with A:
compatible = "A" only: is allowed to specifiy it the binding (status quo),
but not allowed to make the actual dtsi match the binding documentation
https://lore.kernel.org/linux-devicetree/72e1194e10ccb4f87aed96265114f0963e805092.camel@pengutronix.de/
and
https://lore.kernel.org/linux-devicetree/20210924091439.2561931-5-andreas@kemnade.info/
compatible = "A", "B" in the binding definition: is not allowed ("I asked to remove
half-compatible" (= removing B))
having mismatch between binding definition and devicetree causes dtbs_check errors
-> also not nice.
I rather drop this patch and learn to live with dtbs_check errors
for this one since I have no idea how to proceed. All roads are blocked.
This all causes too much churn.
Regards,
Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations
Date: Sat, 7 Jan 2023 16:01:05 +0100 [thread overview]
Message-ID: <20230107160105.66df4136@aktux> (raw)
In-Reply-To: <0ab84fb8-6173-54e0-abad-a0e0e4ba82e7@linaro.org>
On Sat, 7 Jan 2023 15:09:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 07/01/2023 15:07, Andreas Kemnade wrote:
> > On Sat, 7 Jan 2023 15:00:56 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> > [...]
> >>>> I asked to remove half-compatible. Not to enforce.
> >>>>
> > so you are saying that allowing
> > compatible = "A", "B"
> > is not ok, if B is not fully compatible. I agree with that
> > one.
>
> I did not say that. It's not related to this problem.
>
You said "I asked to remove half-compatible" that means to me
remove "B" if not fully compatible with A which sounds sane to me.
> Again - you cannot have device which is and is not compatible with
> something else. It's not a Schroedinger's cat to be in two states,
> unless you explicitly document the cases (there are exception). If this
> is such exception, it requires it's own documentation.
>
so conclusion:
If having A and B half-compatible with A:
compatible = "A" only: is allowed to specifiy it the binding (status quo),
but not allowed to make the actual dtsi match the binding documentation
https://lore.kernel.org/linux-devicetree/72e1194e10ccb4f87aed96265114f0963e805092.camel@pengutronix.de/
and
https://lore.kernel.org/linux-devicetree/20210924091439.2561931-5-andreas@kemnade.info/
compatible = "A", "B" in the binding definition: is not allowed ("I asked to remove
half-compatible" (= removing B))
having mismatch between binding definition and devicetree causes dtbs_check errors
-> also not nice.
I rather drop this patch and learn to live with dtbs_check errors
for this one since I have no idea how to proceed. All roads are blocked.
This all causes too much churn.
Regards,
Andreas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-07 15:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 21:38 [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations Andreas Kemnade
2023-01-05 21:38 ` Andreas Kemnade
2023-01-06 8:41 ` Krzysztof Kozlowski
2023-01-06 8:41 ` Krzysztof Kozlowski
2023-01-06 19:33 ` Andreas Kemnade
2023-01-06 19:33 ` Andreas Kemnade
2023-01-07 13:23 ` Krzysztof Kozlowski
2023-01-07 13:23 ` Krzysztof Kozlowski
2023-01-07 13:43 ` Andreas Kemnade
2023-01-07 13:43 ` Andreas Kemnade
2023-01-07 14:00 ` Krzysztof Kozlowski
2023-01-07 14:00 ` Krzysztof Kozlowski
2023-01-07 14:07 ` Andreas Kemnade
2023-01-07 14:07 ` Andreas Kemnade
2023-01-07 14:09 ` Krzysztof Kozlowski
2023-01-07 14:09 ` Krzysztof Kozlowski
2023-01-07 15:01 ` Andreas Kemnade [this message]
2023-01-07 15:01 ` Andreas Kemnade
2023-01-07 15:07 ` Krzysztof Kozlowski
2023-01-07 15:07 ` Krzysztof Kozlowski
2023-01-07 15:54 ` Andreas Kemnade
2023-01-07 15:54 ` Andreas Kemnade
2023-01-08 14:45 ` Krzysztof Kozlowski
2023-01-08 14:45 ` Krzysztof Kozlowski
2023-01-08 17:20 ` Andreas Kemnade
2023-01-08 17:20 ` Andreas Kemnade
2023-01-09 9:14 ` Krzysztof Kozlowski
2023-01-09 9:14 ` Krzysztof Kozlowski
2023-01-08 22:46 ` Rob Herring
2023-01-08 22:46 ` Rob Herring
2023-01-09 23:15 ` Andreas Kemnade
2023-01-09 23:15 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230107160105.66df4136@aktux \
--to=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.