From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@denx.de>
Cc: tharvey@gateworks.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8m-venice: Remove incorrect 'uart-has-rtscts'
Date: Mon, 9 Jan 2023 15:25:23 +0800 [thread overview]
Message-ID: <20230109072522.GD18301@T480> (raw)
In-Reply-To: <20230102140402.582698-1-festevam@denx.de>
On Mon, Jan 02, 2023 at 11:04:02AM -0300, Fabio Estevam wrote:
> The following build warnings are seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
>
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> ...
>
> The imx8m Venice Gateworks boards do not expose the UART RTS and CTS
> as native UART pins, so 'uart-has-rtscts' should not be used.
>
> Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
> detected by serial.yaml.
>
> Fix the problem by removing the incorrect 'uart-has-rtscts' property.
>
> Fixes: 27c8f4ccc1b9 ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes")
> Fixes: d9a9a7cf32c9 ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs")
> Fixes: 870f645b396b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@denx.de>
Cc: tharvey@gateworks.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8m-venice: Remove incorrect 'uart-has-rtscts'
Date: Mon, 9 Jan 2023 15:25:23 +0800 [thread overview]
Message-ID: <20230109072522.GD18301@T480> (raw)
In-Reply-To: <20230102140402.582698-1-festevam@denx.de>
On Mon, Jan 02, 2023 at 11:04:02AM -0300, Fabio Estevam wrote:
> The following build warnings are seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
>
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]]
> From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> ...
>
> The imx8m Venice Gateworks boards do not expose the UART RTS and CTS
> as native UART pins, so 'uart-has-rtscts' should not be used.
>
> Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
> detected by serial.yaml.
>
> Fix the problem by removing the incorrect 'uart-has-rtscts' property.
>
> Fixes: 27c8f4ccc1b9 ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes")
> Fixes: d9a9a7cf32c9 ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs")
> Fixes: 870f645b396b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
next prev parent reply other threads:[~2023-01-09 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 14:04 [PATCH] arm64: dts: imx8m-venice: Remove incorrect 'uart-has-rtscts' Fabio Estevam
2023-01-02 14:04 ` Fabio Estevam
2023-01-03 18:59 ` Tim Harvey
2023-01-03 18:59 ` Tim Harvey
2023-01-09 7:25 ` Shawn Guo [this message]
2023-01-09 7:25 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109072522.GD18301@T480 \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.