From: Luis Chamberlain <mcgrof@kernel.org>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, p.raghav@samsung.com,
hch@infradead.org, john.johansen@canonical.com,
dhowells@redhat.com, mcgrof@kernel.org
Subject: [RFC 3/3] fs: remove old MS_* internal flags for the superblock
Date: Mon, 9 Jan 2023 18:25:54 -0800 [thread overview]
Message-ID: <20230110022554.1186499-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20230110022554.1186499-1-mcgrof@kernel.org>
During commit e462ec50cb5 ("VFS: Differentiate mount flags (MS_*) from
internal superblock flags") Christoph had suggested we should eventually
remove these old flags which were exposed to userspace but could not
be used as they were internal-only.
Nuke them.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
include/uapi/linux/mount.h | 8 --------
tools/include/uapi/linux/mount.h | 8 --------
2 files changed, 16 deletions(-)
diff --git a/include/uapi/linux/mount.h b/include/uapi/linux/mount.h
index 4d93967f8aea..eb6617a5426b 100644
--- a/include/uapi/linux/mount.h
+++ b/include/uapi/linux/mount.h
@@ -38,14 +38,6 @@
#define MS_STRICTATIME (1<<24) /* Always perform atime updates */
#define MS_LAZYTIME (1<<25) /* Update the on-disk [acm]times lazily */
-/* These sb flags are internal to the kernel */
-#define MS_SUBMOUNT (1<<26)
-#define MS_NOREMOTELOCK (1<<27)
-#define MS_NOSEC (1<<28)
-#define MS_BORN (1<<29)
-#define MS_ACTIVE (1<<30)
-#define MS_NOUSER (1<<31)
-
/*
* Superblock flags that can be altered by MS_REMOUNT
*/
diff --git a/tools/include/uapi/linux/mount.h b/tools/include/uapi/linux/mount.h
index 4d93967f8aea..eb6617a5426b 100644
--- a/tools/include/uapi/linux/mount.h
+++ b/tools/include/uapi/linux/mount.h
@@ -38,14 +38,6 @@
#define MS_STRICTATIME (1<<24) /* Always perform atime updates */
#define MS_LAZYTIME (1<<25) /* Update the on-disk [acm]times lazily */
-/* These sb flags are internal to the kernel */
-#define MS_SUBMOUNT (1<<26)
-#define MS_NOREMOTELOCK (1<<27)
-#define MS_NOSEC (1<<28)
-#define MS_BORN (1<<29)
-#define MS_ACTIVE (1<<30)
-#define MS_NOUSER (1<<31)
-
/*
* Superblock flags that can be altered by MS_REMOUNT
*/
--
2.35.1
next prev parent reply other threads:[~2023-01-10 2:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 2:25 [RFC 0/3] fs: kill old ms_* flags for internal sb Luis Chamberlain
2023-01-10 2:25 ` [RFC 1/3] apparmor: use SB_* flags for private sb flags Luis Chamberlain
2023-01-10 23:40 ` Al Viro
2023-01-10 2:25 ` [RFC 2/3] fs: use SB_NOUSER on path_mount() instead of deprecated MS_NOUSER Luis Chamberlain
2023-01-10 23:43 ` Al Viro
2023-01-10 2:25 ` Luis Chamberlain [this message]
2023-01-10 23:54 ` [RFC 3/3] fs: remove old MS_* internal flags for the superblock Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110022554.1186499-4-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=john.johansen@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.